From owner-freebsd-testing@FreeBSD.ORG Sun May 24 07:08:44 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C0AF6747 for ; Sun, 24 May 2015 07:08:44 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AADA619F1 for ; Sun, 24 May 2015 07:08:44 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4O78iDG036669 for ; Sun, 24 May 2015 07:08:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200423] [devel/kyua] local.kyua.testers.atf_inttest.test__cleanup__crash failed Date: Sun, 24 May 2015 07:08:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2015 07:08:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200423 Bug ID: 200423 Summary: [devel/kyua] local.kyua.testers.atf_inttest.test__cleanup__crash failed Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: tests Assignee: freebsd-testing@freebsd.org Reporter: ngie@FreeBSD.org See https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1053/testReport/junit/local.kyua.testers/atf_inttest/test__cleanup__crash/ Filed upstream as: https://github.com/jmmv/kyua/issues/140 -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@FreeBSD.ORG Sun May 24 07:08:56 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 07096760 for ; Sun, 24 May 2015 07:08:56 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E57E819F2 for ; Sun, 24 May 2015 07:08:55 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4O78tuA036723 for ; Sun, 24 May 2015 07:08:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200423] [devel/kyua] local.kyua.testers.atf_inttest.test__cleanup__crash failed Date: Sun, 24 May 2015 07:08:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jmmv@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2015 07:08:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200423 Garrett Cooper,425-314-3911 changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-testing@freebsd.org |jmmv@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@FreeBSD.ORG Mon May 25 20:40:11 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4089A7EB; Mon, 25 May 2015 20:40:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 01F3A259; Mon, 25 May 2015 20:40:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by igbhj9 with SMTP id hj9so44590267igb.1; Mon, 25 May 2015 13:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=1ogBinC3Ye7OINMEY+Nf9aS/jaIRejUFnMMLN8tdHvA=; b=ofrMquGmrPu+y0HBlBFFRWThQVBXlwEb0CfTuzheCfQ48kWiZzBnWrNBKcWWSV3ipU ydbP0qh9ZIhKIzfbAk7Qvn4SzWUysNZwSAEG5zCCYbbdEyLYGaXX5Vx25ocCpwVzC+cl zKV9XELQ6/dcr6hD/KgqBJXyIdOkd6wjxpbdSd90jrK/F0VHGi97MoeJJCCIU4u4wSME fvV5b5KIfh9V+RlOMURBFEXnGJg+/LjnUnETZJ1aZe1/x6IaJgzI4ILIwWBbi47VY/bo CWFrfFdUzaMAWC/ueMS6kqgy75QSb1w1oL+zZ81O9jqC933D56a/mOJqg/AMy4OcdAvO uBYA== X-Received: by 10.50.79.202 with SMTP id l10mr25562550igx.7.1432586410370; Mon, 25 May 2015 13:40:10 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:edac:574a:2770:5776? ([2601:8:ab80:7d6:edac:574a:2770:5776]) by mx.google.com with ESMTPSA id ij7sm6796455igb.18.2015.05.25.13.40.09 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 May 2015 13:40:09 -0700 (PDT) Subject: Re: cam(4) timeouts in bhyve/kyua runs up on Jenkins? Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5D3EEEA5-1A3C-46B2-82EB-6A94946A4712"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Garrett Cooper In-Reply-To: <553F3CA7.9090601@FreeBSD.org> Date: Mon, 25 May 2015 13:40:07 -0700 Cc: FreeBSD Current , "freebsd-testing@freebsd.org" Message-Id: <9FBE053A-971A-433E-9B88-D62CF9273CFB@gmail.com> References: <28845361-E624-4CB9-B255-1B2C1FD0DF28@gmail.com> <4BEE0A54-3AD2-42DB-AF4E-2B0A5E34DF4E@gmail.com> <553F3CA7.9090601@FreeBSD.org> To: Alexander Motin X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 20:40:11 -0000 --Apple-Mail=_5D3EEEA5-1A3C-46B2-82EB-6A94946A4712 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Apr 28, 2015, at 0:54, Alexander Motin wrote: > Hi. >=20 > On 27.04.2015 21:17, Garrett Cooper wrote: >> On Apr 27, 2015, at 11:16, Garrett Cooper >> wrote: >>=20 >>> I was looking at the console log for the latest kyua run and I=92ve >>> noticed that it=92s timing out a bit more [1] than it was >>> previously [2]. I=92ve seen some of your commits recently to cam(4) >>> dealing with bhyve =97 has there been a performance regression >>> there? Thanks! -NGie >>>=20 >>> 1. >>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/940/console >>> 2. >>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/983/console >>=20 >> (Sorry for not being more explicit for the archives) These are the >> timeouts I=92m referring to: >>=20 >> ahcich0: is 00000000 cs 00000000 ss 1f000000 rs 1f000000 tfd 50 >> serr 00000000 cmd 1000dc17 (ada0:ahcich0:0:0:0): >> WRITE_FPDMA_QUEUED. ACB: 61 08 a8 54 1e 40 00 00 00 00 00 00 >> (ada0:ahcich0:0:0:0): CAM status: Command timeout >> (ada0:ahcich0:0:0:0): Retrying command >=20 > Last time I was more working on bhyve host disk emulation, rather then > on cam(4) running on guest. Considering that, what guest and what host > versions are you running? Is there any other load on host except this = VM > that could cause I/O delays high enough to trigger timeouts? What are > you using to back the virtual disk (file, zvol, ...)? I have no idea what the Jenkins slaves are running in terms of = configuration/version/etc. You=92ll have to ask jenkins-admin@=85 Thanks! -NGie --Apple-Mail=_5D3EEEA5-1A3C-46B2-82EB-6A94946A4712 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVY4ioAAoJEMZr5QU6S73eoGoIAK5f9kc3gPAU3E96tUUvt15y 75QNlP2UkqyEWTsKuDZqi/5wXWYqfos7cK4dDpKKTJIQauk9mDsNhUhRU31aYKhm l/Ehe0MzsisriikzgR31zZBPhcmrlNBFUOIDtVe4Vl+4oNHkzazR37w0igZtdsqv Pl+f33mr0N4vkvuBQwiTSPZPBTVMuZ82txWnDBFY6+JnjuEqN4N4j+OX5avIQ0wn 9ZH2D4+jWIHelc9Gw7r67ozHX2VSfHdQtotTop/PoMjymbngx84Khs/w+s4FskhL TGkGsKP7pzp3ZvwdWEKkxCBfI40T8lSB12i7G8CRtrtRJm3M0GX3VTNM560Qgfw= =yVU5 -----END PGP SIGNATURE----- --Apple-Mail=_5D3EEEA5-1A3C-46B2-82EB-6A94946A4712-- From owner-freebsd-testing@FreeBSD.ORG Mon May 25 20:54:31 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE656D19 for ; Mon, 25 May 2015 20:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 96A0983E for ; Mon, 25 May 2015 20:54:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4PKsVnR075260 for ; Mon, 25 May 2015 20:54:31 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200447] Multiple time-related tests are having issues with Jenkins/Bhyve in the past few months; Jenkins/Bhyve on the cluster is non-performant/less deterministic compared to VMware Fusion 7 Date: Mon, 25 May 2015 20:54:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Services X-Bugzilla-Component: Testing & CI X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jenkins-admin@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 20:54:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200447 Garrett Cooper,425-314-3911 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd-testing@freebsd.org | |, mav@FreeBSD.org, | |neel@freebsd.org Summary|Multiple time-related tests |Multiple time-related tests |are having issues with |are having issues with |Jenkins/Bhyve in the past |Jenkins/Bhyve in the past |few months |few months; Jenkins/Bhyve | |on the cluster is | |non-performant/less | |deterministic compared to | |VMware Fusion 7 -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-testing@FreeBSD.ORG Mon May 25 21:05:19 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8F3D93E1 for ; Mon, 25 May 2015 21:05:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7792EA9D for ; Mon, 25 May 2015 21:05:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4PL5JgW004699 for ; Mon, 25 May 2015 21:05:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200447] Multiple time-related tests are having issues with Jenkins/Bhyve in the past few months; Jenkins/Bhyve on the cluster is non-performant/less deterministic compared to VMware Fusion 7 Date: Mon, 25 May 2015 21:05:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Services X-Bugzilla-Component: Testing & CI X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jenkins-admin@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 21:05:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200447 --- Comment #1 from Garrett Cooper,425-314-3911 --- Backing storage is on spinning rust. I'm running OSX Mavericks 10.9.5. The machine at the time when those numbers were gathered in comment # 0 is mostly idle-ish. $ grep Intel /var/run/dmesg.boot | head -1 CPU: Intel(R) Core(TM) i7-2635QM CPU @ 2.00GHz (2000.07-MHz K8-class CPU) $ sysctl -n hw.physmem 4267769856 $ sudo camcontrol devlist at scbus1 target 0 lun 0 (cd0,pass0) at scbus2 target 0 lun 0 (pass1,da0) $ grep ^da0 /var/run/dmesg.boot da0 at mpt0 bus 0 scbus2 target 0 lun 0 da0: Fixed Direct Access SCSI-2 device da0: 320.000MB/s transfers (160.000MHz, offset 127, 16bit) da0: Command Queueing enabled da0: 40960MB (83886080 512 byte sectors: 255H 63S/T 5221C) -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-testing@FreeBSD.ORG Tue May 26 16:06:26 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 51647DB2; Tue, 26 May 2015 16:06:26 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DBD40330; Tue, 26 May 2015 16:06:25 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: by wichy4 with SMTP id hy4so87693808wic.1; Tue, 26 May 2015 09:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=kVywcyXNcNW7zyOD4+QYRPocdK7dprygcYkQWa6cKEM=; b=bfKiiDBoOFU+DwrBxZojLWnVRqlXfofVGqMCG7wyHK0qtF8js8bSM3K7tcaPdK3tYg KwL1PxvWNY9VoS1ucNK99Acz24Wgut++wugpvoicF1sgCm/oSBgBI8rhn673odKIXJAG KtMtm6MiVDwQVR9zs3COA1/gReBIJ2c42n8vwf8WUpu5RkX6D0hQ/4/RnaEixXswypYY pp08EzMzslcr1WpW1C+Loh1F/PtWM6SlM0UIIYSa2llaOCKhilCCfkcnverccCSvOO7X vf5h0kJqCUdeZH0buw0aXMEmXk1hHZXF9HPGsqxPAY6itS8G2MWh8vD0diq10PhuqfY7 JAMQ== MIME-Version: 1.0 X-Received: by 10.180.90.202 with SMTP id by10mr17948316wib.62.1432656384309; Tue, 26 May 2015 09:06:24 -0700 (PDT) Received: by 10.27.52.18 with HTTP; Tue, 26 May 2015 09:06:24 -0700 (PDT) In-Reply-To: <9FBE053A-971A-433E-9B88-D62CF9273CFB@gmail.com> References: <28845361-E624-4CB9-B255-1B2C1FD0DF28@gmail.com> <4BEE0A54-3AD2-42DB-AF4E-2B0A5E34DF4E@gmail.com> <553F3CA7.9090601@FreeBSD.org> <9FBE053A-971A-433E-9B88-D62CF9273CFB@gmail.com> Date: Tue, 26 May 2015 09:06:24 -0700 Message-ID: Subject: Re: cam(4) timeouts in bhyve/kyua runs up on Jenkins? From: Neel Natu To: Garrett Cooper Cc: Alexander Motin , FreeBSD Current , "freebsd-testing@freebsd.org" , Peter Grehan Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 16:06:26 -0000 Hi NGie, On Mon, May 25, 2015 at 1:40 PM, Garrett Cooper wro= te: > On Apr 28, 2015, at 0:54, Alexander Motin wrote: > >> Hi. >> >> On 27.04.2015 21:17, Garrett Cooper wrote: >>> On Apr 27, 2015, at 11:16, Garrett Cooper >>> wrote: >>> >>>> I was looking at the console log for the latest kyua run and I=E2=80= =99ve >>>> noticed that it=E2=80=99s timing out a bit more [1] than it was >>>> previously [2]. I=E2=80=99ve seen some of your commits recently to cam= (4) >>>> dealing with bhyve =E2=80=94 has there been a performance regression >>>> there? Thanks! -NGie >>>> >>>> 1. >>>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/940/console >>>> 2. >>>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/983/console >>> >>> (Sorry for not being more explicit for the archives) These are the >>> timeouts I=E2=80=99m referring to: >>> >>> ahcich0: is 00000000 cs 00000000 ss 1f000000 rs 1f000000 tfd 50 >>> serr 00000000 cmd 1000dc17 (ada0:ahcich0:0:0:0): >>> WRITE_FPDMA_QUEUED. ACB: 61 08 a8 54 1e 40 00 00 00 00 00 00 >>> (ada0:ahcich0:0:0:0): CAM status: Command timeout >>> (ada0:ahcich0:0:0:0): Retrying command Can you try to reproduce with a virtio-blk instead of ahci-hd? It will help narrow down the problem because both ahci-hd and virtio-blk emulations share a common backend to read/write to the disk. best Neel >> >> Last time I was more working on bhyve host disk emulation, rather then >> on cam(4) running on guest. Considering that, what guest and what host >> versions are you running? Is there any other load on host except this VM >> that could cause I/O delays high enough to trigger timeouts? What are >> you using to back the virtual disk (file, zvol, ...)? > > I have no idea what the Jenkins slaves are running in terms of configurat= ion/version/etc. You=E2=80=99ll have to ask jenkins-admin@=E2=80=A6 > Thanks! > -NGie From owner-freebsd-testing@FreeBSD.ORG Tue May 26 16:16:26 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BF4D16B; Tue, 26 May 2015 16:16:26 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 681FF814; Tue, 26 May 2015 16:16:26 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by pacwv17 with SMTP id wv17so96202659pac.2; Tue, 26 May 2015 09:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NQMoZEdSLexEl/ST0uhsZWU66e2x5j31lGf1bLMt7z8=; b=iGWwb3kDHaoMLSguGK3GxyWphHXRgFccYMZ0SMiKxJJ/P+STShdkXL8kkgeGXYzEJm NIj6ACjxmglqqS46aouINDEvohiyP8oR/xkrqY0PEU10nYNoj0Ir6q4earNnOUvcYpB5 4WiVxGeFmYtgu2TVgFSZCfoDldbOO4TOgYOeByFO9R418DxWH2HwHxUrhwy9TSTKGAbl 5kWsySUUq5XDj1kaPjPIBj67VVx6q51Pp77tolB+cIZDqoe3dToS6aeCQtfsPeGigRQJ apq3WdRnqAMHq7kKdCBROMjzpSd5ryNdOEY47ukV4JSv3DeXTcdsANE8C5gyRzfhvxmV S/GA== X-Received: by 10.70.56.4 with SMTP id w4mr50731740pdp.148.1432656985893; Tue, 26 May 2015 09:16:25 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (he85-184.ewnet.net. [72.52.85.184]) by mx.google.com with ESMTPSA id u10sm13497294pbs.30.2015.05.26.09.16.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 09:16:24 -0700 (PDT) Sender: Alexander Motin Message-ID: <55649C57.1080906@FreeBSD.org> Date: Tue, 26 May 2015 09:16:23 -0700 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Neel Natu , Garrett Cooper CC: FreeBSD Current , "freebsd-testing@freebsd.org" , Peter Grehan Subject: Re: cam(4) timeouts in bhyve/kyua runs up on Jenkins? References: <28845361-E624-4CB9-B255-1B2C1FD0DF28@gmail.com> <4BEE0A54-3AD2-42DB-AF4E-2B0A5E34DF4E@gmail.com> <553F3CA7.9090601@FreeBSD.org> <9FBE053A-971A-433E-9B88-D62CF9273CFB@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 16:16:26 -0000 On 26.05.2015 09:06, Neel Natu wrote: > On Mon, May 25, 2015 at 1:40 PM, Garrett Cooper wrote: >> On Apr 28, 2015, at 0:54, Alexander Motin wrote: >>> On 27.04.2015 21:17, Garrett Cooper wrote: >>>> On Apr 27, 2015, at 11:16, Garrett Cooper >>>> wrote: >>>> >>>>> I was looking at the console log for the latest kyua run and I’ve >>>>> noticed that it’s timing out a bit more [1] than it was >>>>> previously [2]. I’ve seen some of your commits recently to cam(4) >>>>> dealing with bhyve — has there been a performance regression >>>>> there? Thanks! -NGie >>>>> >>>>> 1. >>>>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/940/console >>>>> 2. >>>>> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/983/console >>>> >>>> (Sorry for not being more explicit for the archives) These are the >>>> timeouts I’m referring to: >>>> >>>> ahcich0: is 00000000 cs 00000000 ss 1f000000 rs 1f000000 tfd 50 >>>> serr 00000000 cmd 1000dc17 (ada0:ahcich0:0:0:0): >>>> WRITE_FPDMA_QUEUED. ACB: 61 08 a8 54 1e 40 00 00 00 00 00 00 >>>> (ada0:ahcich0:0:0:0): CAM status: Command timeout >>>> (ada0:ahcich0:0:0:0): Retrying command > > Can you try to reproduce with a virtio-blk instead of ahci-hd? > > It will help narrow down the problem because both ahci-hd and > virtio-blk emulations share a common backend to read/write to the > disk. virtio-blk has no command timeouts, so it may be problematic to notice delayed commands there, unless they stuck forever. This won't be fair comparison. Though if not use TRIM, virtio-blk should be more efficient now, as it is supposed to. >>> Last time I was more working on bhyve host disk emulation, rather then >>> on cam(4) running on guest. Considering that, what guest and what host >>> versions are you running? Is there any other load on host except this VM >>> that could cause I/O delays high enough to trigger timeouts? What are >>> you using to back the virtual disk (file, zvol, ...)? >> >> I have no idea what the Jenkins slaves are running in terms of configuration/version/etc. You’ll have to ask jenkins-admin@… >> Thanks! >> -NGie -- Alexander Motin From owner-freebsd-testing@FreeBSD.ORG Tue May 26 18:45:46 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 52EC1698; Tue, 26 May 2015 18:45:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com [IPv6:2607:f8b0:400d:c04::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0DA11278; Tue, 26 May 2015 18:45:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qgfa63 with SMTP id a63so67508574qgf.0; Tue, 26 May 2015 11:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bIPOHBDjd5YztiLesc+4CvYK+31eP8PdBN7F0xs+1Cs=; b=ZzpVhMP4vsScx7R0Jp15pxPw8R2sY2cM6sRfsJRoIsf1uhxUirQleJ3oL48zD9iLHC O1fbW8VbW0B8+QBTsWNwu1+Y7mSRogg7wIWch22IRFql9DxUJE1fMjF9soCuu3YywIpm GFZ+jOgZUz3j8an/BEhrg/O6PqTiP8ymaWjxP/3Op3NJw5Z3fJJLwFrIIkPxaCN6pK/R hOlcvxUqklbvTz27gNANUBt5ymdRrfMxGC5CrL2AROo2kjHzkvxYKAzw3Ru5X9uUxJRA w4AMF55UThq30Bj2XxcrpNnekzgA0F62o9g686u/PrxRDQ0aWbMiMUoExf5uSPjt6I0/ 5Yiw== MIME-Version: 1.0 X-Received: by 10.55.20.136 with SMTP id 8mr44322575qku.8.1432665945203; Tue, 26 May 2015 11:45:45 -0700 (PDT) Received: by 10.140.98.73 with HTTP; Tue, 26 May 2015 11:45:45 -0700 (PDT) In-Reply-To: References: <28845361-E624-4CB9-B255-1B2C1FD0DF28@gmail.com> <4BEE0A54-3AD2-42DB-AF4E-2B0A5E34DF4E@gmail.com> <553F3CA7.9090601@FreeBSD.org> <9FBE053A-971A-433E-9B88-D62CF9273CFB@gmail.com> Date: Tue, 26 May 2015 11:45:45 -0700 Message-ID: Subject: Re: cam(4) timeouts in bhyve/kyua runs up on Jenkins? From: NGie Cooper To: Neel Natu Cc: Alexander Motin , FreeBSD Current , "freebsd-testing@freebsd.org" , Peter Grehan Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 18:45:46 -0000 Hi Neel, On Tue, May 26, 2015 at 9:06 AM, Neel Natu wrote: > Hi NGie, ... > Can you try to reproduce with a virtio-blk instead of ahci-hd? > > It will help narrow down the problem because both ahci-hd and > virtio-blk emulations share a common backend to read/write to the > disk. You'll have to ask Craig. I don't run BHyve at all, and I don't think that running BHyve over VMware Fusion would be the best "proof of concept" for determining whether or not there's an issue here as VMware Fusion suffers timeouts on occasion with mpt(4) under high load.. Thanks! From owner-freebsd-testing@FreeBSD.ORG Thu May 28 03:12:24 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1D84457 for ; Thu, 28 May 2015 03:12:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9C613A7C for ; Thu, 28 May 2015 03:12:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4S3COfM052376 for ; Thu, 28 May 2015 03:12:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200489] tests/sys/kern/ptrace_test.c:375: wpid == child not met Date: Thu, 28 May 2015 03:12:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 03:12:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200489 Bug ID: 200489 Summary: tests/sys/kern/ptrace_test.c:375: wpid == child not met Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: tests Assignee: freebsd-testing@freebsd.org Reporter: ngie@FreeBSD.org From https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1063/testReport/sys.kern/ptrace_test/ptrace__parent_sees_exit_after_unrelated_debugger/ : /builds/FreeBSD_HEAD/tests/sys/kern/ptrace_test.c:375: wpid == child not met -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@FreeBSD.ORG Thu May 28 04:36:15 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4FCC7ACF for ; Thu, 28 May 2015 04:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 39FFDE37 for ; Thu, 28 May 2015 04:36:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4S4aFsD089012 for ; Thu, 28 May 2015 04:36:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200489] tests/sys/kern/ptrace_test.c:375: wpid == child not met Date: Thu, 28 May 2015 04:36:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 04:36:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200489 --- Comment #1 from Garrett Cooper,425-314-3911 --- Frequency: https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1061/ -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@FreeBSD.ORG Thu May 28 05:58:17 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B0EB96EE for ; Thu, 28 May 2015 05:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AD922E9 for ; Thu, 28 May 2015 05:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4S5wHng005354 for ; Thu, 28 May 2015 05:58:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 200489] tests/sys/kern/ptrace_test.c:375: wpid == child not met Date: Thu, 28 May 2015 05:58:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rodrigc@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 05:58:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200489 Craig Rodrigues changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-testing@freebsd.org |jhb@FreeBSD.org CC| |rodrigc@FreeBSD.org --- Comment #2 from Craig Rodrigues --- This test started failing with this batch of commits: https://jenkins.freebsd.org/job/FreeBSD_HEAD/2800/ This commit looks like the cause: https://svnweb.freebsd.org/base?view=revision&revision=283562 jhb, can you look? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-testing@FreeBSD.ORG Thu May 28 06:30:48 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4ED24C64; Thu, 28 May 2015 06:30:48 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-la0-x22e.google.com (mail-la0-x22e.google.com [IPv6:2a00:1450:4010:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CA7FCD02; Thu, 28 May 2015 06:30:47 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by labko7 with SMTP id ko7so20237785lab.2; Wed, 27 May 2015 23:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=rLmrj1u2fYg8zIjOulYieiwgZ57GBvHM+JvQtoLrFmY=; b=OpvafCJMTVRH/FmkaikUuEo0x3RL3g/awpMCBohsbJIpQljz6Nbg2HCDee9ozXvehX ga5msB1AdnMKZcuJ5QLtaZPTTk1mVIuXDMRw9txeJNeEojblnnIFoDD9b+0e4LYDBEm+ 35cxSU5eY1qocPt8JKnMfUxr9NsqQbrhElyVhDy6WMeh4eiQjzjx0X6sU6R+F8Epr8Pf AevfJ4Qh3UrNcFXgPjF0d3HZtGH1q+fsyZDKjFrCxaHxKXXRhiqFCCDtCdKGPhYsTn0/ ZyqPiGY9pkr+Z/77H2x/A015iXVTiPSEOhoTey3/2vLu7CLhh7pWangowgQxSqMnq3B7 6odA== MIME-Version: 1.0 X-Received: by 10.152.23.66 with SMTP id k2mr1129549laf.89.1432794645830; Wed, 27 May 2015 23:30:45 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.164.38 with HTTP; Wed, 27 May 2015 23:30:45 -0700 (PDT) Date: Wed, 27 May 2015 23:30:45 -0700 X-Google-Sender-Auth: iDN6Glhvg0P7JItmGgNo7bL8Rtk Message-ID: Subject: Need help reducing compilation warnings in CURRENT From: Craig Rodrigues To: freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 06:30:48 -0000 Hi, I've configured Jenkins to highlight compiler warnings and generate a table. Jenkins also keeps track of new compiler warnings over time. See: https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 Can anyone help improve the code by periodically looking at this table and submitting patches to clean up the code? Cleaning up compiler warnings is always boring work, but it is good to clean up the code over time. -- Craig From owner-freebsd-testing@FreeBSD.ORG Thu May 28 07:43:54 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C706EE61; Thu, 28 May 2015 07:43:54 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B8F57A; Thu, 28 May 2015 07:43:54 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obbea2 with SMTP id ea2so26482300obb.3; Thu, 28 May 2015 00:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=YPhkbGKAK0kHXA1m52i/g8TRqCLK9bsKhG7Ps/cRlpk=; b=m00r/a52ZjW6NdE1zFiGvWxI+A1FBuxiM1aCKv1klpSKPYQzN0VC0A18AIXls+jCJs 5DvRnnoJJNvHjTzoBvdnqj5lGuj2WhQn7v20LBekpa76fTSYfQLXcT/7QIUbb1+Sj6ZA BPYyPvkDHxKHrO96/DhGj3Rp+UzQn51KPGsF8xjgN0K1xEROPLLnu8xbt//zVdhX2E+f 0ksNsAd4RisyDdOhr+Bs7hjl6rbJH4g1I4f//SKWdwv4YS4sCSsil40uQvth/mbiHI/J IR+9aD0LJNgHu/0e606qmg/TTfQuVCEbX4+DHjsR8ICd1tyufGf11It99sQkmcFnPV7C sKmg== MIME-Version: 1.0 X-Received: by 10.202.98.193 with SMTP id w184mr1203577oib.96.1432799033924; Thu, 28 May 2015 00:43:53 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Thu, 28 May 2015 00:43:53 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: Date: Thu, 28 May 2015 15:43:53 +0800 Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Marcelo Araujo To: Craig Rodrigues Cc: freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 07:43:55 -0000 Hi Craig, I can give a hand with it. Best, 2015-05-28 14:30 GMT+08:00 Craig Rodrigues : > Hi, > > I've configured Jenkins to highlight compiler warnings and > generate a table. Jenkins also keeps track of new compiler warnings > over time. See: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > Can anyone help improve the code by periodically looking > at this table and submitting patches to clean up the code? > > Cleaning up compiler warnings is always boring work, > but it is good to clean up the code over time. > > -- > Craig > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_) From owner-freebsd-testing@FreeBSD.ORG Thu May 28 12:39:00 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B0087201; Thu, 28 May 2015 12:39:00 +0000 (UTC) (envelope-from xmj@freebsd.org) Received: from dd16522.kasserver.com (dd16522.kasserver.com [85.13.137.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 709512FE; Thu, 28 May 2015 12:39:00 +0000 (UTC) (envelope-from xmj@freebsd.org) Received: from mx12.chaot.net (82.131.85.156.cable.starman.ee [82.131.85.156]) by dd16522.kasserver.com (Postfix) with ESMTPSA id 4505F45602F; Thu, 28 May 2015 14:38:51 +0200 (CEST) Received: from mx12.chaot.net (localhost [127.0.0.1]); by mx12.chaot.net (OpenSMTPD) with ESMTP id c54f98ef; Thu, 28 May 2015 15:38:50 +0300 (EEST) Message-ID: <55670C5A.6080500@FreeBSD.org> Date: Thu, 28 May 2015 15:38:50 +0300 From: Johannes Jost Meixner User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Craig Rodrigues , freebsd-current Current , "freebsd-testing@freebsd.org" Subject: Re: Need help reducing compilation warnings in CURRENT References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 12:39:00 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Craig, I'll gladly help (good excuse to learn C), but looking at those errors in general, one thing pops out: The warnings are almost all in contrib/ areas. Hence, any fix might want to probably be submitted to upstream first. Correct me if I'm missing something obvious here please ;-) - -J On 05/28/2015 09:30, Craig Rodrigues wrote: > Hi, > > I've configured Jenkins to highlight compiler warnings and generate > a table. Jenkins also keeps track of new compiler warnings over > time. See: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > Can anyone help improve the code by periodically looking at this > table and submitting patches to clean up the code? > > Cleaning up compiler warnings is always boring work, but it is good > to clean up the code over time. > > -- Craig _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing To > unsubscribe, send any mail to > "freebsd-testing-unsubscribe@freebsd.org" > - -- Johannes Meixner | FreeBSD Committer xmj@FreeBSD.org | http://people.freebsd.org/~xmj -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= =FziJ -----END PGP SIGNATURE----- From owner-freebsd-testing@FreeBSD.ORG Thu May 28 12:45:13 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C03043C; Thu, 28 May 2015 12:45:13 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 278B177E; Thu, 28 May 2015 12:45:12 +0000 (UTC) (envelope-from 5u623l20@gmail.com) Received: by igbjd9 with SMTP id jd9so22785796igb.1; Thu, 28 May 2015 05:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=R/7fMaje5Wo6bE4x0ylrH5GCbzsdKy8lyA8wFRba4Bk=; b=hVbuJ06AMYiTyrR1JY595geuqr1j0MO0lyn5gnk8Y9z57yG9Sy5ZVQ+RMq1NcySwrM Q66+RcT2yzLEZVJ0FNYaGlM4eVufbD1JLLy3CJntbzWTufukNWqrKSbQGdauU0Q+RUIA A2ku2vWoNxGT3F7SeUT20Wt2sIiDFm0BgQjMPPxVp0Xe4VHdhb0AdgfB5fgQL3sWspaq 2uDLWQkFNVKMZ22D2iUhQSHRjsIzx/CFCf77f7eDn/CqqU8unxNHZEMLKGlfm04alnML G8mluRkI74xASBlvcY4XwBwwXOp3WLZXWsr68W5Oo4nIwF2KHmRjZj+d54/iSi2iZGyA Kx6g== X-Received: by 10.43.63.76 with SMTP id xd12mr9298315icb.11.1432817106321; Thu, 28 May 2015 05:45:06 -0700 (PDT) Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com. [209.85.213.177]) by mx.google.com with ESMTPSA id g1sm1672581iog.4.2015.05.28.05.45.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:45:06 -0700 (PDT) Received: by igbhj9 with SMTP id hj9so113025724igb.1; Thu, 28 May 2015 05:45:05 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.107.25.199 with SMTP id 190mr3165316ioz.11.1432817105629; Thu, 28 May 2015 05:45:05 -0700 (PDT) Received: by 10.64.20.109 with HTTP; Thu, 28 May 2015 05:45:05 -0700 (PDT) In-Reply-To: <55670C5A.6080500@FreeBSD.org> References: <55670C5A.6080500@FreeBSD.org> Date: Thu, 28 May 2015 18:45:05 +0600 Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Muhammad Moinur Rahman To: Johannes Jost Meixner Cc: Craig Rodrigues , freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 12:45:13 -0000 Hi, Can anyone give me any ideas about how can I contribute some of my idle times? Do I need commit bit to submit patches in Jenkins? Or should I submit through CODE Review? BR, @bofh On Thu, May 28, 2015 at 6:38 PM, Johannes Jost Meixner wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Hi Craig, > > I'll gladly help (good excuse to learn C), but looking at those errors > in general, one thing pops out: > > The warnings are almost all in contrib/ areas. Hence, any fix might > want to probably be submitted to upstream first. > > Correct me if I'm missing something obvious here please ;-) > > - -J > > On 05/28/2015 09:30, Craig Rodrigues wrote: > > Hi, > > > > I've configured Jenkins to highlight compiler warnings and generate > > a table. Jenkins also keeps track of new compiler warnings over > > time. See: > > > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > > > Can anyone help improve the code by periodically looking at this > > table and submitting patches to clean up the code? > > > > Cleaning up compiler warnings is always boring work, but it is good > > to clean up the code over time. > > > > -- Craig _______________________________________________ > > freebsd-testing@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-testing To > > unsubscribe, send any mail to > > "freebsd-testing-unsubscribe@freebsd.org" > > > > - -- > Johannes Meixner | FreeBSD Committer > xmj@FreeBSD.org | http://people.freebsd.org/~xmj > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ > KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i > kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj > qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF > E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx > DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= > =FziJ > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-testing@FreeBSD.ORG Thu May 28 13:33:49 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1631D6B; Thu, 28 May 2015 13:33:49 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A183F33C; Thu, 28 May 2015 13:33:49 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obbea2 with SMTP id ea2so32645907obb.3; Thu, 28 May 2015 06:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=pKk1XHHFFfZZnZTXtAoF79NBMl6HLQ+jhV2MH5zr17E=; b=VcTU38E8VeYEdQuFnjPD/AnPn6aHo2lVNoHB8QdVcefkA4T8msnZ/7a6UqennxfVzG POm3Fci/4FOskuqqVoPQj6XZb4TCxjKkJNunwLB3BFyEILVB+XDPa9aQAaIpeFakdNDn 4imcG+661DSzTTbfO8Z7ne9M3lTDv/pw93BRq/Q3IcNRfihZChGp3peFLZol59CHJWbI H25Yey8tvbRq6CxMs0rzWRIvzQTllRzF8m+c2EZWmdwSF3EhLa4n6rFVmfWlYnH2PHEa Bb2h4/OzDayXPKHVLjErTNYVYQjX4pJO20+Soww7feFiIqvLWLy47suY8vObJbBGjLOr o34Q== MIME-Version: 1.0 X-Received: by 10.60.82.67 with SMTP id g3mr2493748oey.29.1432820028931; Thu, 28 May 2015 06:33:48 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Thu, 28 May 2015 06:33:48 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <55670C5A.6080500@FreeBSD.org> Date: Thu, 28 May 2015 21:33:48 +0800 Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Marcelo Araujo To: Muhammad Moinur Rahman Cc: Johannes Jost Meixner , Craig Rodrigues , freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 13:33:50 -0000 Hi, You don't need src bit to submit any patch and you can do it via review without any problem. Just try to drive the patch to the right person. Best, 2015-05-28 20:45 GMT+08:00 Muhammad Moinur Rahman : > Hi, > > Can anyone give me any ideas about how can I contribute some of my idle > times? Do I need commit bit to submit patches in Jenkins? Or should I > submit through CODE Review? > > BR, > @bofh > > On Thu, May 28, 2015 at 6:38 PM, Johannes Jost Meixner > wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Hi Craig, > > > > I'll gladly help (good excuse to learn C), but looking at those errors > > in general, one thing pops out: > > > > The warnings are almost all in contrib/ areas. Hence, any fix might > > want to probably be submitted to upstream first. > > > > Correct me if I'm missing something obvious here please ;-) > > > > - -J > > > > On 05/28/2015 09:30, Craig Rodrigues wrote: > > > Hi, > > > > > > I've configured Jenkins to highlight compiler warnings and generate > > > a table. Jenkins also keeps track of new compiler warnings over > > > time. See: > > > > > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > > > > > Can anyone help improve the code by periodically looking at this > > > table and submitting patches to clean up the code? > > > > > > Cleaning up compiler warnings is always boring work, but it is good > > > to clean up the code over time. > > > > > > -- Craig _______________________________________________ > > > freebsd-testing@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/freebsd-testing To > > > unsubscribe, send any mail to > > > "freebsd-testing-unsubscribe@freebsd.org" > > > > > > > - -- > > Johannes Meixner | FreeBSD Committer > > xmj@FreeBSD.org | http://people.freebsd.org/~xmj > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v2 > > > > iQEcBAEBCAAGBQJVZwxUAAoJEPyeKTcbGw0Lh7wH/2G4ZvwLCvDisEp4pJthlaQZ > > KNSQWTGILkhGWK2NkDqe5zsFl4SbTGIH83JgHZVoArChoa5vxQ6FXgdyYNl6ep2i > > kGveOpE/U/Z2OT89Jirh4dllxkSHYNd76vbUWJrG70Cgss+5JNuYxO/1hO6Vg0xj > > qnq1sSggjQzlMG5tgA3vobPz73p17eUdsWhlVgER18OJ3I7ZKEB+spYiu8B3N3HF > > E0CsoOy9NaLmVD0i7oZpaH8Rev8CJzJ9hBTDex6o/pIR735/3SZu+NtOGfU4Viqx > > DFfE1qIQUO1uXDFb9UK7s0SanTzJnzi9amWoiB1DSGKhgTbAF5XeTqRso6QyVxw= > > =FziJ > > -----END PGP SIGNATURE----- > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to " > freebsd-current-unsubscribe@freebsd.org" > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_) From owner-freebsd-testing@FreeBSD.ORG Thu May 28 14:27:04 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 24C42912 for ; Thu, 28 May 2015 14:27:04 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) by mx1.freebsd.org (Postfix) with ESMTP id 00124266 for ; Thu, 28 May 2015 14:27:03 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [192.168.1.2] (unknown [192.168.1.2]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 96A9E79FA for ; Thu, 28 May 2015 14:27:02 +0000 (UTC) Message-ID: <556725BB.2040805@freebsd.org> Date: Thu, 28 May 2015 10:27:07 -0400 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: freebsd-testing@freebsd.org Subject: Re: Need help reducing compilation warnings in CURRENT References: <55670C5A.6080500@FreeBSD.org> In-Reply-To: <55670C5A.6080500@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="loR10lhlcr6Bhi59uiuh9eFQ2XweD4oow" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 14:27:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --loR10lhlcr6Bhi59uiuh9eFQ2XweD4oow Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-05-28 08:38, Johannes Jost Meixner wrote: > Hi Craig, >=20 > I'll gladly help (good excuse to learn C), but looking at those errors > in general, one thing pops out: >=20 > The warnings are almost all in contrib/ areas. Hence, any fix might > want to probably be submitted to upstream first. >=20 > Correct me if I'm missing something obvious here please ;-) >=20 > -J >=20 > On 05/28/2015 09:30, Craig Rodrigues wrote: >> Hi, >=20 >> I've configured Jenkins to highlight compiler warnings and generate >> a table. Jenkins also keeps track of new compiler warnings over >> time. See: >=20 >> https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 >=20 >> Can anyone help improve the code by periodically looking at this >> table and submitting patches to clean up the code? >=20 >> Cleaning up compiler warnings is always boring work, but it is good >> to clean up the code over time. >=20 >> -- Craig _______________________________________________=20 >=20 Johannes has a point, it probably makes sense to exclude contrib/ and cddl/ from the warnings tracking. --=20 Allan Jude --loR10lhlcr6Bhi59uiuh9eFQ2XweD4oow Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJVZyW+AAoJEJrBFpNRJZKf/sEQALccsN1NUl6w6tibir3gFrDg GMSRV7yA5KpsPPYP3qzXnhVgnZ69e/5O6uuoEh/BB+6kTBm3K593Gseliif+NdIw gAsDWVaClBmrinjhfzGVJLCZb9msvxZN2et4/oSVk1FuzR/9w6kb0CIBiH3NMFUA xuyg34ge6cHqXtKyVFSWMn7TPS9VHb++7FnedLaDcwfW5wEAXHBJYGrOFxyj9s8S kEw/+rgsis8IdaE0PD4v5VKGgED2S2G5psl9OQR7rJrJXD8Zsluum+ixBnVWCgNR 2UT7hOcKFhHmeKyUMxXmIRu94isi+6uUwpoYaUFZxyrOT4aMiO5n/5sy9J642q8j l2D7iKUygyBXxd6qFz1M0R5Hw9p6C/EGn8C+ILw5vnLMq49BGf0PYJV7lMm6nnel GJ5VeMXoZ1eUFGYQBXC03wyaEsA5pelj0BA+hBFfkwDCESLSbc3cuD5tAe9l+fI5 NgMDadzJIZ3gEdDBiOqhkAPhtb/MuqxgS0aOmKkyDtK9r5FGu96O72OKwrWMSG32 HE3qZlCzz/JM3iRyDOuZ6R4Eja+OJocmo3cMmAVfS0yFgeWPS/gQv224Pc1OnMlF i0QeRzNyx7R08eg3GahhWO6DmZLMGhFqNDcy6h+B/yExXDAFJpYExgNmKNcRS8aR ZtBhe//1nkqc/6ucrFYo =XzVC -----END PGP SIGNATURE----- --loR10lhlcr6Bhi59uiuh9eFQ2XweD4oow-- From owner-freebsd-testing@FreeBSD.ORG Thu May 28 16:34:30 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9DDFA2B; Thu, 28 May 2015 16:34:30 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A03308B7; Thu, 28 May 2015 16:34:30 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by oiww2 with SMTP id w2so36629536oiw.0; Thu, 28 May 2015 09:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=3vU/0nAq0QsQamwN+AAHd+fygjfmuDo/AcztQH7g2jk=; b=cqnPxku6rOxrZZcFth559h0Zcr9E6iUT4hBXfvzq084lOct8PX6VorMLM5WWqFcd2N NLa05Y5yS5p40enI71ulSF6uXpndvkcGYpsl0BXGKwa79FSWRp106IoKVMDNkb5IyDag /0ZwewRbHqzsyjL9W+dcLfYRxwHLr6E4zvhtLopJ3PfwYpYBQc1MPjco+UCSX0JK4Wad EA+fiL6Q2xh9X07/dHhdmuWKGq91sfMcXNiKO6iyWFGyFXRHPm7DOroBWKLnv90QO7Bv fz/9ph7QoMjU6LVqId2fhKmbs8mo+WqdMy+FYQJjZnpv39j8aETALhNCd11TGmsylwZk V9sA== MIME-Version: 1.0 X-Received: by 10.60.81.98 with SMTP id z2mr3260272oex.37.1432830869921; Thu, 28 May 2015 09:34:29 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.107.3 with HTTP; Thu, 28 May 2015 09:34:29 -0700 (PDT) In-Reply-To: <556725BB.2040805@freebsd.org> References: <55670C5A.6080500@FreeBSD.org> <556725BB.2040805@freebsd.org> Date: Thu, 28 May 2015 10:34:29 -0600 X-Google-Sender-Auth: kDbWhpInLkezXFQiGNV5-OMioBw Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Alan Somers To: Allan Jude Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 16:34:30 -0000 On Thu, May 28, 2015 at 8:27 AM, Allan Jude wrote: > On 2015-05-28 08:38, Johannes Jost Meixner wrote: >> Hi Craig, >> >> I'll gladly help (good excuse to learn C), but looking at those errors >> in general, one thing pops out: >> >> The warnings are almost all in contrib/ areas. Hence, any fix might >> want to probably be submitted to upstream first. >> >> Correct me if I'm missing something obvious here please ;-) >> >> -J >> >> On 05/28/2015 09:30, Craig Rodrigues wrote: >>> Hi, >> >>> I've configured Jenkins to highlight compiler warnings and generate >>> a table. Jenkins also keeps track of new compiler warnings over >>> time. See: >> >>> https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 >> >>> Can anyone help improve the code by periodically looking at this >>> table and submitting patches to clean up the code? >> >>> Cleaning up compiler warnings is always boring work, but it is good >>> to clean up the code over time. >> >>> -- Craig _______________________________________________ >> > > Johannes has a point, it probably makes sense to exclude contrib/ and > cddl/ from the warnings tracking. I agree about contrib. But don't exclude all of cddl/, just exclude cddl/contrib. -Alan with one l > > -- > Allan Jude > From owner-freebsd-testing@FreeBSD.ORG Thu May 28 16:49:45 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AD8EE37C; Thu, 28 May 2015 16:49:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3D458B99; Thu, 28 May 2015 16:49:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t4SGneG4090603 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 28 May 2015 19:49:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t4SGneG4090603 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t4SGneH4090602; Thu, 28 May 2015 19:49:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 28 May 2015 19:49:40 +0300 From: Konstantin Belousov To: freebsd-current Current , "freebsd-testing@freebsd.org" Subject: Re: Need help reducing compilation warnings in CURRENT Message-ID: <20150528164940.GC2499@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 16:49:45 -0000 On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: > Hi, > > I've configured Jenkins to highlight compiler warnings and > generate a table. Jenkins also keeps track of new compiler warnings > over time. See: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 > > Can anyone help improve the code by periodically looking > at this table and submitting patches to clean up the code? > > Cleaning up compiler warnings is always boring work, > but it is good to clean up the code over time. I take some time to do a pass over mine code or code I am somewhat knowledgable, to correct some 'assigned but not used variable' warnings. There might be even one real bug in SU code uncovered, but I am not sure yet. Please review at https://reviews.freebsd.org/D2665 . I do not have an intention of splitting this into individual changes. From owner-freebsd-testing@FreeBSD.ORG Thu May 28 19:09:38 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C4834A1; Thu, 28 May 2015 19:09:38 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A034300; Thu, 28 May 2015 19:09:38 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by laat2 with SMTP id t2so39481136laa.1; Thu, 28 May 2015 12:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=lfgaETHRDUlGk7iJHRLtfQmLBcIxuOBMZAxUUoSPC0I=; b=G382AxFwbcmPbVlKC5twSG5BhvB2iOMpymMxGxOZd/GADtjzoSYE3z07qU6O60Qij4 LnpmpMGcUB0mNktVFzkagvWEnFsBhvNFoDjMe2w7PPOkZmGtYvOTEeqzUZmibtwNWkT6 sWNOK3BxlfK4AFE0e/Yl4YzOSixyNhO17kcdg7PMF6W55usuHE0WfThqgbs0wp9KMReR k9O8Ru++KCXsA4vTHX3dMjNLucxK48LZIlE0mUcM/lTPQ4iThfoGaEWN6TQ1vToaeVPS 34atXDL5S3ldXnNP8roEawPzo1e+5hwPwFKr45JmrF6BB8A5pyQT4BF6p2Z0AN5NNG07 M7UQ== MIME-Version: 1.0 X-Received: by 10.152.22.34 with SMTP id a2mr4355108laf.59.1432840175848; Thu, 28 May 2015 12:09:35 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.164.38 with HTTP; Thu, 28 May 2015 12:09:35 -0700 (PDT) In-Reply-To: <55670C5A.6080500@FreeBSD.org> References: <55670C5A.6080500@FreeBSD.org> Date: Thu, 28 May 2015 12:09:35 -0700 X-Google-Sender-Auth: b3LYPLe1GB-7AstPi3l37TQJVZU Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Craig Rodrigues To: Johannes Jost Meixner Cc: freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 19:09:39 -0000 On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Hi Craig, > > I'll gladly help (good excuse to learn C), but looking at those errors > in general, one thing pops out: > > The warnings are almost all in contrib/ areas. Hence, any fix might > want to probably be submitted to upstream first. > Sure, if we can push fixes upstream that would be great. However, we shouldn't let that block us from comitting fixes to FreeBSD. The advantage of having code in the FreeBSD repo is that we can change it if we need to, even if the fix isn't yet in the upstream sources. Contrib code is not made out of stone that can't be modified! -- Craig From owner-freebsd-testing@FreeBSD.ORG Thu May 28 19:18:12 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B814D277; Thu, 28 May 2015 19:18:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 56636785; Thu, 28 May 2015 19:18:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wgbgq6 with SMTP id gq6so44799533wgb.3; Thu, 28 May 2015 12:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=GKf/X+Rhxq9T9HJi4MNVUla92JWo2MoxYspj2q8o8pE=; b=orgg4lb2hlwYS/RGwYG3A3a95Dwtu+YGfQl2r9UOI3E8zxxRPbuv8NOwEHUWmBR/r7 p7UL3fxB7WlbWTl12MmydPi8CxgMnVeQjvTHBA72TVAyuoi7yHHwvX3EwMnf2ESCphws M//xlXPBkBsnxMt0exL7VioQRl1gX5MvX/OKKAFUvgbrmt4unHGfUcB4QB/RaTz2CYWn 2LkilJAJE2tvTZkuQgBnqbGhzPMxUxnyO5E4qvRcjaKqDLhAKaO3sbc/+oVx4t+/HJFp Mems1Zx6SDHIwp4zA6O+5j+Re40yqoqWNkjJXKYYVWU9Ny+kP+LGhAf5EW7R6PoITEbP ypQA== X-Received: by 10.195.13.113 with SMTP id ex17mr7890989wjd.17.1432840690672; Thu, 28 May 2015 12:18:10 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id o5sm214273wia.0.2015.05.28.12.18.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 12:18:09 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 28 May 2015 21:18:07 +0200 From: Baptiste Daroussin To: Craig Rodrigues Cc: Johannes Jost Meixner , freebsd-current Current , "freebsd-testing@freebsd.org" Subject: Re: Need help reducing compilation warnings in CURRENT Message-ID: <20150528191806.GB70327@ivaldir.etoilebsd.net> References: <55670C5A.6080500@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LyciRD1jyfeSSjG0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 19:18:12 -0000 --LyciRD1jyfeSSjG0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner > wrote: >=20 > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Hi Craig, > > > > I'll gladly help (good excuse to learn C), but looking at those errors > > in general, one thing pops out: > > > > The warnings are almost all in contrib/ areas. Hence, any fix might > > want to probably be submitted to upstream first. > > >=20 >=20 > Sure, if we can push fixes upstream that would be great. > However, we shouldn't let that block us from comitting fixes to FreeBSD. > The advantage of having code in the FreeBSD repo is that we can > change it if we need to, even if the fix isn't yet in the upstream source= s. > Contrib code is not made out of stone that can't be modified! >=20 If not upstreamed, there is a good chance it get lost during the next updat= e. So in the special case of warning fixes, I would strongly advice to upstream first!! Best regards, Bapt --LyciRD1jyfeSSjG0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVnae4ACgkQ8kTtMUmk6ExZ2wCdFxVanUstn/epGAk8PsFt4uHI dnUAn2WUKTTX2ObLbG7Kq3ziMVI1wyYD =X+Va -----END PGP SIGNATURE----- --LyciRD1jyfeSSjG0-- From owner-freebsd-testing@FreeBSD.ORG Thu May 28 22:07:02 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BB760ECC; Thu, 28 May 2015 22:07:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com [IPv6:2607:f8b0:400d:c04::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 760E162F; Thu, 28 May 2015 22:07:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qgf2 with SMTP id 2so22545738qgf.3; Thu, 28 May 2015 15:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9YrIfnVs4Y/F9T8Fp5dLZ1gkLtV9/mhvhZJEJG2fO6Y=; b=YVQIME/xdytRBoXfvv2MNeFV1WVFHqBILGFwZ1+HtGpQYerEIjg2hgjFpYyMq7D2R3 G1M5uuXn9o3GQLs2V2evoDJw/Kg7MTNfofGaSV9XTQdHz6DGStXRFcYrYdxQ7Ta1AGyH aLsd0fozcxJ4kexAsOgIZBrGNd7vmbG8R5orHCcZ7FNACO31XKoX2PoqaqU0eH5ejJkZ +D+m5w1LMbUoOpmuxghxXxLeONcVSqMS5QCvZLnA/xUeLxUQx7E2gWJQs12OZ+F4G1rS YruzYpy4meMgaDPCm1Nobk4jBjz36O+Xop9DFJVSNeIKrJXoHVxdu40WM5FjClLUn2Dl ux0g== MIME-Version: 1.0 X-Received: by 10.141.18.136 with SMTP id u130mr6129365qhd.54.1432850821608; Thu, 28 May 2015 15:07:01 -0700 (PDT) Received: by 10.140.98.73 with HTTP; Thu, 28 May 2015 15:07:01 -0700 (PDT) In-Reply-To: <20150528191806.GB70327@ivaldir.etoilebsd.net> References: <55670C5A.6080500@FreeBSD.org> <20150528191806.GB70327@ivaldir.etoilebsd.net> Date: Thu, 28 May 2015 15:07:01 -0700 Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: NGie Cooper To: Baptiste Daroussin Cc: Craig Rodrigues , Johannes Jost Meixner , freebsd-current Current , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 22:07:02 -0000 On Thu, May 28, 2015 at 12:18 PM, Baptiste Daroussin wrote: ... > If not upstreamed, there is a good chance it get lost during the next update. So > in the special case of warning fixes, I would strongly advice to upstream > first!! +200 Plus upstream sources generally get slammed by multiple downstream projects, so if we can contribute back fixes or pull in upstream fixes as cherrypicks through the vendor tree, then that would reduce our diff and make sure that upstream projects benefit from our changes. The only time we should really be modifying and not giving back is when we have FreeBSD-specific modifications that don't make sense in upstream projects. Those should be rare occurrences though... Thanks, -NGie From owner-freebsd-testing@FreeBSD.ORG Thu May 28 22:33:52 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA8C7469; Thu, 28 May 2015 22:33:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 90D30CD2; Thu, 28 May 2015 22:33:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::9dd2:9f27:c86f:473e] (unknown [IPv6:2001:7b8:3a7:0:9dd2:9f27:c86f:473e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B18892739E; Fri, 29 May 2015 00:33:40 +0200 (CEST) Subject: Re: Need help reducing compilation warnings in CURRENT Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Fri, 29 May 2015 00:33:31 +0200 Cc: Johannes Jost Meixner , freebsd-current Current , "freebsd-testing@freebsd.org" Message-Id: References: <55670C5A.6080500@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 22:33:53 -0000 --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 28 May 2015, at 21:09, Craig Rodrigues wrote: > > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner ... >> The warnings are almost all in contrib/ areas. Hence, any fix might >> want to probably be submitted to upstream first. >> > Sure, if we can push fixes upstream that would be great. > However, we shouldn't let that block us from comitting fixes to FreeBSD. Yes, that should block us in most cases, since it will make future merges more difficult. We should only fix these types of warnings locally, if: 1) The contrib project's upstream is dead, unresponsive, or hostile. 2) You are sure that you don't introduce new bugs by modifying stuff. (You definitely don't want to repeat e.g. Debian's OpenSSL fiasco.) 3) You are sure that the warning exposes a real bug, that cannot be worked around in some other way. 4) You are sure that you want to take the maintenance burden of future merges. > The advantage of having code in the FreeBSD repo is that we can > change it if we need to, even if the fix isn't yet in the upstream sources. > Contrib code is not made out of stone that can't be modified! Certainly not, but unless you have very good reasons to modify upstream code locally, you should not bother. Better spend your energy to file fixes upstream, and let *them* verify that they are correct. -Dimitry --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlVnl8QACgkQsF6jCi4glqMv1QCglnhQ84EEfCBtWHltsahsApky 9lwAoLNsJfNJ+szQJdSxkaTAxT4JUqos =476i -----END PGP SIGNATURE----- --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0-- From owner-freebsd-testing@FreeBSD.ORG Fri May 29 00:42:17 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88CC77DE; Fri, 29 May 2015 00:42:17 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-yk0-x22e.google.com (mail-yk0-x22e.google.com [IPv6:2607:f8b0:4002:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 45A301E1E; Fri, 29 May 2015 00:42:17 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by yked142 with SMTP id d142so17822966yke.3; Thu, 28 May 2015 17:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=HyI4Pi+FiJR8V/8M46cWf5OlJ+wMwwuDgZZ7Bu+CA10=; b=KRxniqYq7Mk7JxcxA/BWe7QOMED/BgTZwSrSDj7ek/8GG8WenMdoaDpo8+CIutFtIo LcmIcg//PFpKQTGKAedLUyVd/xF4g87ssBJZq4UlPxJcklciTQ5X54LOespv98tzIszU 1/V3ORBX6M3S4sluO5NwWbGpTYnPCeaMHWl0jHG0G9L+3qa+JQEEer29jZhR+2Z+WUS6 1kXLw8G3zSDkKJ8xAjTb1ZQTKgagq2Os7vt3LIf/cMzza927gQvDlCD/sZxF7aGZeC5N zGNNeMQQNFiaBnJnlD+2L+UJsmxTHpJQOIQo5/Fuo41MHtFJysf0w2tP+di2FC6oS/Zs KB/w== MIME-Version: 1.0 X-Received: by 10.236.8.104 with SMTP id 68mr5381983yhq.67.1432860136355; Thu, 28 May 2015 17:42:16 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.13.233.70 with HTTP; Thu, 28 May 2015 17:42:16 -0700 (PDT) In-Reply-To: References: <55670C5A.6080500@FreeBSD.org> Date: Thu, 28 May 2015 17:42:16 -0700 X-Google-Sender-Auth: Bi_w2wivbUV6mae7H5zl5g0_8Aw Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Craig Rodrigues To: freebsd-current Current Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 00:42:17 -0000 On Thu, May 28, 2015 at 5:45 AM, Muhammad Moinur Rahman wrote: > Hi, > > Can anyone give me any ideas about how can I contribute some of my idle > times? Do I need commit bit to submit patches in Jenkins? Or should I > submit through CODE Review? > Please read this: https://wiki.freebsd.org/CodeReview for instructions on how you can send patches to our code review tool. -- Craig From owner-freebsd-testing@FreeBSD.ORG Fri May 29 01:36:51 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8466614B for ; Fri, 29 May 2015 01:36:51 +0000 (UTC) (envelope-from xmj@freebsd.org) Received: from dd16522.kasserver.com (dd16522.kasserver.com [85.13.137.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 447521945 for ; Fri, 29 May 2015 01:36:51 +0000 (UTC) (envelope-from xmj@freebsd.org) Received: from mx12.chaot.net (82.131.85.156.cable.starman.ee [82.131.85.156]) by dd16522.kasserver.com (Postfix) with ESMTPSA id DFCB145611D for ; Fri, 29 May 2015 03:36:47 +0200 (CEST) Received: from mx12.chaot.net (localhost [127.0.0.1]); by mx12.chaot.net (OpenSMTPD) with ESMTP id 1ae797c3; for ; Fri, 29 May 2015 04:36:46 +0300 (EEST) Message-ID: <5567C2AE.30106@FreeBSD.org> Date: Fri, 29 May 2015 04:36:46 +0300 From: Johannes Jost Meixner User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: freebsd-testing@freebsd.org Subject: Re: Need help reducing compilation warnings in CURRENT References: <55670C5A.6080500@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 01:36:51 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 05/29/2015 03:42, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 5:45 AM, Muhammad Moinur Rahman > wrote: > >> Hi, >> >> Can anyone give me any ideas about how can I contribute some of >> my idle times? Do I need commit bit to submit patches in Jenkins? >> Or should I submit through CODE Review? >> > > > Please read this: https://wiki.freebsd.org/CodeReview for > instructions on how you can send patches to our code review tool. Registration to which has been made public. How about we use the "testing" project for doing the cleanup & review work? This way we can assign things to #testing via arc diff --create [...] and have the benefit of seeing which reviews are created/in progress/merged. https://reviews.freebsd.org/project/view/25/ > > -- Craig _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing To > unsubscribe, send any mail to > "freebsd-testing-unsubscribe@freebsd.org" > - -- Johannes Meixner | FreeBSD Committer xmj@FreeBSD.org | http://people.freebsd.org/~xmj -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZ8KoAAoJEPyeKTcbGw0LJRwIAKWink3N0sJAWp0H49jhl11R OPgCyPuIv1NBXRkFdyLnVW3YRfZyX8iGM/lR+2thJzzxw76Pn+7W0UwfFqc2rIjh 1FIn1G4u83v2EPHFRf/NcCVmA7jaEha7vsEU5paDyCUaWXHQMEmHel+4KBQwZn4z koa6I2H0tdmnUlVHD54Q0IJ6v907oLjBj8JMroWe2xpEI1hDk9BpOrlu8fGvP2cs y6Q5mpWE+V+Rguo8dKRzKlF55QXwiP/JFKcwGfgxBlDD5khUNiyfvP3ODgu1ud8O UHxg2jNZLL37b1JHNDT8U1lZB2bp124o3G8wqbU2N183sIchwZXNyOcazdR/VwM= =kJAs -----END PGP SIGNATURE-----