From owner-freebsd-rc@FreeBSD.ORG Sun Jan 8 10:47:37 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 463F016A41F for ; Sun, 8 Jan 2006 10:47:37 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id C4EA243D46 for ; Sun, 8 Jan 2006 10:47:36 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 50152 invoked by uid 399); 8 Jan 2006 10:47:35 -0000 Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 8 Jan 2006 10:47:35 -0000 Message-ID: <43C0EDC6.4020308@FreeBSD.org> Date: Sun, 08 Jan 2006 02:47:34 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20051226) MIME-Version: 1.0 To: Florent Thoumie References: <1134927080.744.14.camel@cream.xbsd.org> <43B38626.3050106@FreeBSD.org> <200512291331.00183.flz@xbsd.org> <200512300032.43923.flz@xbsd.org> In-Reply-To: <200512300032.43923.flz@xbsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2006 10:47:37 -0000 Florent Thoumie wrote: > On Thursday 29 December 2005 13:30, Florent Thoumie wrote: >> On Thursday 29 December 2005 07:45, Doug Barton wrote: >>> Florent Thoumie wrote: >>>> Hum, I'm actually using paths stored in files located in ld.so.conf.d/ >>>> directories. >>>> >>>> For example, you could have : >>>> >>>> # cat /usr/local/libdata/ld.so.conf.d/compat4x >>>> /usr/local/lib/compat >>> Ok, I think I'll understand this better when I see a complete example >>> implementation. Sorry for being so dense. :) >> No problem, here is the new patch. I'm working on the ports part right >> now. >> >> You'll notice that I've turned my `ls ${i}` into `find ${i} -type f` which >> does the right thing. Also, I've had a look at the scripts your >> compatiblity ports are installing and since there's a special handling on >> amd64, I've added some lines to rc.d/ldconfig. I haven't found a way to do >> what I wanted without duplicating ldconfig_local_dirs and ld.so.conf.d >> directories. Maybe you'll be more creative than I am. > > I think I forgot the most important thing, attaching the patch. You attached the patch, but the list stripped it. I just committed your code with 3 minor modifications. 1. I added the ldconfig directories to BSD.x11.dist as well as BSD.local.dist. 2. I had to change the ldconfig32_local_dirs variable name. The rc.d system requires all variables for a given name to be name_foo. 3. s/32-bits/32-bit/. I also just committed an update to misc/compat[45]x to use this new mechanism. I know that you have plans for developing this in bsd.port.mk, but as we discussed I think it's useful to start exercising this mechanism, and it works great. :) Thanks again for coming up with this very creative solution. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Jan 9 11:02:40 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B20EC16A41F for ; Mon, 9 Jan 2006 11:02:40 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5300243D46 for ; Mon, 9 Jan 2006 11:02:40 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k09B2eZ4066224 for ; Mon, 9 Jan 2006 11:02:40 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k09B2dFQ066216 for freebsd-rc@freebsd.org; Mon, 9 Jan 2006 11:02:39 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 9 Jan 2006 11:02:39 GMT Message-Id: <200601091102.k09B2dFQ066216@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2006 11:02:40 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a 1 problem total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/06/30] conf/68525 rc Loader's verbose boot mode has rc.d/local o [2004/11/11] conf/73834 rc Bad dependencies for /etc/rc.d/savecore o [2004/11/13] conf/73909 rc [patch] rc.d/sshd does not work with port o [2005/02/18] conf/77663 rc Suggestion: add /etc/rc.d/addnetswap afte o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces o [2005/08/27] conf/85363 rc syntax error in /etc/rc.d/devfs o [2005/11/02] conf/88383 rc [PATCH]: etc/rc.d/ldconfig:does not prope o [2005/11/14] conf/88974 rc autoconfigured vlans confuse rc.d/netif o [2005/12/25] conf/90893 rc stock ftpd rcNG script 9 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Jan 11 19:18:23 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A44C916A41F for ; Wed, 11 Jan 2006 19:18:23 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from dbmail-mx2.orcon.net.nz (loadbalancer1.orcon.net.nz [219.88.242.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A0C843D5C for ; Wed, 11 Jan 2006 19:18:16 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz [60.234.149.201]) by dbmail-mx2.orcon.net.nz (8.13.2/8.13.2/Debian-1) with ESMTP id k0BJMxgN017917 for ; Thu, 12 Jan 2006 08:22:59 +1300 Received: by heff.fud.org.nz (Postfix, from userid 1001) id 273722843C; Thu, 12 Jan 2006 08:18:25 +1300 (NZDT) Date: Thu, 12 Jan 2006 08:18:25 +1300 From: Andrew Thompson To: freebsd-rc@freebsd.org Message-ID: <20060111191825.GA2332@heff.fud.org.nz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline User-Agent: Mutt/1.5.11 X-Virus-Scanned: ClamAV version 0.87.1, clamav-milter version 0.87 on dbmail-mx2.orcon.net.nz X-Virus-Status: Clean Subject: review of rc.d/autobridge X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2006 19:18:23 -0000 --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, I have a patch here that adds rc.d/autobridge. This is aimed towards apps like qemu or vmware that open a tap interface and need it bridged with the network adapter, the user can set up a glob for interfaces to be automatically added (eg tap*). Can I get the etc/* and rc.conf.5 changes reviewed for scripting style and general faux pas. regards, Andrew --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=autobridge Index: etc/devd.conf =================================================================== RCS file: /home/ncvs/src/etc/devd.conf,v retrieving revision 1.30 diff -u -p -r1.30 devd.conf --- etc/devd.conf 11 Dec 2005 00:18:28 -0000 1.30 +++ etc/devd.conf 11 Jan 2006 19:02:53 -0000 @@ -55,6 +55,16 @@ notify 0 { }; # +# Notify the autobridge script that a cloned interface has been created, +# physical interfaces are already handled by rc.d/netif. +# +notify 0 { + match "system" "IFNET"; + match "type" "CLONE_CREATE"; + action "/etc/rc.d/autobridge start $subsystem"; +}; + +# # Like Ethernet devices, but separate because # they have a different media type. We may want # to exploit this later. Index: etc/defaults/rc.conf =================================================================== RCS file: /home/ncvs/src/etc/defaults/rc.conf,v retrieving revision 1.269 diff -u -p -r1.269 rc.conf --- etc/defaults/rc.conf 20 Dec 2005 20:36:48 -0000 1.269 +++ etc/defaults/rc.conf 11 Jan 2006 18:45:58 -0000 @@ -163,6 +163,9 @@ ifconfig_lo0="inet 127.0.0.1" # default #ifconfig_fxp0_name="net0" # Change interface name from fxp0 to net0. #ipv4_addrs_fxp0="192.168.0.1/24 192.168.1.1-5/28" # example IPv4 address entry. # +#autobridge_interfaces="bridge0" # List of bridges to check +#autobridge_bridge0="tap* vlan0" # Interface glob to automatically add to the bridge +# # If you have any sppp(4) interfaces above, you might also want to set # the following parameters. Refer to spppcontrol(8) for their meaning. sppp_interfaces="" # List of sppp interfaces. Index: etc/rc.d/autobridge =================================================================== RCS file: etc/rc.d/autobridge diff -N etc/rc.d/autobridge --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ etc/rc.d/autobridge 11 Jan 2006 18:35:32 -0000 @@ -0,0 +1,70 @@ +#!/bin/sh +# +# $FreeBSD$ +# + +# PROVIDE: autobridge +# REQUIRE: netif +# KEYWORD: nojail + +. /etc/rc.subr +. /etc/network.subr + +name="autobridge" +start_cmd="autobridge_start" +stop_cmd="autobridge_stop" +_cmd="" + +glob_int () { + case "$1" in + $2 ) true ;; + * ) false ;; + esac +} + +test_bridge () { + bridge=$1 + iface=$2 + + eval interfaces=\$autobridge_${bridge} + if [ -n "${interfaces}" ]; then + for i in ${interfaces}; do + if glob_int $iface $i ; then + ifconfig $bridge $_cmd $iface + fi + done + fi +} + +autobridge() +{ + if [ -n "${autobridge_interfaces}" ]; then + if [ -z "$_iflist" ]; then + # We're operating as a general network start routine. + _iflist="`list_net_interfaces`" + fi + + for br in ${autobridge_interfaces}; do + for i in $_iflist; do + test_bridge $br $i + done + done + fi +} + +autobridge_start() +{ + _cmd="addm" + autobridge +} + +autobridge_stop() +{ + _cmd="deletem" + autobridge +} + +_iflist=$2 + +load_rc_config $name +run_rc_command "$1" Index: etc/rc.d/netif =================================================================== RCS file: /home/ncvs/src/etc/rc.d/netif,v retrieving revision 1.18 diff -u -p -r1.18 netif --- etc/rc.d/netif 14 Nov 2005 23:34:50 -0000 1.18 +++ etc/rc.d/netif 6 Jan 2006 02:03:23 -0000 @@ -71,6 +71,9 @@ network_start() # Resync ipfilter /etc/rc.d/ipfilter resync fi + if [ -f /etc/rc.d/autobridge -a -n "$_cmdifn" ] ; then + /etc/rc.d/autobridge start $_cmdifn + fi } network_stop() Index: share/man/man5/rc.conf.5 =================================================================== RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v retrieving revision 1.278 diff -u -p -r1.278 rc.conf.5 --- share/man/man5/rc.conf.5 8 Jan 2006 13:20:57 -0000 1.278 +++ share/man/man5/rc.conf.5 11 Jan 2006 18:58:11 -0000 @@ -3395,6 +3395,23 @@ has been mounted. Both the .Xr md 4 device and the mount point will be changed. +.It Va autobridge_interfaces +.Pq Vt str +Set to the list of bridge interfaces that will have newly arriving interfaces +checked against to be automatically added. +If not set to +.Dq Li NO +then for each whitespace separated +.Ar element +in the value, a +.Va autobridge_ Ns Aq Ar element +variable is assumed to exist which has a whitespace separated list of interface +names to match, these names can use wildcards. +For example: +.Bd -literal +autobridge_interfaces="bridge0" +autobridge_bridge0="tap* dc0 dc[345]" +.Ed .El .Sh FILES .Bl -tag -width ".Pa /etc/defaults/rc.conf" -compact @@ -3411,6 +3428,7 @@ device and the mount point will be chang .Xr makewhatis 1 , .Xr vi 1 , .Xr vidcontrol 1 , +.Xr bridge 4 , .Xr ip 4 , .Xr ipf 4 , .Xr ipfw 4 , Index: sys/net/if_clone.c =================================================================== RCS file: /home/ncvs/src/sys/net/if_clone.c,v retrieving revision 1.9 diff -u -p -r1.9 if_clone.c --- sys/net/if_clone.c 24 Nov 2005 18:56:14 -0000 1.9 +++ sys/net/if_clone.c 11 Jan 2006 18:38:37 -0000 @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -161,6 +162,8 @@ if_clone_createif(struct if_clone *ifc, IF_CLONE_LOCK(ifc); IFC_IFLIST_INSERT(ifc, ifp); IF_CLONE_UNLOCK(ifc); + + devctl_notify("IFNET", ifp->if_xname, "CLONE_CREATE", NULL); } return (err); @@ -216,6 +219,8 @@ if_clone_destroyif(struct if_clone *ifc, IF_CLONE_LOCK(ifc); IFC_IFLIST_INSERT(ifc, ifp); IF_CLONE_UNLOCK(ifc); + + devctl_notify("IFNET", ifp->if_xname, "CLONE_DESTROY", NULL); } done: Index: sys/net/if_tap.c =================================================================== RCS file: /home/ncvs/src/sys/net/if_tap.c,v retrieving revision 1.58 diff -u -p -r1.58 if_tap.c --- sys/net/if_tap.c 11 Nov 2005 16:04:48 -0000 1.58 +++ sys/net/if_tap.c 11 Jan 2006 18:40:40 -0000 @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include @@ -398,6 +399,7 @@ tapopen(dev, flag, mode, td) splx(s); TAPDEBUG("%s is open. minor = %#x\n", ifp->if_xname, minor(dev)); + devctl_notify("IFNET", ifp->if_xname, "CLONE_CREATE", NULL); return (0); } /* tapopen */ @@ -454,6 +456,7 @@ tapclose(dev, foo, bar, td) TAPDEBUG("%s is closed. minor = %#x\n", ifp->if_xname, minor(dev)); + devctl_notify("IFNET", ifp->if_xname, "CLONE_DESTROY", NULL); return (0); } /* tapclose */ Index: sys/net/if_tun.c =================================================================== RCS file: /home/ncvs/src/sys/net/if_tun.c,v retrieving revision 1.154 diff -u -p -r1.154 if_tun.c --- sys/net/if_tun.c 9 Aug 2005 10:19:58 -0000 1.154 +++ sys/net/if_tun.c 11 Jan 2006 18:41:30 -0000 @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -324,6 +325,7 @@ tunopen(struct cdev *dev, int flag, int mtx_unlock(&tp->tun_mtx); ifp = TUN2IFP(tp); TUNDEBUG(ifp, "open\n"); + devctl_notify("IFNET", ifp->if_xname, "CLONE_CREATE", NULL); return (0); } @@ -377,6 +379,7 @@ tunclose(struct cdev *dev, int foo, int funsetown(&tp->tun_sigio); selwakeuppri(&tp->tun_rsel, PZERO + 1); TUNDEBUG (ifp, "closed\n"); + devctl_notify("IFNET", ifp->if_xname, "CLONE_DESTROY", NULL); return (0); } --cWoXeonUoKmBZSoM-- From owner-freebsd-rc@FreeBSD.ORG Wed Jan 11 19:29:41 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D88B716A41F; Wed, 11 Jan 2006 19:29:41 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5204643D46; Wed, 11 Jan 2006 19:29:41 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 42DB411A59; Wed, 11 Jan 2006 20:29:33 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 55039-07; Wed, 11 Jan 2006 20:29:27 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 26D99118C6; Wed, 11 Jan 2006 20:29:27 +0100 (CET) From: Florent Thoumie To: freebsd-rc@freebsd.org Date: Wed, 11 Jan 2006 20:29:09 +0100 User-Agent: KMail/1.8.2 References: <20060111191825.GA2332@heff.fud.org.nz> In-Reply-To: <20060111191825.GA2332@heff.fud.org.nz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1231711.28IVlKgCTq"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200601112029.21661.flz@xbsd.org> X-Virus-Scanned: amavisd-new at xbsd.org Cc: Andrew Thompson Subject: Re: review of rc.d/autobridge X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2006 19:29:42 -0000 --nextPart1231711.28IVlKgCTq Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 11 January 2006 20:18, Andrew Thompson wrote: > Hi, > > > I have a patch here that adds rc.d/autobridge. This is aimed towards > apps like qemu or vmware that open a tap interface and need it bridged > with the network adapter, the user can set up a glob for interfaces to > be automatically added (eg tap*). > > Can I get the etc/* and rc.conf.5 changes reviewed for scripting style > and general faux pas. Haven't read carefully enough to comment, but why autobridge instead of bridge ? =2D-=20 =46lorent Thoumie flz@FreeBSD.org =46reeBSD Committer --nextPart1231711.28IVlKgCTq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDxVyRMxEkbVFH3PQRAptTAJ0fdKRxyNFif6kXQ9lhbKu/wTiOIACdGRQ5 rjF82ziGJO6N39ld5K44KPg= =odgX -----END PGP SIGNATURE----- --nextPart1231711.28IVlKgCTq-- From owner-freebsd-rc@FreeBSD.ORG Wed Jan 11 19:32:32 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D63616A41F for ; Wed, 11 Jan 2006 19:32:32 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from dbmail-mx3.orcon.co.nz (loadbalancer1.orcon.net.nz [219.88.242.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3D9243D45 for ; Wed, 11 Jan 2006 19:32:31 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz [60.234.149.201]) by dbmail-mx3.orcon.co.nz (8.13.2/8.13.2/Debian-1) with ESMTP id k0BJYMcX017000; Thu, 12 Jan 2006 08:34:22 +1300 Received: by heff.fud.org.nz (Postfix, from userid 1001) id A00D72843B; Thu, 12 Jan 2006 08:32:40 +1300 (NZDT) Date: Thu, 12 Jan 2006 08:32:40 +1300 From: Andrew Thompson To: Florent Thoumie Message-ID: <20060111193240.GB2332@heff.fud.org.nz> References: <20060111191825.GA2332@heff.fud.org.nz> <200601112029.21661.flz@xbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601112029.21661.flz@xbsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: ClamAV 0.87.1/1238/Wed Jan 11 23:19:06 2006 on dbmail-mx3.orcon.co.nz X-Virus-Status: Clean Cc: freebsd-rc@freebsd.org Subject: Re: review of rc.d/autobridge X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2006 19:32:32 -0000 On Wed, Jan 11, 2006 at 08:29:09PM +0100, Florent Thoumie wrote: > On Wednesday 11 January 2006 20:18, Andrew Thompson wrote: > > Hi, > > > > > > I have a patch here that adds rc.d/autobridge. This is aimed towards > > apps like qemu or vmware that open a tap interface and need it bridged > > with the network adapter, the user can set up a glob for interfaces to > > be automatically added (eg tap*). > > > > Can I get the etc/* and rc.conf.5 changes reviewed for scripting style > > and general faux pas. > > Haven't read carefully enough to comment, but why autobridge > instead of bridge ? > It seemed to describe the functionality, but its just a name and bridge would be fine by me. Andrew From owner-freebsd-rc@FreeBSD.ORG Sat Jan 14 22:44:02 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7C0416A41F for ; Sat, 14 Jan 2006 22:44:02 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.12]) by mx1.FreeBSD.org (Postfix) with SMTP id 2614F43D45 for ; Sat, 14 Jan 2006 22:44:01 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 63389 invoked by uid 399); 14 Jan 2006 22:44:01 -0000 Received: from localhost (HELO ?192.168.1.101?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 14 Jan 2006 22:44:01 -0000 Message-ID: <43C97EB0.4090306@FreeBSD.org> Date: Sat, 14 Jan 2006 14:44:00 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5 (X11/20060112) MIME-Version: 1.0 To: freebsd-rc@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Should ntpdate REQUIRE named? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2006 22:44:02 -0000 Question came up on -stable yesterday about a user who has ntp servers by hostname in ntp.conf, and because of an unrelated ordering problem ntp[date] started before named, so they failed. On all the systems I've examined, named starts right after SERVERS, and ntpdate right after that. While there are theoretically good reasons why one might want it the other way around, I think for the vast majority of our users named should start first. Any comments, objections? Doug -- This .signature sanitized for your protection