From owner-svn-src-head@FreeBSD.ORG Sun Sep 12 00:03:39 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6349D1065673; Sun, 12 Sep 2010 00:03:39 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 006D58FC14; Sun, 12 Sep 2010 00:03:38 +0000 (UTC) Received: by iwn34 with SMTP id 34so4220222iwn.13 for ; Sat, 11 Sep 2010 17:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=52d1vFD9fzD/SQZwI1jKka+ezOwVmF3lD+RIJcOcXio=; b=IwPi1wk+Ow4Mwtdr9Rf2fYIO+HwLGATMZDwNbK/2DQB46L+5ERNuwYL7z2wuhweMFh v9WTdEVEr5sStA+K81XBZxRwfUC59k+QtnjhJak7L1nU4YeUVqM1RPc1qC2Kizhb+6pC wMXRIb6KUHiuzxDLmlKIkp7CHQqeBIUAsv8VU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=a5TnQaWflSl0IpVpvbuIze8jQQzkiWyPk5h/MeUwH08ve3idj8DFPWg9EPMUXYJu+k 0N1foN/umKrsb4zYnjYOq091I5p41KPnS0l9mEyYfFzI6ADArDza+Sgz/8iEHWYrPjR3 S8gkzzRxBhfe23hb/7U+f4NlW/TEK3q1OcAgU= MIME-Version: 1.0 Received: by 10.231.58.201 with SMTP id i9mr3502674ibh.98.1284249818139; Sat, 11 Sep 2010 17:03:38 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.231.130.34 with HTTP; Sat, 11 Sep 2010 17:03:38 -0700 (PDT) In-Reply-To: <201009111942.o8BJgocS032974@svn.freebsd.org> References: <201009111942.o8BJgocS032974@svn.freebsd.org> Date: Sun, 12 Sep 2010 00:03:38 +0000 X-Google-Sender-Auth: POnPdDsVBz7nimoS8vLO1etMwwY Message-ID: From: mdf@FreeBSD.org To: Alexander Kabaev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212478 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 00:03:39 -0000 On Sat, Sep 11, 2010 at 7:42 PM, Alexander Kabaev wrote: > Author: kan > Date: Sat Sep 11 19:42:50 2010 > New Revision: 212478 > URL: http://svn.freebsd.org/changeset/base/212478 > > Log: > =A0Add missing pointer increment to sbuf_cat. > > Modified: > =A0head/sys/kern/subr_sbuf.c > > Modified: head/sys/kern/subr_sbuf.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_sbuf.c =A0 Sat Sep 11 18:55:00 2010 =A0 =A0 =A0 = =A0(r212477) > +++ head/sys/kern/subr_sbuf.c =A0 Sat Sep 11 19:42:50 2010 =A0 =A0 =A0 = =A0(r212478) > @@ -441,7 +441,7 @@ sbuf_cat(struct sbuf *s, const char *str > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (-1); > > =A0 =A0 =A0 =A0while (*str !=3D '\0') { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 sbuf_put_byte(*str, s); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 sbuf_put_byte(*str++, s); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (s->s_error !=3D 0) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (-1); > =A0 =A0 =A0 =A0} D'oh! Yeah, this looks right. I guess the sbuf functions that ran when I tested didn't use sbuf_cat. Sorry, matthew