From owner-freebsd-rc@FreeBSD.ORG Mon Nov 14 11:07:15 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12A7E106564A for ; Mon, 14 Nov 2011 11:07:15 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 00B3B8FC16 for ; Mon, 14 Nov 2011 11:07:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAEB7E3Y083617 for ; Mon, 14 Nov 2011 11:07:14 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAEB7E90083615 for freebsd-rc@FreeBSD.org; Mon, 14 Nov 2011 11:07:14 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 14 Nov 2011 11:07:14 GMT Message-Id: <201111141107.pAEB7E90083615@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2011 11:07:15 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/109272 rc [request] increase default rc shutdown timeout o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 90 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Nov 16 16:53:02 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D580106564A for ; Wed, 16 Nov 2011 16:53:02 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 854DF8FC13 for ; Wed, 16 Nov 2011 16:53:01 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA26189 for ; Wed, 16 Nov 2011 18:35:52 +0200 (EET) (envelope-from avg@FreeBSD.org) Message-ID: <4EC3E667.4080906@FreeBSD.org> Date: Wed, 16 Nov 2011 18:35:51 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0.1) Gecko/20111003 Thunderbird/7.0.1 MIME-Version: 1.0 To: freebsd-rc@FreeBSD.org X-Enigmail-Version: undefined Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Subject: KEYWORD: shutdown X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2011 16:53:02 -0000 I am new to all the rc stuff, so please pardon me if I am asking something obvious or silly. What are the main reasons to _not_ have the "shutdown" keyword in an rc script? What are the examples / usages? Thank you! -- Andriy Gapon From owner-freebsd-rc@FreeBSD.ORG Wed Nov 16 17:38:58 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA0F61065670; Wed, 16 Nov 2011 17:38:58 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) by mx1.freebsd.org (Postfix) with ESMTP id 6B7E68FC16; Wed, 16 Nov 2011 17:38:58 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 9063F1DD638; Wed, 16 Nov 2011 18:38:56 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id 6CEBA28468; Wed, 16 Nov 2011 18:38:56 +0100 (CET) Date: Wed, 16 Nov 2011 18:38:56 +0100 From: Jilles Tjoelker To: Andriy Gapon Message-ID: <20111116173856.GA31200@stack.nl> References: <4EC3E667.4080906@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EC3E667.4080906@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@FreeBSD.org Subject: Re: KEYWORD: shutdown X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2011 17:38:58 -0000 On Wed, Nov 16, 2011 at 06:35:51PM +0200, Andriy Gapon wrote: > I am new to all the rc stuff, so please pardon me if I am asking > something obvious or silly. What are the main reasons to _not_ have > the "shutdown" keyword in an rc script? What are the examples / > usages? Traditionally only very few scripts had "shutdown", leaving most of the cleanup to the SIGTERM and SIGKILL from init. Because it was fairly complicated to get this right (for example, a database server needs "shutdown" but also all programs that use it), a few years ago it was decided to add "shutdown" everywhere. The slower shutdown (a few seconds at most on machines with decent CPUs, but possibly rather more on slow embedded machines) was accepted. -- Jilles Tjoelker From owner-freebsd-rc@FreeBSD.ORG Wed Nov 16 17:54:56 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97B9A1065673 for ; Wed, 16 Nov 2011 17:54:56 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E728E8FC0C for ; Wed, 16 Nov 2011 17:54:55 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA27423; Wed, 16 Nov 2011 19:54:53 +0200 (EET) (envelope-from avg@FreeBSD.org) Message-ID: <4EC3F8EC.2010005@FreeBSD.org> Date: Wed, 16 Nov 2011 19:54:52 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0.1) Gecko/20111003 Thunderbird/7.0.1 MIME-Version: 1.0 To: Jilles Tjoelker References: <4EC3E667.4080906@FreeBSD.org> <20111116173856.GA31200@stack.nl> In-Reply-To: <20111116173856.GA31200@stack.nl> X-Enigmail-Version: undefined Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: KEYWORD: shutdown X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2011 17:54:56 -0000 on 16/11/2011 19:38 Jilles Tjoelker said the following: > On Wed, Nov 16, 2011 at 06:35:51PM +0200, Andriy Gapon wrote: >> I am new to all the rc stuff, so please pardon me if I am asking >> something obvious or silly. What are the main reasons to _not_ have >> the "shutdown" keyword in an rc script? What are the examples / >> usages? > > Traditionally only very few scripts had "shutdown", leaving most of the > cleanup to the SIGTERM and SIGKILL from init. > > Because it was fairly complicated to get this right (for example, a > database server needs "shutdown" but also all programs that use it), a > few years ago it was decided to add "shutdown" everywhere. The slower > shutdown (a few seconds at most on machines with decent CPUs, but > possibly rather more on slow embedded machines) was accepted. > So nowadays (or "if I got to do it again") it would make more sense to have "shutdown" as a default and add "noshutdown" for some hypothetical special cases? -- Andriy Gapon From owner-freebsd-rc@FreeBSD.ORG Thu Nov 17 07:55:01 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 4A589106566B; Thu, 17 Nov 2011 07:55:01 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 14BB514DC02; Thu, 17 Nov 2011 07:55:01 +0000 (UTC) Message-ID: <4EC4BDD4.7010705@FreeBSD.org> Date: Wed, 16 Nov 2011 23:55:00 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Andriy Gapon References: <4EC3E667.4080906@FreeBSD.org> <20111116173856.GA31200@stack.nl> <4EC3F8EC.2010005@FreeBSD.org> In-Reply-To: <4EC3F8EC.2010005@FreeBSD.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org Subject: Re: KEYWORD: shutdown X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 07:55:01 -0000 On 11/16/2011 09:54, Andriy Gapon wrote: > on 16/11/2011 19:38 Jilles Tjoelker said the following: >> On Wed, Nov 16, 2011 at 06:35:51PM +0200, Andriy Gapon wrote: >>> I am new to all the rc stuff, so please pardon me if I am asking >>> something obvious or silly. What are the main reasons to _not_ have >>> the "shutdown" keyword in an rc script? What are the examples / >>> usages? >> >> Traditionally only very few scripts had "shutdown", leaving most of the >> cleanup to the SIGTERM and SIGKILL from init. >> >> Because it was fairly complicated to get this right (for example, a >> database server needs "shutdown" but also all programs that use it), a >> few years ago it was decided to add "shutdown" everywhere. The slower >> shutdown (a few seconds at most on machines with decent CPUs, but >> possibly rather more on slow embedded machines) was accepted. >> > > So nowadays (or "if I got to do it again") it would make more sense to have > "shutdown" as a default and add "noshutdown" for some hypothetical special cases? Not necessarily. For example, out of 151 scripts in /etc/rc.d only 52 of them use it (and I am pretty confident I added it to all scripts that start persistent services which didn't already have it). IOW, rc.d is used to do a lot of things at boot time in addition to starting daemons. In fairness most of the 800'ish rc.d scripts in ports do start a daemon, so your idea isn't totally off base, I'm just saying that what the default should be isn't as clear cut as you may think. Doug -- "We could put the whole Internet into a book." "Too practical." Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Thu Nov 17 18:57:40 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C01D1065674; Thu, 17 Nov 2011 18:57:40 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 63E208FC15; Thu, 17 Nov 2011 18:57:40 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAHIveOc044363; Thu, 17 Nov 2011 18:57:40 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAHIve57044359; Thu, 17 Nov 2011 18:57:40 GMT (envelope-from linimon) Date: Thu, 17 Nov 2011 18:57:40 GMT Message-Id: <201111171857.pAHIve57044359@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/162642: .sh scripts in /usr/local/etc/rc.d get executed, not sourced X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 18:57:40 -0000 Old Synopsis: .sh scripts in /usr/loca/etc/rc.d get executed, not sourced New Synopsis: .sh scripts in /usr/local/etc/rc.d get executed, not sourced Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Thu Nov 17 18:57:29 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=162642 From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 11:54:26 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB201106566C for ; Fri, 18 Nov 2011 11:54:26 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 698548FC0C for ; Fri, 18 Nov 2011 11:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=LWNll8cevbna5LI5BbZ72Qa4sskwsznQ3pwNuO9ZlLg=; b=ZbbZZGaDtCrixH75g8hLkskaGg2/iL3YqGn+vNwICSk6X75ZFdrdkGWmvMotFjFugd+D1laak7Y8nj8EiEw2i1+5IwgQ/fEoFz1jWrFUX2VZb23U6bj46Pv0AxcKg/aO/tp5iuuQpuk6gC70q76cFDXAiYmGyRX1mw3/+4nykwp9WGslA32W/NFmXu9zD9GTfaxrMFjCDtsEwuaZJrQp/YXSzq70t3x1g1nJusXFBcP3O3gED8ixdxmxZ5rq5T3MmpuaOw3PtevetL/dbJ8fyhHRiTzApHbRUNg5M2RbB+g9XlWz21yPNkl3WFVgJUy9JKqaI5ZdP9yn2wNIgdpacA==; Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RRMnq-000OaY-Jz; Fri, 18 Nov 2011 14:40:19 +0300 Date: Fri, 18 Nov 2011 15:40:16 +0400 From: Eygene Ryabinkin To: d@delphij.net Message-ID: References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline In-Reply-To: <4EB72290.8030104@delphij.net> Sender: rea@codelabs.ru Cc: Doug Barton , freebsd-rc@FreeBSD.ORG Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 11:54:26 -0000 --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Gentlemen, good day. Sun, Nov 06, 2011 at 04:13:04PM -0800, Xin LI wrote: > On 11/06/11 15:17, Doug Barton wrote: > > What harm is the error message causing? It seems useful to me to=20 > > know if something is happening in the background that may need the=20 > > administrator's attention. >=20 > It's harmful because it's not an error -- for example, a bge0 > interface which is a member of lagg group, is usually marked > explicitly as non-DHCP. On the other hand, can you give me an example > where it *is* an error? :-) I can't seem to think about one but I > could be wrong here. >=20 > It sounds like to me a POLA violation by the way since it's not the > way it was, but my argument is primarily about "this gives an error > message for valid configuration" and not about POLA. Since devd.conf uses quietstart, there is a way to make everyone happy or at least not so angry: check rc_quiet and act accordingly. The patch is available at http://codelabs.ru/fbsd/patches/dhclient/dhclient-respect-quiet-mode.diff please, test it and report back. Thanks! --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk7GRB8ACgkQFq+eroFS7PsdwQD+KGGO5BQKAPN4ExhB6/tR903l 6fXc3u3X8CQ3OhAw0FkBAIVAtibXPtean53jkPyCXCRbQl9CkEEnA0Ij0IP+uYam =Bdtr -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM-- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 17:43:27 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 563CF1065670; Fri, 18 Nov 2011 17:43:27 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2E1FF8FC0A; Fri, 18 Nov 2011 17:43:27 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAIHhRSj003456; Fri, 18 Nov 2011 17:43:27 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAIHhRp6003452; Fri, 18 Nov 2011 17:43:27 GMT (envelope-from linimon) Date: Fri, 18 Nov 2011 17:43:27 GMT Message-Id: <201111181743.pAIHhRp6003452@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/162652: /etc/rc.d/named should always pass $named_conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 17:43:27 -0000 Synopsis: /etc/rc.d/named should always pass $named_conf Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Fri Nov 18 17:42:52 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=162652 From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 18:53:08 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 826E1106566C; Fri, 18 Nov 2011 18:53:08 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 1951F17A4D2; Fri, 18 Nov 2011 18:53:08 +0000 (UTC) Message-ID: <4EC6A993.1060603@FreeBSD.org> Date: Fri, 18 Nov 2011 10:53:07 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.ORG, d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 18:53:08 -0000 On 11/18/2011 03:40, Eygene Ryabinkin wrote: > Since devd.conf uses quietstart, there is a way to make everyone happy > or at least not so angry: check rc_quiet and act accordingly. rc_quiet is not intended to mask warnings. -- "We could put the whole Internet into a book." "Too practical." Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 19:14:15 2011 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D0B5106564A; Fri, 18 Nov 2011 19:14:15 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 54E038FC16; Fri, 18 Nov 2011 19:14:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAIJEFuo086416; Fri, 18 Nov 2011 19:14:15 GMT (envelope-from dougb@freefall.freebsd.org) Received: (from dougb@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAIJEFp7086412; Fri, 18 Nov 2011 19:14:15 GMT (envelope-from dougb) Date: Fri, 18 Nov 2011 19:14:15 GMT Message-Id: <201111181914.pAIJEFp7086412@freefall.freebsd.org> To: rs@bytecamp.net, dougb@FreeBSD.org, freebsd-rc@FreeBSD.org, dougb@FreeBSD.org From: dougb@FreeBSD.org Cc: Subject: Re: conf/162652: /etc/rc.d/named should always pass $named_conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 19:14:15 -0000 Synopsis: /etc/rc.d/named should always pass $named_conf State-Changed-From-To: open->closed State-Changed-By: dougb State-Changed-When: Fri Nov 18 19:13:31 UTC 2011 State-Changed-Why: It's not necessary from the ports either. Just let the port create the proper symlinks and everything works just fine. Responsible-Changed-From-To: freebsd-rc->dougb Responsible-Changed-By: dougb Responsible-Changed-When: Fri Nov 18 19:13:31 UTC 2011 Responsible-Changed-Why: My area. http://www.freebsd.org/cgi/query-pr.cgi?pr=162652 From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:30:03 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F020A106566C; Fri, 18 Nov 2011 20:30:02 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 8E2F38FC0C; Fri, 18 Nov 2011 20:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=FWvAJr/aK+F+rQ6nC2Op+3WlI3OBDFMNJVfKFZ/Khtc=; b=N+Y69vc+4fVIBH5yIA/o0cwRGxTRXaVoSkWN0Amy0GG4kwVAhWcVTw9irKE1QfLO5zFFG/zfSXJWRV+Rb5w5+pa68zbN/fFSouRghze+6AvXnLm7kbGQq9Oscv0a8BD9/Rm10RY3GTJSSREBWlPVPK05EraFiXmKW1HJQhpxcoPxl1G146HgtR1pUrj/7jl5jmvPIdX/flkeIjHCTkoG2qCnhGgQusESPSOvZZnrEQ/YIfCH4yg2J/OuSfTeRJqJNjxB91f0YVqW+C9b5aE7idiIvtzqOf3XozPqMCuO4+/rehW4vkf4HN5bSRBIRLj9eKuu8rlJTgZvpfcz7QKqxA==; Received: from shadow.codelabs.ru (ppp91-77-172-150.pppoe.mtu-net.ru [91.77.172.150]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RRV4T-000Gr0-H9; Fri, 18 Nov 2011 23:30:01 +0300 Date: Sat, 19 Nov 2011 00:29:59 +0400 From: Eygene Ryabinkin To: Doug Barton Message-ID: <1qUtKyEId99vnufXv9FxIefCDnM@RzV33t0qf/tQbqPDH2EX0VmGCGw> References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6A993.1060603@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <4EC6A993.1060603@FreeBSD.org> Sender: rea@codelabs.ru Cc: freebsd-rc@FreeBSD.ORG, d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:30:03 -0000 --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Doug, good day. Fri, Nov 18, 2011 at 10:53:07AM -0800, Doug Barton wrote: > rc_quiet is not intended to mask warnings. According to rc.subr(8), rc_quiet is nonexistent ;)) And rc.subr reads {{{ # quiet Don't output some diagnostics, and set rc_quiet=3Dy= es }}} and in this case the error is the diagnostics, at least in my understanding. But if you will be able to explain the semantics of quiet, may be I will better understand the intentions of its introduction. Thanks. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --liOOAslEiF7prFVr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk7GwEYACgkQFq+eroFS7PtGDgD/YAQ7trwXwFFHn8vmJ1mG9c3e G0xXfuMIhWsWnfyrNZsA/iwERAcHxvsSSPsitwFrT1fNRwjMea7wirneQwYbr+UW =L8No -----END PGP SIGNATURE----- --liOOAslEiF7prFVr-- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:38:32 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9697A1065670; Fri, 18 Nov 2011 20:38:32 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 791528FC0C; Fri, 18 Nov 2011 20:38:32 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 3EC5A61A3; Fri, 18 Nov 2011 12:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321648712; bh=uWlobWMgsHs8SrdEwcaKR98+NHXEv8P5r7foaagQRrU=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Gs7+e6ddp1IA1Qam4qUPXQQo+pOx1drlRgpnrm7IoZ67jd+wF/jVdKhY0FkM45/a7 KdaTjQrNNjHr4qQ1Z5BEhHDYCw5VSINRwCzomIkWORYBM5hSlJHGWt+Mcx2jpU/+Qe n3djG2lr85jcu+c8211gzYwkpmmxV/Kjp2Zrbh4g= Message-ID: <4EC6C247.6040807@delphij.net> Date: Fri, 18 Nov 2011 12:38:31 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> In-Reply-To: OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.ORG, Doug Barton , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:38:32 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 03:40, Eygene Ryabinkin wrote: > Gentlemen, good day. > > Sun, Nov 06, 2011 at 04:13:04PM -0800, Xin LI wrote: >> On 11/06/11 15:17, Doug Barton wrote: >>> What harm is the error message causing? It seems useful to me >>> to know if something is happening in the background that may >>> need the administrator's attention. >> >> It's harmful because it's not an error -- for example, a bge0 >> interface which is a member of lagg group, is usually marked >> explicitly as non-DHCP. On the other hand, can you give me an >> example where it *is* an error? :-) I can't seem to think about >> one but I could be wrong here. >> >> It sounds like to me a POLA violation by the way since it's not >> the way it was, but my argument is primarily about "this gives an >> error message for valid configuration" and not about POLA. > > Since devd.conf uses quietstart, there is a way to make everyone > happy or at least not so angry: check rc_quiet and act accordingly. > The patch is available at > http://codelabs.ru/fbsd/patches/dhclient/dhclient-respect-quiet-mode.diff > > please, test it and report back. Is there any counter reasoning about "having an interface marked as non-DHCP is not an error"? I'm still not convinced with the benefit of having it show an error message. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxsJHAAoJEATO+BI/yjfB1DEIAK5R2xgC/4JIML1eWG6wTt3g 2dHp/e2hVZIqSrmVqrd3Dhm6yYsjn/ycTLCwulpdyhviZfZJneTuXHIKEo4fF8Bt o+NoqAYZiAt/9cUJXFO1x/FMm7h1scth4H5AsLqvz52XJkmxeGBGq1tCEv4oeT2/ CYWzsOwd3OjEaBBNtRX7PyP8i+G+Sd3gPK1SQpbYbrqBtYHPa3bTVbn6olbrA21E sQ0qRIakD5I/GhuEhnfAnLNAR7fYUW3/b6KVBBFsGa4aE5kF8fDW1OlIhRY3hm47 hx8lwBwOyAPL3cJ+xidGX9klzYcZsXdH84fgsn5bwXI9ZbIfEj3+VaOp+aZXjVA= =XGEv -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:45:55 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E183106566C; Fri, 18 Nov 2011 20:45:55 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 0C9B68FC16; Fri, 18 Nov 2011 20:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=R4lXr+Ai6QoVMg8VzEba477Kg3NoeaLGvSptmoTTkcQ=; b=HXLQBeeVsnq7IVEUqDuBEduQIoq6DwP75u3qc258RWWo9kLg4eGIJKPsAsXasYQ4vr0CTzUUN1Bz0XCvCqetBJGm4FJzUHGAezQmYiCAkqh2JmikZrzwTGYwwN/hZ6kRoLakVVjRPasg4zu7tecz6o19M9ezQlvgHLYTIcxynaRUIHgg+HJOTzVmpxWE0EeQSzTb9cfStm1gYxz7DqDFuDbUyuXU2a4JOgK2Z1m7bjDz7S5+kwDl+jy15mugtWyXU3G7m3OLheBxgRvJmFbf9mEXHD48tixYug4SYdKzIWen9Zc5osHTHpe8YgaeeF3o5FdzXqiyHySp9ERr0RtuMw==; Received: from shadow.codelabs.ru (ppp91-77-172-150.pppoe.mtu-net.ru [91.77.172.150]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RRVJp-000IIR-UZ; Fri, 18 Nov 2011 23:45:54 +0300 Date: Sat, 19 Nov 2011 00:45:52 +0400 From: Eygene Ryabinkin To: d@delphij.net Message-ID: References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline In-Reply-To: <4EC6C247.6040807@delphij.net> Sender: rea@codelabs.ru Cc: Doug Barton , freebsd-rc@FreeBSD.ORG Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:45:55 -0000 --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Xin, good day. Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: > Is there any counter reasoning about "having an interface marked as > non-DHCP is not an error"? I'm still not convinced with the benefit > of having it show an error message. Well, when I invoke 'service dhclient start em0' and em0 isn't DHCP-enabled, I want to see some diagnostics on why I was not able to get DHCP on that interface. Return code isn't that visible (I can, of course, always run it as 'service dhclient start em0 || echo failed'), but I am not up to typing more than needed and I should see the real reason for absence of DHCP-assigned address in that case, be it the non-DHCP-enabled interface or some other problem. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk7GxAAACgkQFq+eroFS7PuR8gEAi8B0qQYGbiv0OqmDILlfGYjm XZ1AwfyCEpi/Eu0beLUA/2QmrNjXT2UgZEY+l6NEHI2LwJfjuUV2YIWpCqIawgWm =Y0mk -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE-- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:50:29 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 733E2106564A; Fri, 18 Nov 2011 20:50:29 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 64E4914E54D; Fri, 18 Nov 2011 20:50:23 +0000 (UTC) Message-ID: <4EC6C50F.30405@FreeBSD.org> Date: Fri, 18 Nov 2011 12:50:23 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> In-Reply-To: X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.ORG, d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:50:29 -0000 On 11/18/2011 12:45, Eygene Ryabinkin wrote: > Xin, good day. > > Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >> Is there any counter reasoning about "having an interface marked as >> non-DHCP is not an error"? I'm still not convinced with the benefit >> of having it show an error message. > > Well, when I invoke 'service dhclient start em0' and em0 isn't > DHCP-enabled, I want to see some diagnostics on why I was not able to > get DHCP on that interface. Return code isn't that visible (I can, of > course, always run it as 'service dhclient start em0 || echo failed'), > but I am not up to typing more than needed and I should see the real > reason for absence of DHCP-assigned address in that case, be it the > non-DHCP-enabled interface or some other problem. Right, that's my argument as well. If there is a particular code path that leads to attempting dhclient on a non-dhcp interface I'd rather see that code path fixed than to suppress the warning. Doug -- "We could put the whole Internet into a book." "Too practical." Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:50:40 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B458A10656F9; Fri, 18 Nov 2011 20:50:40 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id 60B0F8FC19; Fri, 18 Nov 2011 20:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=v50sT6Kmjfnlsx83+WbpIFtcKhrPXobDCUysS85aqkc=; b=crhnt8x/jC0bNC8Jw+pCTs4wODn2uEYzHfFOLnNiGAif4YISIAYEizp2/Z0p8Bxb/T9ZviLKUm7TJyW7b/ArRJBWKdKOyFI21SQR5iwGxYkfPHfmZz7KI3GNSIhFdCtjl3gqEfENxJ4TZvC/0F/AnFRSAKMOfdnplR7eKRQN7Y+msfDe0/7klfIyVqnEtnrAdLBsxfFKLTW1pYZzP0VYhswF6zNT6HMufTLyvWkfnhu9H+OS9w32TphW0W6IQpOFQYixnSltu51dObwfkBCmuyApe4uxzqy+lbhGqrlnea3wbR/uUW47owUgiGoHSU65pBi+ypeM7khtQSP6wS1RIQ==; Received: from shadow.codelabs.ru (ppp91-77-172-150.pppoe.mtu-net.ru [91.77.172.150]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RRVOQ-000IlG-Vq; Fri, 18 Nov 2011 23:50:39 +0300 Date: Sat, 19 Nov 2011 00:50:37 +0400 From: Eygene Ryabinkin To: Garrett Cooper Message-ID: References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: Sender: rea@codelabs.ru Cc: freebsd-rc@freebsd.org, Doug Barton , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:50:40 -0000 --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Garrett, good day. Fri, Nov 18, 2011 at 12:42:27PM -0800, Garrett Cooper wrote: > On Fri, Nov 18, 2011 at 12:38 PM, Xin LI wrote: > > Is there any counter reasoning about "having an interface marked as > > non-DHCP is not an error"? =9AI'm still not convinced with the benefit > > of having it show an error message. >=20 > +1. I consider this to be debug noise. Well, what about the silent output from 'cc -o test test.c' when you have no file test.c or the compiler is absent? It is the same thing (as I see it) and in this case will you expect that the binary 'test' will be compiled and ready for use or not? I will, but this can be my personal delusion. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk7GxRwACgkQFq+eroFS7Pv6/AEAlfTZZhE7Xvf2TVxaQ7kCI3fb mxkTeb+E+2Zfo52VPrMA/inufCmZO7tQCTiTINl2k4AV7qEtyZ7l5KfSndg8zGIJ =YnxY -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA-- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:59:06 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB79D106564A; Fri, 18 Nov 2011 20:59:06 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 8C1558FC17; Fri, 18 Nov 2011 20:59:06 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id BECC0631A; Fri, 18 Nov 2011 12:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321649946; bh=xIyobHUAf9UD4dPDQ8/uGbQ+p5ZgP2Z+92viP1Gkitg=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=L/DMbqdWOV8LJ9Ixiz5ZIP1eqMzsttRuNqIl8iJfiS+O6l9o03p5keHhlI+/SaF1P SYCXcGqW5FtvhDP+WHYoL0/F5q6zDgDgx98thQMd2T8nKmcDjnOgfSH0V74Hy1/2dF n/xiVE0rbbzrLkDlmkHytj6YMNxImC14GO3us0Qw= Message-ID: <4EC6C718.40607@delphij.net> Date: Fri, 18 Nov 2011 12:59:04 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> In-Reply-To: OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: Garrett Cooper , d@delphij.net, Doug Barton , freebsd-rc@freebsd.org Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:59:06 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 12:50, Eygene Ryabinkin wrote: > Garrett, good day. > > Fri, Nov 18, 2011 at 12:42:27PM -0800, Garrett Cooper wrote: >> On Fri, Nov 18, 2011 at 12:38 PM, Xin LI >> wrote: >>> Is there any counter reasoning about "having an interface >>> marked as non-DHCP is not an error"? I'm still not convinced >>> with the benefit of having it show an error message. >> >> +1. I consider this to be debug noise. > > Well, what about the silent output from 'cc -o test test.c' when > you have no file test.c or the compiler is absent? It is the same > thing (as I see it) and in this case will you expect that the > binary 'test' will be compiled and ready for use or not? I will, > but this can be my personal delusion. I don't think this is a valid argument to my reasoning... In this specific case, having test.c absent is an error, while in the rc.d/dhclient case, having an interface without DHCP configuration is a perfectly fine one, and worked fine in the past... Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxscYAAoJEATO+BI/yjfBxDUIAJrIMkkekSqOEoAyFT9u3FvC hi9D7Ivrr7lTDHs9E/pZUj/Bl2ftbGp6OjySUbK2HJdsvTr1CWjpbudcru5JfE73 A+2F5kMdVVCk65otqcryo5wLzwb82rDRFQzwyFZIYLHLNn7MYiZWkq//YfzKYqbk O3D+VGTIAM8wfIZsYuBuUaALGfyJkEMlCH1+QAdOiHL8zUPr4gZvZLTC1YuTU6ha r+HH6VnXT5gTk8Ll/vEfCrVkAZyss/MWJ/evh+96Z3wkkK8w00zJVfPwEfQMxISQ LlHF/BAxBIVhzLqesLiQ6AwSdg6pthJTAxhORPeH7JYdM6nC/VgnuUzS5gDA2dI= =l6xY -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 20:59:12 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65357106564A; Fri, 18 Nov 2011 20:59:12 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 46C608FC08; Fri, 18 Nov 2011 20:59:10 +0000 (UTC) Received: by faap15 with SMTP id p15so4803405faa.13 for ; Fri, 18 Nov 2011 12:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=6YQEBzcRlTI9R7TDThEMeheLir7oTZUurcIoJpbdtlc=; b=tVcTy9kaTIm8O9JXNLRI0luG2WdWdAM4RdWwpVL8A/pQx5h1y+J2FAHJPM50UAGFvz 5XFnQMtXIA+ClVdmG5cKVp2O2AzUp2SUMW/+oMrqvog+7MuddjV2l61gWXuK1RDrzjuQ UInPhgZrh9uB3IcCsShBjC0URg1FJKDr7R6GI= MIME-Version: 1.0 Received: by 10.182.59.49 with SMTP id w17mr1069132obq.37.1321649948877; Fri, 18 Nov 2011 12:59:08 -0800 (PST) Received: by 10.182.7.34 with HTTP; Fri, 18 Nov 2011 12:59:08 -0800 (PST) In-Reply-To: References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> Date: Fri, 18 Nov 2011 12:59:08 -0800 Message-ID: From: Garrett Cooper To: Eygene Ryabinkin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org, Doug Barton , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 20:59:12 -0000 2011/11/18 Eygene Ryabinkin : > Garrett, good day. > > Fri, Nov 18, 2011 at 12:42:27PM -0800, Garrett Cooper wrote: >> On Fri, Nov 18, 2011 at 12:38 PM, Xin LI wrote: >> > Is there any counter reasoning about "having an interface marked as >> > non-DHCP is not an error"? =A0I'm still not convinced with the benefit >> > of having it show an error message. >> >> +1. I consider this to be debug noise. > > Well, what about the silent output from 'cc -o test test.c' when > you have no file test.c or the compiler is absent? =A0It is the same > thing (as I see it) and in this case will you expect that the binary > 'test' will be compiled and ready for use or not? =A0I will, but this > can be my personal delusion. This is different because you personally are running cc to do a particular task. This noise is emitted unnecessarily by automated tasks which are in the default system, which is more annoying for standard users, like me. There's a reason why I also do this in every system I run: $ svn diff etc/syslog.conf Index: etc/syslog.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- etc/syslog.conf (revision 227492) +++ etc/syslog.conf (working copy) @@ -5,7 +5,7 @@ # separators. If you are sharing this file between systems, you # may want to use only tabs as field separators here. # Consult the syslog.conf(5) manpage. -*.err;kern.warning;auth.notice;mail.crit /dev/console +#*.err;kern.warning;auth.notice;mail.crit /dev/console *.notice;authpriv.none;kern.debug;lpr.info;mail.crit;news.err /var/log/messages security.* /var/log/security auth.info;authpriv.info /var/log/auth.log The point is that the defaults should match what people expect in an operating system -- otherwise FreeBSD will be seen as an elitist hipster OS. Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:08:06 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B64091065675 for ; Fri, 18 Nov 2011 21:08:06 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 771F88FC12 for ; Fri, 18 Nov 2011 21:08:06 +0000 (UTC) Received: by ghbg20 with SMTP id g20so1243493ghb.13 for ; Fri, 18 Nov 2011 13:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=xIWmDDjD9rDVqcr0KxS3QTuElyeNojU1hqIzbzvTCQM=; b=t7zY6hf5gGEJYRuxJIgYAujOoWnDqK6Ggpc1HgvXifDwPUsdWXerC7DvteLUeAT/FZ BN7PnosIHcLAQGMTBJjEpB/OqHUlofG+uYQg++5jtUN3X5ynCuLnndgg25PTsh76RcnR q/DBVryOIr/xxbLSpPhgJv39ndPKDvkGorLck= MIME-Version: 1.0 Received: by 10.182.169.34 with SMTP id ab2mr1074623obc.27.1321648947699; Fri, 18 Nov 2011 12:42:27 -0800 (PST) Received: by 10.182.7.34 with HTTP; Fri, 18 Nov 2011 12:42:27 -0800 (PST) In-Reply-To: <4EC6C247.6040807@delphij.net> References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> Date: Fri, 18 Nov 2011 12:42:27 -0800 Message-ID: From: Garrett Cooper To: d@delphij.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , freebsd-rc@freebsd.org, Eygene Ryabinkin Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:08:06 -0000 On Fri, Nov 18, 2011 at 12:38 PM, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 11/18/11 03:40, Eygene Ryabinkin wrote: >> Gentlemen, good day. >> >> Sun, Nov 06, 2011 at 04:13:04PM -0800, Xin LI wrote: >>> On 11/06/11 15:17, Doug Barton wrote: >>>> What harm is the error message causing? It seems useful to me >>>> to know if something is happening in the background that may >>>> need the administrator's attention. >>> >>> It's harmful because it's not an error -- for example, a bge0 >>> interface which is a member of lagg group, is usually marked >>> explicitly as non-DHCP. =A0On the other hand, can you give me an >>> example where it *is* an error? :-) =A0I can't seem to think about >>> one but I could be wrong here. >>> >>> It sounds like to me a POLA violation by the way since it's not >>> the way it was, but my argument is primarily about "this gives an >>> error message for valid configuration" and not about POLA. >> >> Since devd.conf uses quietstart, there is a way to make everyone >> happy or at least not so angry: check rc_quiet and act accordingly. >> The patch is available at >> http://codelabs.ru/fbsd/patches/dhclient/dhclient-respect-quiet-mode.dif= f >> >> > please, test it and report back. > > Is there any counter reasoning about "having an interface marked as > non-DHCP is not an error"? =A0I'm still not convinced with the benefit > of having it show an error message. +1. I consider this to be debug noise. Thanks, -Garrett From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:09:58 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33F8F106566B; Fri, 18 Nov 2011 21:09:58 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 163B48FC0A; Fri, 18 Nov 2011 21:09:58 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 9128763C4; Fri, 18 Nov 2011 13:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321650597; bh=q5KCwkk8FASNyXT9/+Bgn2Fth4B11C2yuRxPzCkj6v0=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DcaSAz/MQ8bXuhzIXNGpi8trTt9q9Ao9zlSnZp/OiR5OUZBffdGKIvRVBWp3aR5tR wwA4ospiZSSbOJr8QbApyM1SMECnwjYvlvjrW/EFSw7Z2dLL2EBZLUZZRSUP8TOiXF ZNFsWU3iCJFofNExdPCvlad6y5m7nxMWXm59hbLI= Message-ID: <4EC6C9A4.3000006@delphij.net> Date: Fri, 18 Nov 2011 13:09:56 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: Eygene Ryabinkin References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> In-Reply-To: OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.ORG, Doug Barton , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:09:58 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 12:45, Eygene Ryabinkin wrote: > Xin, good day. > > Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >> Is there any counter reasoning about "having an interface marked >> as non-DHCP is not an error"? I'm still not convinced with the >> benefit of having it show an error message. > > Well, when I invoke 'service dhclient start em0' and em0 isn't > DHCP-enabled, I want to see some diagnostics on why I was not able > to get DHCP on that interface. Return code isn't that visible (I > can, of course, always run it as 'service dhclient start em0 || > echo failed'), but I am not up to typing more than needed and I > should see the real reason for absence of DHCP-assigned address in > that case, be it the non-DHCP-enabled interface or some other > problem. Thinking again I believe that your approach is more sensible. Thanks! Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxsmkAAoJEATO+BI/yjfBRIYH/3dvKGznpmDbwPlNO0b4qs4w +Nd4eCKXY0SzHIvZqxm0c9HHE8wvMaZnQFqYb7rOYdlIYHosJfvhiTbIV1kr9YAJ FWmx93bCmzxf1HD3mVuOOCRzOoFEVcJPCstigh9Bp8Jj0EFPu6krbagrVCkY80Jo ZvRJoSEDmqKB8fve23RSpKVDrA5LlQ0Y98AC91yPKpVt/FdHsdWD7/+kKCF2G+uP OBPi8iCdHm4OALdX2YcHGQJFNZIixftEj74FHTHKDrlnBsiLb633U09kzprKMrqf 0iovaPf5OfX/smk8rLx0MrsFBDwSUwIhsaBsJJZr4vCtVDn4j0h0MZjtESZxO74= =BENK -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:11:31 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A63631065670 for ; Fri, 18 Nov 2011 21:11:31 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 8A5248FC24 for ; Fri, 18 Nov 2011 21:11:31 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id E1E5D63F7; Fri, 18 Nov 2011 13:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321650691; bh=OcvaNP76dX0GotbbcSIwR45rW6rY9KV+dJ9yR4qsGg0=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=hFqjkQaXbA4DrbOZ+HgMp/W+T+nDiYevUehGlZ0fh4CmqufGxjoAcGQ1PX1VtFm1J 0WaiNTGXaj98i35QGnjubpwH+HNu64bYugwvLJ1n+xXoEsJlMufx4/7Zk6p/Tg4O7J uMLFAeY3zwitsMugmVH99QxzS2yg/EMFOYUJNSI0= Message-ID: <4EC6CA02.5090606@delphij.net> Date: Fri, 18 Nov 2011 13:11:30 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> <4EC6C50F.30405@FreeBSD.org> In-Reply-To: <4EC6C50F.30405@FreeBSD.org> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:11:31 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 12:50, Doug Barton wrote: > On 11/18/2011 12:45, Eygene Ryabinkin wrote: >> Xin, good day. >> >> Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >>> Is there any counter reasoning about "having an interface >>> marked as non-DHCP is not an error"? I'm still not convinced >>> with the benefit of having it show an error message. >> >> Well, when I invoke 'service dhclient start em0' and em0 isn't >> DHCP-enabled, I want to see some diagnostics on why I was not >> able to get DHCP on that interface. Return code isn't that >> visible (I can, of course, always run it as 'service dhclient >> start em0 || echo failed'), but I am not up to typing more than >> needed and I should see the real reason for absence of >> DHCP-assigned address in that case, be it the non-DHCP-enabled >> interface or some other problem. > > Right, that's my argument as well. > > If there is a particular code path that leads to attempting > dhclient on a non-dhcp interface I'd rather see that code path > fixed than to suppress the warning. Do you have any objection to rea@'s version of patch? I think it's sensible that quietstart shouldn't issue this type of warnings. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxsoCAAoJEATO+BI/yjfB7WMH/iGw2An8lFBSdDYlHhwvmypK Dy5UPSy9EeRH8WEXkGT+m8pAQEoYgPTbuDCXekrOgicQyG4+1TxtTGncjGKKm7s/ ZiviK4Sl7l4zD0fqxMA9kJiaMGYslrLX8dRTfhbwO/lmweRk2Eg44ODDyla6SDI8 T/9pINNR7nBcOAWJltdY/ZtofQydj0EWLFX8v2xL0wBTS9DyLL9Bog878LEzfxYJ ddquA9Frea/8kMsS8sc48dZts1o6DwQ+9oQeOTsYfHqpHznekdNXlZgbkQQI/vYg rtMw0p6mC3jw6jpi+zWavI+IuOlzPstpipVZntl8h/sCq6ZCqL8VjXgE7Y+LBPw= =9v4a -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:29:52 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 3575B1065674 for ; Fri, 18 Nov 2011 21:29:52 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 1FC9414D8D9; Fri, 18 Nov 2011 21:29:10 +0000 (UTC) Message-ID: <4EC6CE25.7000704@FreeBSD.org> Date: Fri, 18 Nov 2011 13:29:09 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: d@delphij.net References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> <4EC6C50F.30405@FreeBSD.org> <4EC6CA02.5090606@delphij.net> In-Reply-To: <4EC6CA02.5090606@delphij.net> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org, Xin LI Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:29:52 -0000 On 11/18/2011 13:11, Xin LI wrote: > On 11/18/11 12:50, Doug Barton wrote: >> On 11/18/2011 12:45, Eygene Ryabinkin wrote: >>> Xin, good day. >>> >>> Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >>>> Is there any counter reasoning about "having an interface >>>> marked as non-DHCP is not an error"? I'm still not convinced >>>> with the benefit of having it show an error message. >>> >>> Well, when I invoke 'service dhclient start em0' and em0 isn't >>> DHCP-enabled, I want to see some diagnostics on why I was not >>> able to get DHCP on that interface. Return code isn't that >>> visible (I can, of course, always run it as 'service dhclient >>> start em0 || echo failed'), but I am not up to typing more than >>> needed and I should see the real reason for absence of >>> DHCP-assigned address in that case, be it the non-DHCP-enabled >>> interface or some other problem. > >> Right, that's my argument as well. > >> If there is a particular code path that leads to attempting >> dhclient on a non-dhcp interface I'd rather see that code path >> fixed than to suppress the warning. > > Do you have any objection to rea@'s version of patch? I already said I did, yes. Fix the real problem, don't paper over the symptom. -- "We could put the whole Internet into a book." "Too practical." Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:36:58 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 832DD1065673 for ; Fri, 18 Nov 2011 21:36:58 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 662928FC13 for ; Fri, 18 Nov 2011 21:36:58 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 3C8C76580; Fri, 18 Nov 2011 13:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321652218; bh=6WwiVhhrKKl74rDT73+dmm4QxY7Ll+gdR71wuExo1Lk=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=og1NTGPRNwY0zHegIP0vEWR6Qt1iU3bszUzy/MFY4c3Ai7bgtxtatdv72Fl+ByfAJ FV36VfOv6LxcgAqYftP3HbUhuGvnZLiGfe4y9k+jLWMIgyeRsrXHNdu/OIOVg5QfMF Mv/dWwPs0E2zh/p09f2vNxCBBF/yivMw/EuFQpZc= Message-ID: <4EC6CFF9.5020907@delphij.net> Date: Fri, 18 Nov 2011 13:36:57 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> <4EC6C50F.30405@FreeBSD.org> <4EC6CA02.5090606@delphij.net> <4EC6CE25.7000704@FreeBSD.org> In-Reply-To: <4EC6CE25.7000704@FreeBSD.org> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:36:58 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 13:29, Doug Barton wrote: > On 11/18/2011 13:11, Xin LI wrote: > >> Do you have any objection to rea@'s version of patch? > > I already said I did, yes. > > Fix the real problem, don't paper over the symptom. Could you please point out what's the real problem, which we might all overlooked? (To me, I think devd should just delegate the responsibility of determining whether use DHCP is appropriate to the rc.d script, because that reduces duplicated code, therefore I didn't see problem here, but I could be wrong). Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxs/5AAoJEATO+BI/yjfBGdUH/ihkYQgAiXzysAdyD4rMe7Yj xlAqztQHKnHl11rWxpK9LOF5XXkSz6C7D2KVXW+GAnEJ1tQtSM7mXG/yDLwgaX5H IYmyi0y0Atuui1Yb3803VhVIQldI/FWzwf7YCoQf95L/6OTD1K4csjH0ovL+DWhJ 4FuAatbwbYKy8ekPEgEK6DH8mwcRuvVvC2ELrPqUenYBqFHCKMk/lo6vW1Jwy4kB 7iuoztZfumR23UGPdG6HKHohC8P+S3usmlTBziYbZV03thD2c0oOu54BRsLwHzcD uqEtR5MWqzRgJreaH8eLp7ZBbX1cndgu0T6/fPIRIBFQbjgZ0VlG5WeRgmLeeIc= =JGv9 -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Sat Nov 19 05:30:00 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39295106566B; Sat, 19 Nov 2011 05:30:00 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id BAB1F8FC13; Sat, 19 Nov 2011 05:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=two; h=Sender:In-Reply-To:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=4ptF12zBGbSVqHMP8iBBP6Her8DRsTxnIqh0PP5w1LQ=; b=fsKbjiLAFQJ6DLNhID1rPinYP8Uah+ISI53qrmc/9U9r6wGyJHydkuoPzzycJ7cbnMlx9EK8Gr1nlA34yUbTm4z50XQjNcU/fYD+R7ckiRfUDwkdZk3fnyZM9K46wv7hcWl5dZ2bjS0HvArkeyw/VzPemRb+OMe5B9nBiOl6B9cLwIiR3dJiSkm9Cba/XzQfBfA8t/m8nglb+7lTqW9xono+ONYPEUY0sPXPPcJ91d2NiQr3GnRmNnTYBW8LFBWvDpuJptgImjJcIy+6HgA5hE1XlmQ9ZtGLMwLLu6h2nDJuZkiinQ87VHiZBy4O3I6iEz0vNM7zbyd62kVC7Tscuw==; Received: from shadow.codelabs.ru (ppp91-77-172-150.pppoe.mtu-net.ru [91.77.172.150]) by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256) id 1RRdUz-000Axm-QA; Sat, 19 Nov 2011 08:29:58 +0300 Date: Sat, 19 Nov 2011 09:29:54 +0400 From: Eygene Ryabinkin To: Garrett Cooper , d@delphij.net Message-ID: <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ylS2wUBXLOxYXZFQ" Content-Disposition: inline In-Reply-To: <4EC6C9A4.3000006@delphij.net> Sender: rea@codelabs.ru Cc: mtm@freebsd.org, Doug Barton , freebsd-rc@freebsd.org Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2011 05:30:00 -0000 --ylS2wUBXLOxYXZFQ Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Gentlemen, good morning. Fri, Nov 18, 2011 at 12:59:08PM -0800, Garrett Cooper wrote: > 2011/11/18 Eygene Ryabinkin : > > Well, what about the silent output from 'cc -o test test.c' when > > you have no file test.c or the compiler is absent? =9AIt is the same > > thing (as I see it) and in this case will you expect that the binary > > 'test' will be compiled and ready for use or not? =9AI will, but this > > can be my personal delusion. >=20 > This is different because you personally are running cc to do a > particular task. This noise is emitted unnecessarily by automated > tasks which are in the default system, which is more annoying for > standard users, like me. Hmm, automated tasks (devd in our case) run 'quietstart', not bare 'start', so my latest patch that was announced for the testing yesterday just tries to cope with this situation: no noise will be produced for the 'quiest', but bare '' will spit a reason for skipping DHCP client run on non-DHCP interface. I believe that this fits to your expectations: intended invocation via 'start' will throw a verbose error, but automated one via 'quietstart' -- won't. So, we seem to be closer to some consensus, aren't we? Fri, Nov 18, 2011 at 01:09:56PM -0800, Xin LI wrote: > On 11/18/11 12:45, Eygene Ryabinkin wrote: > > Well, when I invoke 'service dhclient start em0' and em0 isn't=20 > > DHCP-enabled, I want to see some diagnostics on why I was not able > > to get DHCP on that interface. Return code isn't that visible (I > > can, of course, always run it as 'service dhclient start em0 || > > echo failed'), but I am not up to typing more than needed and I > > should see the real reason for absence of DHCP-assigned address in > > that case, be it the non-DHCP-enabled interface or some other > > problem. >=20 > Thinking again I believe that your approach is more sensible. > Thanks! Thank you! So, seems like the only known caveat (raised by Doug) is the semantics of the 'quiet' prefix. Looking at the NetBSD CVS, http://cvsweb.netbsd.org/bsdweb.cgi/src/etc/rc.subr?annotate=3D1.88&only_= with_tag=3DMAIN I see that they have no 'quiet' operations, so this is FreeBSD addition made by mtm@, http://svnweb.freebsd.org/base?view=3Drevision&revision=3D175676 Judging by that change and the fact that rc_quiet is mostly used internally to the rc.subr and currently its only use is to skip some diagnostics in the following snippet, {{{ if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcvar" -a "$rc_arg" != =3D "stop" ] || [ -n "${rcvar}" -a "$rc_arg" =3D "stop" -a -z "${rc_pid= }" ]; then if ! checkyesno ${rcvar}; then if [ -n "${rc_quiet}" ]; then return 0 fi echo -n "Cannot '${rc_arg}' $name. Set ${rc= var} to " echo -n "YES in /etc/rc.conf or use 'one${r= c_arg}' " echo "instead of '${rc_arg}'." return 0 fi fi }}} I would say that my (ab)use of it in the patch perfectly fits the cited usage. That's not an excuse if the semantics of rc_quiet will be different from its current usage, but since we have no well-documented semantics apart from "Don't output some diagnostics" inside /etc/rc.subr, may be we can just extend this explanation based on the current usage and the common sense, add that to the manual page of rc.subr and go on? Any thoughts on this? --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --ylS2wUBXLOxYXZFQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EAREIAAYFAk7HPtIACgkQFq+eroFS7Pt+/AD/W4dj1FzUOLdCxi783id0APAV sIpJBZnnrG1SLSstomEA/jQFO0xDYOqjoIM+tIDJn1tfq73HGUZzPIai+oTHL+eB =e4RD -----END PGP SIGNATURE----- --ylS2wUBXLOxYXZFQ-- From owner-freebsd-rc@FreeBSD.ORG Sat Nov 19 05:37:21 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AC81106564A; Sat, 19 Nov 2011 05:37:21 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id C6E8A8FC12; Sat, 19 Nov 2011 05:37:20 +0000 (UTC) Received: by ggnk5 with SMTP id k5so4169991ggn.13 for ; Fri, 18 Nov 2011 21:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=3oCcj1xmTgG3Vcm3ytP6IsfyFch0NF9NtqQEGYtn/IQ=; b=x+5UeJ3g00licuD4XHqpHKFHFxDlJMzIk5DVvR2jy6sDOSwafk/IM+2hYIkGd/pXvV IycRm/1pv+sXeySVpYAJ4EtO6vWbMx87AlnBQQYaxkjm0udGxCYOdl+ffGYLYPG8ZIBy sEOZvs2hMbzkcUp7NGAZV49KW1dqHoOuD/oC4= MIME-Version: 1.0 Received: by 10.182.225.3 with SMTP id rg3mr1322287obc.77.1321681040158; Fri, 18 Nov 2011 21:37:20 -0800 (PST) Received: by 10.182.7.34 with HTTP; Fri, 18 Nov 2011 21:37:19 -0800 (PST) In-Reply-To: <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> References: <4EC6C9A4.3000006@delphij.net> <3EG8fAEe6lZEtr/D6Pw60YTcoYU@YnbH/K3/Y1Z96RV2jTofcGuSPJI> Date: Fri, 18 Nov 2011 21:37:19 -0800 Message-ID: From: Garrett Cooper To: Eygene Ryabinkin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org, mtm@freebsd.org, Doug Barton , d@delphij.net Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2011 05:37:21 -0000 2011/11/18 Eygene Ryabinkin : > Gentlemen, good morning. > > Fri, Nov 18, 2011 at 12:59:08PM -0800, Garrett Cooper wrote: >> 2011/11/18 Eygene Ryabinkin : >> > Well, what about the silent output from 'cc -o test test.c' when >> > you have no file test.c or the compiler is absent? =A0It is the same >> > thing (as I see it) and in this case will you expect that the binary >> > 'test' will be compiled and ready for use or not? =A0I will, but this >> > can be my personal delusion. >> >> =A0 =A0 This is different because you personally are running cc to do a >> particular task. This noise is emitted unnecessarily by automated >> tasks which are in the default system, which is more annoying for >> standard users, like me. > > Hmm, automated tasks (devd in our case) run 'quietstart', not bare > 'start', so my latest patch that was announced for the testing > yesterday just tries to cope with this situation: no noise will be > produced for the 'quiest', but bare '' will spit a reason > for skipping DHCP client run on non-DHCP interface. =A0I believe that > this fits to your expectations: intended invocation via 'start' will > throw a verbose error, but automated one via 'quietstart' -- won't. > > So, we seem to be closer to some consensus, aren't we? Yes. My disagreement was more or less over the class of the error message (I agree that it should exist, but it seems more debug than something that should be printed on stdout for all cases). > Fri, Nov 18, 2011 at 01:09:56PM -0800, Xin LI wrote: >> On 11/18/11 12:45, Eygene Ryabinkin wrote: >> > Well, when I invoke 'service dhclient start em0' and em0 isn't >> > DHCP-enabled, I want to see some diagnostics on why I was not able >> > to get DHCP on that interface. =A0Return code isn't that visible (I >> > can, of course, always run it as 'service dhclient start em0 || >> > echo failed'), but I am not up to typing more than needed and I >> > should see the real reason for absence of DHCP-assigned address in >> > that case, be it the non-DHCP-enabled interface or some other >> > problem. >> >> Thinking again I believe that your approach is more sensible. >> Thanks! > > Thank you! > > So, seems like the only known caveat (raised by Doug) is the semantics > of the 'quiet' prefix. =A0Looking at the NetBSD CVS, > =A0http://cvsweb.netbsd.org/bsdweb.cgi/src/etc/rc.subr?annotate=3D1.88&on= ly_with_tag=3DMAIN > I see that they have no 'quiet' operations, so this is FreeBSD addition > made by mtm@, > =A0http://svnweb.freebsd.org/base?view=3Drevision&revision=3D175676 > Judging by that change and the fact that rc_quiet is mostly used > internally to the rc.subr and currently its only use is to skip > some diagnostics in the following snippet, > {{{ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if [ -n "${rcvar}" -a "$rc_arg" !=3D "rcva= r" -a "$rc_arg" !=3D "stop" ] || > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[ -n "${rcvar}" -a "$rc_arg" =3D "= stop" -a -z "${rc_pid}" ]; then > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if ! checkyesno ${rcvar}; = then > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if [ -n "$= {rc_quiet}" ]; then > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0return 0 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0fi > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0echo -n "C= annot '${rc_arg}' $name. Set ${rcvar} to " > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0echo -n "Y= ES in /etc/rc.conf or use 'one${rc_arg}' " > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0echo "inst= ead of '${rc_arg}'." > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return 0 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0fi > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0fi > }}} > > I would say that my (ab)use of it in the patch perfectly fits the > cited usage. =A0That's not an excuse if the semantics of rc_quiet will > be different from its current usage, but since we have no > well-documented semantics apart from "Don't output some diagnostics" > inside /etc/rc.subr, may be we can just extend this explanation based > on the current usage and the common sense, add that to the manual page > of rc.subr and go on? I'd say just do it. Otherwise the semantics of 'quiet' vs 'non-quiet' will be frittered over unnecessarily, when the original implementer should have just documented the requirements in an unambiguous manner. Thanks, -Garrett