From owner-freebsd-java@FreeBSD.ORG Thu Apr 22 10:58:00 2004 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B718B16A4CE for ; Thu, 22 Apr 2004 10:58:00 -0700 (PDT) Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr [139.124.41.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D87043D49 for ; Thu, 22 Apr 2004 10:57:59 -0700 (PDT) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: from arabica.esil.univ-mrs.fr (localhost.esil.univ-mrs.fr [127.0.0.1])i3MHvwVI041499 for ; Thu, 22 Apr 2004 19:57:58 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: (from rv@localhost) by arabica.esil.univ-mrs.fr (8.12.10/8.12.10/Submit) id i3MHvw9V041498 for freebsd-java@freebsd.org; Thu, 22 Apr 2004 19:57:58 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to herve.quiroz@esil.univ-mrs.fr using -f Date: Thu, 22 Apr 2004 19:57:58 +0200 From: Herve Quiroz To: freebsd-java@freebsd.org Message-ID: <20040422175758.GA30200@arabica.esil.univ-mrs.fr> Mail-Followup-To: freebsd-java@freebsd.org References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Subject: Re: updating my port to bsd.java.mk options X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2004 17:58:00 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ronald, Good initiative indeed! :) NEED_JAVAC has been deprecated as well. Now JAVA_BUILD (and respectively JAVA_RUN) allows two values: 'jdk' or 'jre'. When JAVA_BUILD=jdk, it means that a compiler is needed, which is the same as setting NEED_JAVAC=yes as before. When nothing is set (neither JAVA_BUILD nor JAVA_RUN), bsd.java.mk assumes the folloing default values: JAVA_BUILD= jdk JAVA_RUN= jre So your patch is correct is this regard. You just need to remove the NEED_JAVAC statement. I tested it on my box and it seems to work. I said "seems" because I have a build error. I've attached the log just in case. I haven't got enough time to debug it myself at the moment so if you know the problem, please tell me (I'll investigate myself in a few days otherwise). BTW, I had trouble with your diff file: probably a cut-n-paste error but all tabs were replaced by spaces in your message. Herve On Thu, Apr 22, 2004 at 07:28:50PM +0200, Ronald Klop wrote: > Hello, > > Is this patch correct to update my port to the new bsd.java.mk? > Do I need to set JAVA_BUILD or JAVA_RUN? And what are valid values for > these? > It uses javac while building and is a library to run with java. That's why > it needs native java. > Any comments before I send a PR for this? > > Greetings, > > Ronald. > PS: It al builds/runs ok here (but I already have jdk14 installed). > > diff -ur /usr/ports/java/jmp/Makefile jmp/Makefile > --- /usr/ports/java/jmp/Makefile Mon Apr 5 18:54:38 2004 > +++ jmp/Makefile Thu Apr 22 19:14:45 2004 > @@ -35,7 +35,9 @@ > > USE_LIBTOOL_VER=13 > USE_GMAKE= yes > -USE_JAVA= 1.2+ > +USE_JAVA= yes > +JAVA_VERSION= 1.2+ > +JAVA_OS= native > NEED_JAVAC= yes > > MAKE_FLAGS= JAVAC=${JAVAC} JAVAH=${JAVAH} > > > -- > Using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/ > _______________________________________________ > freebsd-java@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-java > To unsubscribe, send any mail to "freebsd-java-unsubscribe@freebsd.org" --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=mylog ===> Building for jmp-0.41_1 gmake: `Makefile' is up to date. gmake all-recursive gmake[1]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41' Making all in intl gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/intl' gmake[2]: Nothing to be done for `all'. gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/intl' Making all in po gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/po' gmake[2]: Nothing to be done for `all'. gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/po' Making all in java gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/java' Making all in jmp gmake[3]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/java/jmp' gmake[3]: Nothing to be done for `all'. gmake[3]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/java/jmp' gmake[3]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/java' gmake[3]: Nothing to be done for `all-am'. gmake[3]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/java' gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/java' Making all in javadoc gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/javadoc' gmake[2]: Nothing to be done for `all'. gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/javadoc' Making all in jvmsimulator gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41/jvmsimulator' gmake[2]: Nothing to be done for `all'. gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41/jvmsimulator' gmake[2]: Entering directory `/usr/ports/java/jmp/work/jmp-0.41' sourcepath java -d . java/jmp/JMPController.java gmake[2]: sourcepath: Command not found gmake[2]: [jmp/JMPController.class] Error 127 (ignored) /usr/local/jdk1.4.2/bin/javah jmp.JMPController Error: Class jmp.JMPController could not be found. gmake[2]: *** [jmp_JMPController.h] Error 15 gmake[2]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/ports/java/jmp/work/jmp-0.41' gmake: *** [all-recursive-am] Error 2 *** Error code 2 Stop in /usr/ports/java/jmp. --Nq2Wo0NMKNjxTN9z--