From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 30 13:40:13 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3D4710656A9 for ; Thu, 30 Dec 2010 13:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 67EEB8FC14 for ; Thu, 30 Dec 2010 13:40:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBUDeDa9019994 for ; Thu, 30 Dec 2010 13:40:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBUDeDDD019992; Thu, 30 Dec 2010 13:40:13 GMT (envelope-from gnats) Resent-Date: Thu, 30 Dec 2010 13:40:13 GMT Resent-Message-Id: <201012301340.oBUDeDDD019992@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eitan Adler Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8624A1065679 for ; Thu, 30 Dec 2010 13:32:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 75F658FC0C for ; Thu, 30 Dec 2010 13:32:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oBUDWZnm065585 for ; Thu, 30 Dec 2010 13:32:35 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oBUDWZtn065584; Thu, 30 Dec 2010 13:32:35 GMT (envelope-from nobody) Message-Id: <201012301332.oBUDWZtn065584@red.freebsd.org> Date: Thu, 30 Dec 2010 13:32:35 GMT From: Eitan Adler To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/153547: [patch] remove NO_SIZE from the ports system X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2010 13:40:13 -0000 >Number: 153547 >Category: ports >Synopsis: [patch] remove NO_SIZE from the ports system >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 30 13:40:13 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Eitan Adler >Release: >Organization: >Environment: >Description: As explained in ports/153544 there are currently only 4 ports marked with NO_SIZE and of them only 1 doesn't actually report a size. I propose that there is no real reason to have a NO_SIZE option and it should be removed. >How-To-Repeat: >Fix: Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.666 diff -u -r1.666 bsd.port.mk --- bsd.port.mk 29 Dec 2010 07:14:56 -0000 1.666 +++ bsd.port.mk 30 Dec 2010 13:15:54 -0000 @@ -871,14 +871,6 @@ # change the owner and group of all files under ${WRKDIR} # to 0:0. Set this variable if you want to turn off this # feature. -# -# For makesum: -# -# NO_SIZE - Don't record size data in distinfo, needed -# when the master site does not report file -# sizes, or when multiple valid versions of -# a distfile, having different sizes, exist. -# # For patch: # # EXTRA_PATCHES - Define this variable if you have patches not in @@ -4926,9 +4918,7 @@ $$alg_executable $$file >> ${DISTINFO_FILE}; \ fi; \ done; \ - if [ -z "${NO_SIZE}" ]; then \ - ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${DISTINFO_FILE}; \ - fi; \ + ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${DISTINFO_FILE}; \ done \ ) @for file in ${_IGNOREFILES}; do \ >Release-Note: >Audit-Trail: >Unformatted: