From owner-svn-ports-head@FreeBSD.ORG  Mon Sep  1 07:51:24 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E9AF1262;
 Mon,  1 Sep 2014 07:51:24 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BF39513F0;
 Mon,  1 Sep 2014 07:51:24 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 65A5643B96;
 Mon,  1 Sep 2014 02:51:06 -0500 (CDT)
Message-ID: <54042559.6010001@marino.st>
Date: Mon, 01 Sep 2014 09:50:49 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>, 
 Pietro Cerutti <gahr@FreeBSD.org>
Subject: Re: svn commit: r366841 - head/lang/tcl86/files
References: <201409010731.s817Vrxf062753@svn.freebsd.org>
 <20140901074609.GA32100@FreeBSD.org>
In-Reply-To: <20140901074609.GA32100@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Sep 2014 07:51:25 -0000

On 9/1/2014 09:46, Alexey Dokuchaev wrote:
> On Mon, Sep 01, 2014 at 07:31:53AM +0000, Pietro Cerutti wrote:
>> New Revision: 366841
>> URL: http://svnweb.freebsd.org/changeset/ports/366841
>> QAT: https://qat.redports.org/buildarchive/r366841/
>>
>> Log:
>>   - Fix customization of Tcl modules path
>>
>> Modified:
>>   head/lang/tcl86/files/patch-unix-Makefile.in
>>
>> Modified: head/lang/tcl86/files/patch-unix-Makefile.in
>> ==============================================================================
>> --- head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:26:14 2014	(r366840)
>> +++ head/lang/tcl86/files/patch-unix-Makefile.in	Mon Sep  1 07:31:53 2014	(r366841)
>> @@ -1,5 +1,5 @@
>> ---- Makefile.in.orig	2014-08-26 15:23:08 UTC
>> -+++ Makefile.in
>> +--- Makefile.in.orig	2014-08-26 17:23:08.000000000 +0200
>> ++++ Makefile.in	2014-09-01 09:32:00.000000000 +0200
> 
> Now isn't it nice: someone corrected the patch header for you, making it
> TZ-agnostic, nice looking without that stupid zer000000000s so subsequent
> commits will have deduced churn.  And you've just reverted it back to the
> middle ages.
> 
> Since when did we abandon the practice of doing 'svn diff' before commit?


I wouldn't be so hard on him.   The problem is that the makepatch fix
(D582) has been stuck for <fill-in-blank> reasons.  If it had been
available, this wouldn't have happened.

Please push D582 forward, folks  We need it.

John