From owner-svn-src-all@FreeBSD.ORG  Wed Dec 31 15:54:02 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E9A05F62
 for <svn-src-all@freebsd.org>; Wed, 31 Dec 2014 15:54:02 +0000 (UTC)
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7C05730D1
 for <svn-src-all@freebsd.org>; Wed, 31 Dec 2014 15:54:02 +0000 (UTC)
Received: by mail-wi0-f182.google.com with SMTP id h11so25695963wiw.15
 for <svn-src-all@freebsd.org>; Wed, 31 Dec 2014 07:54:00 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:content-type:mime-version:subject:from
 :in-reply-to:date:cc:content-transfer-encoding:message-id:references
 :to; bh=vml4svQiY6zqyiL38XUsG9VZMRR83ngwnsCqyhoqHn0=;
 b=kK5CFRUekPdvVyaco41KGfTxCP/v/60z1XbK/ggHpmCCwoCVFCTRA4PKPx1tWSmY0k
 DgMoSTD1QYesBIC69fbL/7yqhwNavfhtrPIgYsAN6nQl+UDV7tadcnEG4wtJhe28N+13
 XJ/ds8U+I8r61kDyWbCigK8Bq00LwHeTUy/sW1UaIbzB1OBXkrdwqi92AHP1YF9TpMV9
 g00ZQcRmCbKuAiZxkRsBm2BQvyKX15bwxvOPATwgwNyUKJ1FdAzdY3MH5XQFq4Y5iFst
 8In8AcIGiN8ffucKZ3GpnWrB+CzOIf9WM0/X1Tu2JBJr1l9qlPu8+ixbvlSpLT65KqT+
 mkdA==
X-Gm-Message-State: ALoCoQlviPpQUCLcmZjU45kTp8vHHenrNWotWzwgoT2bPq4FDRmFOvoC5VY+8fSIAXcBUFmwniXy
X-Received: by 10.194.93.5 with SMTP id cq5mr126519606wjb.84.1420041240322;
 Wed, 31 Dec 2014 07:54:00 -0800 (PST)
Received: from [192.168.1.32] (81.184.188.119.dyn.user.ono.com.
 [81.184.188.119])
 by mx.google.com with ESMTPSA id gs10sm47523479wib.12.2014.12.31.07.53.58
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 31 Dec 2014 07:53:59 -0800 (PST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r276423 - stable/10/share/mk
From: Julio Merino <jmmv@meroh.net>
In-Reply-To: <201412302046.sBUKk2B3049040@svn.freebsd.org>
Date: Wed, 31 Dec 2014 16:54:28 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <CA2595B7-6D82-478D-BA60-0966D4246F86@meroh.net>
References: <201412302046.sBUKk2B3049040@svn.freebsd.org>
To: Garrett Cooper <ngie@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, svn-src-stable-10@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Dec 2014 15:54:03 -0000

On Dec 30, 2014, at 21:46, Garrett Cooper <ngie@FreeBSD.org> wrote:

> Author: ngie
> Date: Tue Dec 30 20:46:01 2014
> New Revision: 276423
> URL: https://svnweb.freebsd.org/changeset/base/276423
>=20
> Log:
>  MFC r274077:
>=20
>    As an optimization (in simple, well used cases) only call cat =
${.ALLSRC} when
>    generating files from various sources instead of calling cat =
${.ALLSRC} | sed

Is there any visible effect to this optimization?  Otherwise, the extra =
complexity does not seem warranted.=