From owner-svn-src-all@FreeBSD.ORG Wed Dec 17 15:30:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D136C8; Wed, 17 Dec 2014 15:30:33 +0000 (UTC) Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7AB3DD3; Wed, 17 Dec 2014 15:30:32 +0000 (UTC) Received: by mail-ie0-f170.google.com with SMTP id rd18so15136132iec.29 for ; Wed, 17 Dec 2014 07:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Gpxze81Vzc6vpKQHSrPhkzvl4ff2Kmz7G9sUyHooOjw=; b=T/Lj04IbkMv8Mgs0NV4VvqeLdUVNUzvm/SN3NGVr2c01BCKBEq8bJdm6AtK3Zpe/UU yzOkqsrRNOFLBtiW8gqBC4gW/+8hdnaeeOkPkOqRNXcYCx+a2UlHt+WXU0TCd1vuNFim rX4xDpin50UIEepWLEdLnZkyOlayH0p7i1Eu7myzAl5h7PmUf7ElHvgzAVYTJ8myFRwC 6mDLQE74+2BBOdYgLWU3nZsczLA4cvViBPYmtqmkAMin1IoGJh4qJ22uv5kTh6fUNiXo fRylgi+20HhRACcOOzNzWQVsHT+V1cqzZL1RXbSVGjN8aD2EDDkwy5Dt0gU83zwc5Jz/ lhNA== MIME-Version: 1.0 X-Received: by 10.42.194.17 with SMTP id dw17mr36957989icb.4.1418830232148; Wed, 17 Dec 2014 07:30:32 -0800 (PST) Sender: edschouten@gmail.com Received: by 10.107.176.145 with HTTP; Wed, 17 Dec 2014 07:30:32 -0800 (PST) In-Reply-To: <20141216162055.GA64273@troutmask.apl.washington.edu> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> Date: Wed, 17 Dec 2014 16:30:32 +0100 X-Google-Sender-Auth: yxmw3XDCO1ktGwuwH0FIMJSsTMQ Message-ID: Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src From: Ed Schouten To: Steve Kargl Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 15:30:33 -0000 Steve, 2014-12-16 17:20 GMT+01:00 Steve Kargl : > This seems like a lot of code churn for very little benefit. > > In particular, I know that the one person working on fixing > problems with FreeBSD's libm has a private repo and the openlibm > and android developers base their libm off of FreeBSD's libm > and now they'll need to resync their codebases and resolve > conflicts. I'm always afraid of statements like these, as they can be brought to the table to prevent any changes from being made. The fact that someone else (be it Android or openlibm) uses our code should not limit us as a project to make changes. Hopefully this change will merge into their direction as well? The fact that we often do not dare to refactor our code is exactly what puts us in the spot that a lot of our code is often not directly reusable by others, needs to be forked and adjusted. Examples include u_intX_t, bcopy(), etc. > This comment isn't true! These functions pre-date C11 by years. > See r151865. These functions were designed to deal with gcc's > poorly implemented I. See the paragraph above your comment. Keep in mind that the phrasing is intended to say that CMPLX*() and friends are part of C11. Those do not pre-date C11. > Upon further inspection with md5, this change affects only a single > file. This last paragraph appears to be an excuse for a drive-by > commit. But also acts as proof that the change is harmless. I am not entirely sure what you're trying to imply with this. Are changes that do not affect checksums of object files are bad? -- Ed Schouten