From owner-svn-src-head@FreeBSD.ORG Wed Feb 11 22:53:21 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B04ED106564A; Wed, 11 Feb 2009 22:53:21 +0000 (UTC) (envelope-from helen.zhang@bluecoat.com) Received: from whisker.bluecoat.com (whisker.bluecoat.com [216.52.23.28]) by mx1.freebsd.org (Postfix) with ESMTP id 4588D8FC08; Wed, 11 Feb 2009 22:53:20 +0000 (UTC) (envelope-from helen.zhang@bluecoat.com) Received: from bcs-mail6.internal.cacheflow.com ([10.2.2.69]) by whisker.bluecoat.com (8.14.2/8.14.2) with ESMTP id n1BMceNp020473; Wed, 11 Feb 2009 14:38:41 -0800 (PST) Received: from bcs-mail04.internal.cacheflow.com ([10.2.2.56]) by bcs-mail6.internal.cacheflow.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 11 Feb 2009 14:38:35 -0800 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Wed, 11 Feb 2009 14:37:36 -0800 Message-ID: <9CFA8139F7106843B28F9E6FB1FF4BBE0D035E@bcs-mail04.internal.cacheflow.com> In-Reply-To: <20090211221720.GD93010@alchemy.franken.de> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r188457 - head/sys/dev/bge Thread-Index: AcmMlpF1J3scEl0bSMmuzflKpgxI1AAAlQaA References: <200902102154.n1ALsNCh005356@svn.freebsd.org> <1234303787.10699.4.camel@localhost> <20090211221720.GD93010@alchemy.franken.de> From: "Zhang, Helen" To: "Marius Strobl" , "Coleman Kane" X-OriginalArrivalTime: 11 Feb 2009 22:38:35.0427 (UTC) FILETIME=[79920F30:01C98C99] Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: RE: svn commit: r188457 - head/sys/dev/bge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2009 22:53:22 -0000 Thank Marius for checking in the code. I ran into the problem mainly because mii driver was not hooked properly, so mii_phy_probe() function failed. -Helen -----Original Message----- From: Marius Strobl [mailto:marius@alchemy.franken.de]=20 Sent: Wednesday, February 11, 2009 2:17 PM To: Coleman Kane Cc: src-committers@FreeBSD.org; svn-src-all@FreeBSD.org; svn-src-head@FreeBSD.org; Zhang, Helen Subject: Re: svn commit: r188457 - head/sys/dev/bge On Tue, Feb 10, 2009 at 05:09:47PM -0500, Coleman Kane wrote: > On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote: > > Author: marius > > Date: Tue Feb 10 21:54:23 2009 > > New Revision: 188457 > > URL: http://svn.freebsd.org/changeset/base/188457 > >=20 > > Log: > > Don't reset the PHY probe retry counter within the loop so > > it will eventually terminate as intended. > > =20 > > Submitted by: Helen Zhang > >=20 > > Modified: > > head/sys/dev/bge/if_bge.c > >=20 > > Modified: head/sys/dev/bge/if_bge.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D > > --- head/sys/dev/bge/if_bge.c Tue Feb 10 21:51:33 2009 (r188456) > > +++ head/sys/dev/bge/if_bge.c Tue Feb 10 21:54:23 2009 (r188457) > > @@ -2674,11 +2674,11 @@ bge_attach(device_t dev) > > * if we get a conflict with the ASF firmware accessing > > * the PHY. > > */ > > + trys =3D 0; > > BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP); > > again: > > bge_asf_driver_up(sc); > > =20 > > - trys =3D 0; > > if (mii_phy_probe(dev, &sc->bge_miibus, > > bge_ifmedia_upd, bge_ifmedia_sts)) { > > if (trys++ < 4) { > >=20 >=20 > I'm curious... I recent ran into a problem where this driver was not > properly recovering from an ACPI resume event (under amd64 with some > patches). I am curious if this patch might fix that problem... as the > death happened somewhere around here. I doubt that. >=20 > What example case did you use to discover this bug? >=20 You'd need to ask Helen (CC'ed) regarding this. Marius