From owner-freebsd-ports-bugs@freebsd.org Sun Mar 13 11:28:51 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE7E5ACF9EB for ; Sun, 13 Mar 2016 11:28:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF208EAD for ; Sun, 13 Mar 2016 11:28:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u2DBSpbA050728 for ; Sun, 13 Mar 2016 11:28:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207782] New port: audio/dsbmixer: Tabbed GTK+ mixer Date: Sun, 13 Mar 2016 11:28:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2016 11:28:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207782 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #4 from Raphael Kubo da Costa --- Hi, A few suggestions you can follow to simplify the Makefile: - There's an NLS description in Mk/bsd.options.desc.mk that can be used so = you don't need to set NLS_DESC. - Instead of including bsd.port.options.mk and checking for the options, you can use the syntax helpers: NLS_MAKE_ARGS_OFF=3D -DWITHOUT_GETTEXT # you can unconditionally set NLS_LANGS DEVD_MAKE_ARGS_OFF=3D -DWITHOUT_DEVD - dsbmixer's Makefile already has an install target, so you shouldn't need = to define do-install yourself. Since you are also dsbmixer's upstream author, I suggest you just improve its Makefile to support the DESTDIR variable: this would allow `make stage' to work without any changes and everything would w= ork out of the box. - Speaking of upstream, something you should consider is to ship a separate COPYING or LICENSE file with the license the code is licensed under. --=20 You are receiving this mail because: You are the assignee for the bug.=