From owner-freebsd-isdn Sat Aug 1 06:32:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id GAA12746 for freebsd-isdn-outgoing; Sat, 1 Aug 1998 06:32:17 -0700 (PDT) (envelope-from owner-freebsd-isdn@FreeBSD.ORG) Received: from mail.ppp.net (mail.ppp.net [194.64.12.35]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA12741 for ; Sat, 1 Aug 1998 06:32:15 -0700 (PDT) (envelope-from ernie!bert.kts.org!hm@ppp.net) Received: from casparc.ppp.net (casparc2.ppp.net [194.64.12.42]) by mail.ppp.net (8.8.8/8.8.8) with SMTP id PAA00288; Sat, 1 Aug 1998 15:32:02 +0200 Received: from ernie by casparc.ppp.net with uucp (Smail3.1.28.1 #1) id m0z2blR-002ZjcC; Sat, 1 Aug 98 15:32 MET DST Received: from bert.kts.org(really [194.55.156.2]) by ernie.kts.org via sendmail with smtp id for ; Sat, 1 Aug 1998 15:04:33 +0200 (CEST) (Smail-3.2.0.91 1997-Jan-14 #3 built 1998-Feb-14) Received: by bert.kts.org via sendmail with stdio id for freebsd-isdn@FreeBSD.ORG; Sat, 1 Aug 1998 14:58:32 +0200 (CEST) (Smail-3.2.0.94 1997-Apr-22 #1 built 1998-Jun-6) Message-Id: From: hm@kts.org (Hellmuth Michaelis) Subject: Re: Preparations for BSD/OS port In-Reply-To: <199808010659.IAA04870@rumolt.teuto.de> from Martin Husemann at "Aug 1, 98 08:59:18 am" To: martin@rumolt.teuto.de (Martin Husemann) Date: Sat, 1 Aug 1998 14:58:32 +0200 (CEST) Cc: bert_driehuis@nl.compuware.com, freebsd-isdn@FreeBSD.ORG Organization: Kitchen Table Systems Reply-To: hm@kts.org X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Martin Husemann wrote: > Sometime ago we had a common include file for all the 16.3 based cards which > used some generic macros to create the individual driver functions. Don't know > why it was removed... I removed it because - IMHO - that made the code more unreadable and removed more obviousness from it and i didn't and don't like that. Functions are functions and i simply don't like them to be replaced by macros generating functions included from .h-files. For me, the top priority is readability, second maintainability, then comes functionality, portability and speed. > I think a real worth amount of cleanup would happen if we would unify the > parameters passed to the card specific drivers. The FreeBSD port should > simply adopt the much more general sheme used for NetBSD now. We could try > to make some compatibility no-op "bus_space" macros and may be done with > all the #ifdef's in that part - besides probe and attach, due to the > semantic differences there. As long as the things above apply this is fine for me. hellmuth -- Hellmuth Michaelis hm@kts.org Hamburg, Europe A duck is like a bicycle because they both have two wheels except the duck (terry@cs.weber.edu) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message