From owner-svn-src-all@FreeBSD.ORG  Wed Jan 28 18:19:26 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 63736B35;
 Wed, 28 Jan 2015 18:19:26 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5048484E;
 Wed, 28 Jan 2015 18:19:26 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t0SIJQO3073270;
 Wed, 28 Jan 2015 18:19:26 GMT (envelope-from dim@FreeBSD.org)
Received: (from dim@localhost)
 by svn.freebsd.org (8.14.9/8.14.9/Submit) id t0SIJQG4073269;
 Wed, 28 Jan 2015 18:19:26 GMT (envelope-from dim@FreeBSD.org)
Message-Id: <201501281819.t0SIJQG4073269@svn.freebsd.org>
X-Authentication-Warning: svn.freebsd.org: dim set sender to dim@FreeBSD.org
 using -f
From: Dimitry Andric <dim@FreeBSD.org>
Date: Wed, 28 Jan 2015 18:19:26 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r277841 - head/contrib/amd/hlfsd
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2015 18:19:26 -0000

Author: dim
Date: Wed Jan 28 18:19:25 2015
New Revision: 277841
URL: https://svnweb.freebsd.org/changeset/base/277841

Log:
  Fix the following clang 3.6.0 warning in contrib/amd/hlfsd/homedir.c:
  
  contrib/amd/hlfsd/homedir.c:497:8: error: address of array 'buf' will
  always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
    if (!buf || buf[0] == '\0')
        ~^~~
  
  In the affected function, 'buf' is declared as an array of char, so it
  can never be null.  Remove the unecessary check.

Modified:
  head/contrib/amd/hlfsd/homedir.c

Modified: head/contrib/amd/hlfsd/homedir.c
==============================================================================
--- head/contrib/amd/hlfsd/homedir.c	Wed Jan 28 18:13:52 2015	(r277840)
+++ head/contrib/amd/hlfsd/homedir.c	Wed Jan 28 18:19:25 2015	(r277841)
@@ -494,7 +494,7 @@ readent:
   buf[0] = '\0';
   fgets(buf, 256, passwd_fp);
   passwd_line++;
-  if (!buf || buf[0] == '\0')
+  if (buf[0] == '\0')
     goto readent;
 
   /* read user name */