From owner-freebsd-current@FreeBSD.ORG  Tue Jun 30 15:42:01 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 46EEA1065674
	for <freebsd-current@freebsd.org>; Tue, 30 Jun 2009 15:42:01 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id EFAAD8FC12
	for <freebsd-current@freebsd.org>; Tue, 30 Jun 2009 15:42:00 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from phobos.local (pooker.samsco.org [168.103.85.57])
	by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id n5UFFvU5053528;
	Tue, 30 Jun 2009 09:15:58 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <4A4A2C2D.1070404@samsco.org>
Date: Tue, 30 Jun 2009 09:15:57 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9
MIME-Version: 1.0
To: Alan Cox <alc@cs.rice.edu>
References: <200906292005.18629.hselasky@c2i.net>	<4A4907AE.1080303@cs.rice.edu>	<200906292130.16718.hselasky@c2i.net>
	<4A499EFD.9080509@cs.rice.edu>
In-Reply-To: <4A499EFD.9080509@cs.rice.edu>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00
	autolearn=ham version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org
Cc: freebsd-current@freebsd.org, Hans Petter Selasky <hselasky@c2i.net>
Subject: Re: Contigmalloc regression seen on latest 7.x and 8.x branches
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2009 15:42:01 -0000

Alan Cox wrote:
> 
> After looking at r159130 and the comments in the code, I don't think it 
> would be appropriate to remove the printf()s.  However, the logic that 
> determines whether printf() is called is flawed.  I believe that the 
> attached patch should eliminate the incorrect printf()s that you are 
> seeing.
> 

If this fixes the Hans' problem, then I'm quite happy with it going into
the tree.  There another pending busdma fix that I need to handle, so I
can shepherd this one in at the same time if you'd like.

Scott