From owner-freebsd-net@FreeBSD.ORG  Mon Jun 14 22:11:42 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0C6611065674;
	Mon, 14 Jun 2010 22:11:42 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id C299E8FC18;
	Mon, 14 Jun 2010 22:11:41 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 894C673098; Tue, 15 Jun 2010 00:22:27 +0200 (CEST)
Date: Tue, 15 Jun 2010 00:22:27 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Ermal Lu?i <eri@freebsd.org>
Message-ID: <20100614222227.GA98913@onelab2.iet.unipi.it>
References: <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTina6_2EoZOVPWD3pPcJ4FbeDi8eahcHXp-KL-XN@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net <freebsd-net@freebsd.org>, Luigi Rizzo <luigi@freebsd.org>
Subject: Re: [PATCH] ipfw pipe bandwidth parameter parser.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2010 22:11:42 -0000

On Mon, Jun 14, 2010 at 11:01:43PM +0100, Ermal Lu?i wrote:
> Hello,
> 
> on FreeBSD-STABLE at least ipfw wrongly interprets dummynet
> configurations of the type:
> 
> pipe 10 config bw 1.5Mb
>                            ^^^

Given that there is an easy workaround (use bw 1500Kbit/s)
i'd probably just leave it alone, at least for 8.1

I think this behaviour (only accepting integers before the unit)
has been there forever, and is one of the many things broken in
the code that parses bandwidth, sizes and delays.
I am slightly afraid of fixing it because people might have
(broken) configurations relying on undocumented behaviour.

cheers
luigi