From owner-svn-ports-head@freebsd.org Tue Jul 7 09:30:22 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4294AF00; Tue, 7 Jul 2015 09:30:22 +0000 (UTC) (envelope-from vsevolod@FreeBSD.org) Received: from mail.highsecure.ru (mail6.highsecure.ru [IPv6:2a01:4f8:190:43b5::99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 87C821BE7; Tue, 7 Jul 2015 09:30:19 +0000 (UTC) (envelope-from vsevolod@FreeBSD.org) Received: from secret-bunker.localdomain (dhcp-93-196.external.eduroam.ucl.ac.uk [144.82.93.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: vsevolod@highsecure.ru) by mail.highsecure.ru (Postfix) with ESMTPSA id 5D013300056; Tue, 7 Jul 2015 11:30:10 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by secret-bunker.localdomain (Postfix) with ESMTP id C27D15B867E; Tue, 7 Jul 2015 10:30:30 +0100 (BST) Message-ID: <559B9C36.2060300@FreeBSD.org> Date: Tue, 07 Jul 2015 10:30:30 +0100 From: Vsevolod Stakhov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391493 - head/cad/tkgate References: <201507070635.t676Zaqw085725@repo.freebsd.org> In-Reply-To: <201507070635.t676Zaqw085725@repo.freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 09:30:22 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 07/07/2015 07:35, John Marino wrote: > Author: marino Date: Tue Jul 7 06:35:35 2015 New Revision: 391493 > URL: https://svnweb.freebsd.org/changeset/ports/391493 > > Log: cad/tkgate: Unbreak FreeBSD 11, Fix depends on rest > > This was specified on USES: iconv:build,lib > > This is incorrect; the way iconv.mk is written, "build" and "lib" > are mutually exclusive and "build" takes precedence. This means > the library dependency was not registered. > > Moveover, it's failing on FreeBSD 11 and dev-branch of DragonFly > because it uses transliteration. Setting USES=iconv:translit fixes > both issues. > > Approved by: Just fix it Well, from your commit message I can conclude merely that iconv.mk is broken by design. Secondly, I don't understand the meaning of 'translit' option - it is damn confusing name and I cannot see clearly what does it mean in the context of dependencies. Thirdly, isn't it a polite policy to send a notice to a maintainer *before* committing some change to port? I'm not arguing about the change itself, but I do not understand this 'Just fix it policy' when it's absolutely unclear, well at least for me, whether there's a problem with iconv.mk or with the port definition. - -- Vsevolod Stakhov -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJVm5w2AAoJEAdke2eQCBQ3M9oP/2AIw9CH7WVC5/FqUyKTJ+Aq UPPYBbLIY3XXGIK+00CSYaAW0/Etv+xAoODyqMSrpHFyPfRHHlxdFas/BxRvStFf 0/kxMV3XifBHuYhw/+KASytbqpwtr8LAZrthzvN8KrghpCLbESfvxBIy8bXhynMn OIPZ4lNziBmr4sT5ggpz+Ynxd5O3i5ZfaOCVM64IGgSl+PgcZBS8ayPkXzmCUJFd 0otQZK0Vju1lHsV7cshma5iKjDxhmy4Ex+j6L01ZKHXMzVCroLDk9FkmvYyPEbmv frzTKCs9L+0qrCi0WleShXbSqFKDiMfIv8wPJVVT3RxRjVCAhgOmPHxlB/wq3Hp/ yZr5CeLBNfnCqsagg84ok33V4uBTaplErfGFouI+BE3+Ub3Ih4ruiRwjBrgiFLsH kjpkX8ESouOhrhH7nyeqlRlRpTtoSJ1IGg9oR4whZi5hkTSJLIv1BraJkC6R0+3R 86RoucTSEL2fJJAvdRmrfZapjQWKe2tY1t37tOOEaRPse4veG2mT63sJdbiNAup8 dY0Z92XOiigmsqHopBIEDZRgmqS4cSmMFlJk+zA8Hq+Z5HNrjS8M9EyNf+JA5BW4 eb6tyfWKOnJXQiIn9Nknb3aYzi6cGkTHg0QkRSlO40U9UWgFC7dh5qB31oWCPJQh 7EYQ90oRSYm1rsGrrGlg =ShT7 -----END PGP SIGNATURE-----