From owner-cvs-all@FreeBSD.ORG Wed Dec 28 10:15:02 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 821D816A41F; Wed, 28 Dec 2005 10:15:02 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CE2743D49; Wed, 28 Dec 2005 10:15:02 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jBSAF2DE024415; Wed, 28 Dec 2005 10:15:02 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jBSAF2rA024407; Wed, 28 Dec 2005 10:15:02 GMT (envelope-from glebius) Message-Id: <200512281015.jBSAF2rA024407@repoman.freebsd.org> From: Gleb Smirnoff Date: Wed, 28 Dec 2005 10:15:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/cardbus cardbus.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2005 10:15:02 -0000 glebius 2005-12-28 10:15:01 UTC FreeBSD src repository Modified files: sys/dev/cardbus cardbus.c Log: When in rev. 1.47 cardbus_alloc_resources() function was moved from cardbus_cis.c to this file, some code was not merged and thus resource list entries were invalid. They didn't have a resources attached to them. However, the problem was masked for some time later, because newer resources list entries were added to the head of the list, and resource_list_find() always returned the first matching resource list entry. Usually the underlying driver allocated a valid resource and added it to the head of the list, and invalid one wasn't used. In rev. 1.174 of subr_bus.c the sorting of resource list entries was reversed demasking the problem in cardbus_alloc_resources(). This commit fixes the problem returning back some code from cardbus_cis.c, pre-1.49 revisions. PR: kern/87114 PR: kern/90441 Hardware provided by: Vasily Olekhov Reviewed by: imp Revision Changes Path 1.55 +40 -15 src/sys/dev/cardbus/cardbus.c