From owner-p4-projects@FreeBSD.ORG  Sat Jun 12 04:31:05 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DE14E16A4D1; Sat, 12 Jun 2004 04:31:04 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 743B116A4CE
	for <perforce@freebsd.org>; Sat, 12 Jun 2004 04:31:04 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6CD4543D1F
	for <perforce@freebsd.org>; Sat, 12 Jun 2004 04:31:04 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5C4UlRZ051913
	for <perforce@freebsd.org>; Sat, 12 Jun 2004 04:30:47 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5C4UkNS051910
	for perforce@freebsd.org; Sat, 12 Jun 2004 04:30:46 GMT
	(envelope-from marcel@freebsd.org)
Date: Sat, 12 Jun 2004 04:30:46 GMT
Message-Id: <200406120430.i5C4UkNS051910@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 54687 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jun 2004 04:31:05 -0000

http://perforce.freebsd.org/chv.cgi?CH=54687

Change 54687 by marcel@marcel_nfs on 2004/06/12 04:30:17

	The very first kernel dump will be saved as dump 0, not 1.

Affected files ...

.. //depot/projects/gdb/usr.bin/kgdb/main.c#9 edit

Differences ...

==== //depot/projects/gdb/usr.bin/kgdb/main.c#9 (text+ko) ====

@@ -194,6 +194,8 @@
 	int f, nfds, status;
 	int ch;
 
+	dumpnr = -1;
+
 	strlcpy(crashdir, "/var/crash", sizeof(crashdir));
 	s = getenv("KGDB_CRASH_DIR");
 	if (s != NULL)
@@ -206,7 +208,7 @@
 			break;
 		case 'n':
 			dumpnr = strtol(optarg, &s, 0);
-			if (dumpnr == 0 || *s != '\0') {
+			if (dumpnr < 0 || *s != '\0') {
 				warnx("option %c: invalid kernel dump number",
 				    optopt);
 				usage();
@@ -227,7 +229,7 @@
 	if (verbose > 1)
 		warnx("using %s as the crash directory", crashdir);
 
-	if (dumpnr)
+	if (dumpnr >= 0)
 		use_dump(dumpnr);
 
 	if (argc > 0) {