From owner-freebsd-bugs@FreeBSD.ORG  Fri Oct  8 13:20:04 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CFD01065679
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  8 Oct 2010 13:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D41368FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  8 Oct 2010 13:20:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o98DK3we047317
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 8 Oct 2010 13:20:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o98DK3FD047316;
	Fri, 8 Oct 2010 13:20:03 GMT (envelope-from gnats)
Resent-Date: Fri, 8 Oct 2010 13:20:03 GMT
Resent-Message-Id: <201010081320.o98DK3FD047316@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Svatopluk Kraus <onwahe@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E669E106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  8 Oct 2010 13:19:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D53218FC23
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  8 Oct 2010 13:19:59 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o98DJxP6062141
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Oct 2010 13:19:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o98DJxfP062140;
	Fri, 8 Oct 2010 13:19:59 GMT (envelope-from nobody)
Message-Id: <201010081319.o98DJxfP062140@www.freebsd.org>
Date: Fri, 8 Oct 2010 13:19:59 GMT
From: Svatopluk Kraus <onwahe@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/151305: [patch] - CTASSERT(sizeof(struct jmvrec) == JREC_SIZE)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Oct 2010 13:20:04 -0000


>Number:         151305
>Category:       kern
>Synopsis:       [patch] - CTASSERT(sizeof(struct jmvrec) == JREC_SIZE)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 08 13:20:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Svatopluk Kraus
>Release:        current
>Organization:
>Environment:
coldfire port
>Description:
A macro CTASSERT() hits in colfire port I work on. It is possibly due to use of GNU GCC compiler -Os option (size optimalization). It hits on struct jmvrec in sys/ufs/ffs/fs.h.
>How-To-Repeat:

>Fix:
I arranged the struct definition (a size of unused field).

Patch attached with submission follows:

Index: sys/ufs/ffs/fs.h
===================================================================
--- sys/ufs/ffs/fs.h    (revision 213567)
+++ sys/ufs/ffs/fs.h    (working copy)
@@ -696,7 +696,7 @@
        uint32_t        jm_op;
        ino_t           jm_ino;
        ino_t           jm_parent;
-       uint16_t        jm_unused;
+       uint32_t        jm_unused;
        off_t           jm_oldoff;
        off_t           jm_newoff;
 };


>Release-Note:
>Audit-Trail:
>Unformatted: