From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Sep 5 20:10:24 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C51016A4E5 for ; Tue, 5 Sep 2006 20:10:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCE9043D4C for ; Tue, 5 Sep 2006 20:10:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k85KAMRY094948 for ; Tue, 5 Sep 2006 20:10:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k85KAMGV094943; Tue, 5 Sep 2006 20:10:22 GMT (envelope-from gnats) Resent-Date: Tue, 5 Sep 2006 20:10:22 GMT Resent-Message-Id: <200609052010.k85KAMGV094943@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Coleman Kane Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E9B216A4DA for ; Tue, 5 Sep 2006 20:09:52 +0000 (UTC) (envelope-from cokane@mail.cokane.org) Received: from ms-smtp-03.ohiordc.rr.com (ms-smtp-03.ohiordc.rr.com [65.24.5.137]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3848A43D5D for ; Tue, 5 Sep 2006 20:09:51 +0000 (GMT) (envelope-from cokane@mail.cokane.org) Received: from ramen.cokane.org (rrcs-70-62-16-230.central.biz.rr.com [70.62.16.230]) by ms-smtp-03.ohiordc.rr.com (8.13.6/8.13.6) with SMTP id k85K9oga010736 for ; Tue, 5 Sep 2006 16:09:50 -0400 (EDT) Received: (qmail 68973 invoked by uid 1001); 5 Sep 2006 20:09:51 -0000 Message-Id: <20060905200951.68972.qmail@ramen.cokane.org> Date: 5 Sep 2006 20:09:51 -0000 From: Coleman Kane To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/102919: PATCH: net/samba3 and derivatives use wrong gssapi.h header X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Coleman Kane List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2006 20:10:24 -0000 >Number: 102919 >Category: ports >Synopsis: PATCH: net/samba3 and derivatives use wrong gssapi.h header >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 05 20:10:22 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Coleman Kane >Release: FreeBSD 7.0-CURRENT amd64 >Organization: FreeBSD Committers >Environment: System: FreeBSD erwin 7.0-CURRENT FreeBSD 7.0-CURRENT #1: Tue Aug 29 17:10:06 EDT 2006 root@erwin:/usr/obj/usr/src/sys/ERWIN amd64 >Description: I have noticed that the net/samba3, net/samba-libsmbclient and probably other samba3-derived ports complain about #include being deprecated in favor of #include . Since we have the #warning header installed, the auto-search for the "appropriate" gssapi.h (gssapi/gssapi.h) fails to find the correct one, because of the search order. The attached patch reverses part of the search order, so that the correct header takes prescedence over the stub . >How-To-Repeat: Build net/samba3 or net/samba-libsmbclient from ports. >Fix: Attached patch should be put into /usr/ports/net/samba3/files/patch-includes.h: --- include/includes.h.orig Wed Aug 23 12:16:38 2006 +++ include/includes.h Tue Sep 5 15:34:20 2006 @@ -475,10 +475,10 @@ #undef HAVE_LDAP #endif -#if HAVE_GSSAPI_H -#include -#elif HAVE_GSSAPI_GSSAPI_H +#if HAVE_GSSAPI_GSSAPI_H #include +#elif HAVE_GSSAPI_H +#include #elif HAVE_GSSAPI_GSSAPI_GENERIC_H #include #endif >Release-Note: >Audit-Trail: >Unformatted: