From owner-p4-projects@FreeBSD.ORG Mon May 10 09:25:15 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F11B616A4D0; Mon, 10 May 2004 09:25:14 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9904C16A4CE for ; Mon, 10 May 2004 09:25:14 -0700 (PDT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCC2F43D5D for ; Mon, 10 May 2004 09:25:01 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 19477 invoked from network); 10 May 2004 14:50:29 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 10 May 2004 14:50:29 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i4AEoQxO097616; Mon, 10 May 2004 10:50:26 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Mon, 10 May 2004 10:50:51 -0400 User-Agent: KMail/1.6 References: <200405031911.i43JBPk7000313@repoman.freebsd.org> <20040507211416.H51922@root.org> In-Reply-To: <20040507211416.H51922@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200405101050.51751.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Perforce Change Reviews Subject: Re: PERFORCE change 52156 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2004 16:25:15 -0000 On Saturday 08 May 2004 12:15 am, Nate Lawson wrote: > On Mon, 3 May 2004, John Baldwin wrote: > > http://perforce.freebsd.org/chv.cgi?CH=52156 > > > > Change 52156 by jhb@jhb_slimer on 2004/05/03 12:10:39 > > > > Bah, revert accidental submits. Neither of these worked on my > > laptop, though the acpi_video one does work for some people and > > might should be committed. > > > > Affected files ... > > > > .. //depot/projects/power/sys/dev/acpica/acpi_video.c#4 edit > > .. //depot/projects/power/sys/isa/vga_isa.c#5 edit > > The DPMS stuff should go in a different device driver than acpi_video. It > is a MI driver that implements only the standard ACPI interfaces. DPMS is > probed separately and should be in a separate driver. You can have DPMS > without ACPI too. I know. My laptop doesn't have a device that acpi_video attaches to and it needs DPMS. You can see I tried adding it to vga_isa.c and that didn't work either. I have a start on a vgapci(4) driver that would attach to PCI devices that have the right class and subclass. It would then have drm0, agp0 (for Intel onboard graphics), and I guess a dpms0 or vesa0 child device. That's trickier. Partly because the only info I can find on DPMS, is to use the BIOS to do it via vm86, which is very i386-only. Maybe there will be a dpms0 child and the default on x86 can be to attach the VESA version, but chip-specific drivers with a probe of 0 can be written for use on all archs if the DPMS frobbing really is chip specific. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org