From owner-freebsd-current@FreeBSD.ORG  Tue Jun 30 18:39:25 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD6EF106566C
	for <freebsd-current@freebsd.org>; Tue, 30 Jun 2009 18:39:25 +0000 (UTC)
	(envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31])
	by mx1.freebsd.org (Postfix) with ESMTP id A50978FC08
	for <freebsd-current@freebsd.org>; Tue, 30 Jun 2009 18:39:25 +0000 (UTC)
	(envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1])
	by mail.cs.rice.edu (Postfix) with ESMTP id 0AFAD2C2AAC;
	Tue, 30 Jun 2009 13:39:25 -0500 (CDT)
X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu
Received: from mail.cs.rice.edu ([127.0.0.1])
	by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new,
	port 10024)
	with LMTP id 0wKdO+CJ9N0v; Tue, 30 Jun 2009 13:39:17 -0500 (CDT)
Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net
	(adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.cs.rice.edu (Postfix) with ESMTP id 34C9C2C2B58;
	Tue, 30 Jun 2009 13:39:17 -0500 (CDT)
Message-ID: <4A4A5BD4.4040508@cs.rice.edu>
Date: Tue, 30 Jun 2009 13:39:16 -0500
From: Alan Cox <alc@cs.rice.edu>
User-Agent: Thunderbird 2.0.0.22 (X11/20090626)
MIME-Version: 1.0
To: Scott Long <scottl@samsco.org>
References: <200906292005.18629.hselasky@c2i.net>	<4A4907AE.1080303@cs.rice.edu>	<200906292130.16718.hselasky@c2i.net>
	<4A499EFD.9080509@cs.rice.edu> <4A4A2C2D.1070404@samsco.org>
In-Reply-To: <4A4A2C2D.1070404@samsco.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org, Alan Cox <alc@cs.rice.edu>,
	Hans Petter Selasky <hselasky@c2i.net>
Subject: Re: Contigmalloc regression seen on latest 7.x and 8.x branches
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2009 18:39:26 -0000

Scott Long wrote:
> Alan Cox wrote:
>>
>> After looking at r159130 and the comments in the code, I don't think 
>> it would be appropriate to remove the printf()s.  However, the logic 
>> that determines whether printf() is called is flawed.  I believe that 
>> the attached patch should eliminate the incorrect printf()s that you 
>> are seeing.
>>
>
> If this fixes the Hans' problem, then I'm quite happy with it going into
> the tree.  There another pending busdma fix that I need to handle, so I
> can shepherd this one in at the same time if you'd like.

It's all yours.  Thanks,
Alan