From owner-freebsd-ports  Sun Jun  1 23:10:03 1997
Return-Path: <owner-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA29444
          for ports-outgoing; Sun, 1 Jun 1997 23:10:03 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA29438;
          Sun, 1 Jun 1997 23:10:01 -0700 (PDT)
Resent-Date: Sun, 1 Jun 1997 23:10:01 -0700 (PDT)
Resent-Message-Id: <199706020610.XAA29438@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-ports
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, phils@pixelogix.com
Received: from casa.plan.pixelogix.com (pixelogix.com [206.129.248.112])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA28990
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 1 Jun 1997 23:01:16 -0700 (PDT)
Received: (from phils@localhost)
	by casa.plan.pixelogix.com (8.8.5/8.8.5) id XAA09361;
	Sun, 1 Jun 1997 23:00:30 -0700 (PDT)
Message-Id: <199706020600.XAA09361@casa.plan.pixelogix.com>
Date: Sun, 1 Jun 1997 23:00:30 -0700 (PDT)
From: phils@pixelogix.com
Reply-To: phils@pixelogix.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/3754: tcptrace-3.2.5
Sender: owner-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3754
>Category:       ports
>Synopsis:       tcptrace long format causes segmentation fault
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun  1 23:10:00 PDT 1997
>Last-Modified:
>Originator:     Phil Staub
>Organization:
Audio Precision, Inc.
>Release:        FreeBSD 2.2.1-RELEASE i386
>Environment:

	Local ethernet network consisting of multiple 486/Pentium class
	machines connected via NE2000 clone ethernet boards.

	Captured tcpdump file.

>Description:

	When invoked with -l command line switch, tcptrace will segmentation 
	fault in the middle of printing analysis summary.	

>How-To-Repeat:

	Using a file written with tcpdump with the -w option, invoke tcptrace
	with the -l option. Segmentation fault will occur following printing of 
	the SYN/FIN pkts sent line.

>Fix:
	
	Apply the following patch to the file output.c in the source distribution:

*** output.c.orig	Sun Jun  1 22:24:28 1997
--- output.c	Sun Jun  1 22:21:23 1997
***************
*** 261,270 ****
  		       pba->syn_count, pba->fin_count),(int)bufr));
      if (pab->f1323_ws || pba->f1323_ws || pab->f1323_ts || pba->f1323_ts) {
  	StatlineI("req 1323 ws/ts","","%s",
! 		  sprintf(bufl,"%c/%c",
! 			  pab->f1323_ws?'Y':'N',pab->f1323_ts?'Y':'N'),
! 		  sprintf(bufl,"%c/%c",
! 			  pba->f1323_ws?'Y':'N',pba->f1323_ts?'Y':'N'));
      }
      if (pab->f1323_ws || pba->f1323_ws) {
  	StatlineI("adv wind scale","","%d",
--- 261,270 ----
  		       pba->syn_count, pba->fin_count),(int)bufr));
      if (pab->f1323_ws || pba->f1323_ws || pab->f1323_ts || pba->f1323_ts) {
  	StatlineI("req 1323 ws/ts","","%s",
! 		  (sprintf(bufl,"%c/%c",
! 			  pab->f1323_ws?'Y':'N',pab->f1323_ts?'Y':'N'),(int)bufl),
! 		  (sprintf(bufr,"%c/%c",
! 			  pba->f1323_ws?'Y':'N',pba->f1323_ts?'Y':'N'),(int)bufr));
      }
      if (pab->f1323_ws || pba->f1323_ws) {
  	StatlineI("adv wind scale","","%d",







>Audit-Trail:
>Unformatted: