From owner-cvs-all@FreeBSD.ORG Wed Jul 23 10:22:18 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29237106567A; Wed, 23 Jul 2008 10:22:18 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (tarsier.cn.freebsd.org [211.166.10.234]) by mx1.freebsd.org (Postfix) with ESMTP id A69B28FC25; Wed, 23 Jul 2008 10:22:17 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 091512844E; Wed, 23 Jul 2008 18:21:46 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 733ADEBB82C; Wed, 23 Jul 2008 18:21:45 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id TG6LP2NuWNN9; Wed, 23 Jul 2008 18:21:37 +0800 (CST) Received: from charlie.delphij.net (c-69-181-135-56.hsd1.ca.comcast.net [69.181.135.56]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id E1ECDEBB808; Wed, 23 Jul 2008 18:21:35 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=hp0RMrV01dTll6Bp/L6WN4sX1mfmrRWiRQb847Qko2JHB11oB05d7W2sIEZkX76/5 W1WUlOv6b7lEDCp3A2ibQ== Message-ID: <4887062C.2010301@delphij.net> Date: Wed, 23 Jul 2008 03:21:32 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.14 (X11/20080616) MIME-Version: 1.0 To: pav@FreeBSD.org References: <200807230057.m6N0vjdA087753@repoman.freebsd.org> <4886952F.3080705@delphij.net> <1216800133.71570.4.camel@pav.hide.vol.cz> In-Reply-To: <1216800133.71570.4.camel@pav.hide.vol.cz> X-Enigmail-Version: 0.95.6 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------060504000304030103050109" Cc: cvs-ports@FreeBSD.org, d@delphij.net, Roman Bogorodskiy , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/libvmime Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 10:22:18 -0000 This is a multi-part message in MIME format. --------------060504000304030103050109 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Pav Lucistnik wrote: | Xin LI píše v út 22. 07. 2008 v 19:19 -0700: |> -----BEGIN PGP SIGNED MESSAGE----- |> Hash: SHA1 |> |> Pav Lucistnik wrote: |> | pav 2008-07-23 00:57:45 UTC |> | |> | FreeBSD ports repository |> | |> | Modified files: |> | mail/libvmime Makefile |> | Log: |> | - Mark BROKEN: does not compile with gnutls-2.4.x |> |> Er, why, how can we say this version of gnutls is not broken when they |> have this? |> |> ~ typedef enum gnutls_certificate_print_formats |> ~ { |> ~ GNUTLS_CRT_PRINT_FULL, |> ~ GNUTLS_CRT_PRINT_ONELINE, |> ~ GNUTLS_CRT_PRINT_UNSIGNED_FULL, // extra "," |> ~ } gnutls_certificate_print_formats_t; | | I don't mind if it's fixed in libvmime or in gnutls port, as long as it | get fixed. Unfortunately this can *NOT* be fixed in libvmime because gnutls's include file is broken. By making an instance of gnutls_certificate_print_formats_t the compiler would notice the problem immediately. | BTW it's still this way in gnutls git. I have submitted ticket #770 on gnutls trac. Just because it is still in gnutls git does not mean that it is correct. Can we fix the (broken) security/gnutls, rather than mark (the non-broken) libvmime broken? The port works just fine with patched gnutls. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkiHBisACgkQi+vbBBjt66BeTgCeMuPm7Nl9h7zP7wqiAiup0n9O LL4AoMBR/B+nCtjd4meHnE8OklIuKAip =A34Q -----END PGP SIGNATURE----- --------------060504000304030103050109 Content-Type: text/plain; name="patch-gnutls.h.in" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-gnutls.h.in" diff --git a/includes/gnutls/gnutls.h.in b/includes/gnutls/gnutls.h.in index 13d507b..2025cdb 100644 --- a/includes/gnutls/gnutls.h.in +++ b/includes/gnutls/gnutls.h.in @@ -299,7 +299,7 @@ extern "C" { GNUTLS_CRT_PRINT_FULL, GNUTLS_CRT_PRINT_ONELINE, - GNUTLS_CRT_PRINT_UNSIGNED_FULL, + GNUTLS_CRT_PRINT_UNSIGNED_FULL } gnutls_certificate_print_formats_t; typedef enum --------------060504000304030103050109--