From owner-svn-src-head@FreeBSD.ORG  Sat Mar  9 16:58:20 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 3C53E576;
 Sat,  9 Mar 2013 16:58:20 +0000 (UTC)
 (envelope-from davide@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 2F07AFE2;
 Sat,  9 Mar 2013 16:58:20 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r29GwKEt030989;
 Sat, 9 Mar 2013 16:58:20 GMT (envelope-from davide@svn.freebsd.org)
Received: (from davide@localhost)
 by svn.freebsd.org (8.14.6/8.14.5/Submit) id r29GwKaW030988;
 Sat, 9 Mar 2013 16:58:20 GMT (envelope-from davide@svn.freebsd.org)
Message-Id: <201303091658.r29GwKaW030988@svn.freebsd.org>
From: Davide Italiano <davide@FreeBSD.org>
Date: Sat, 9 Mar 2013 16:58:20 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r248109 - head/sys/netsmb
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Mar 2013 16:58:20 -0000

Author: davide
Date: Sat Mar  9 16:58:19 2013
New Revision: 248109
URL: http://svnweb.freebsd.org/changeset/base/248109

Log:
  Call make_dev_credf() rather than using the couple make_dev()/dev_ref().
  This closes a race with clone_cleanup().

Modified:
  head/sys/netsmb/smb_dev.c

Modified: head/sys/netsmb/smb_dev.c
==============================================================================
--- head/sys/netsmb/smb_dev.c	Sat Mar  9 16:11:29 2013	(r248108)
+++ head/sys/netsmb/smb_dev.c	Sat Mar  9 16:58:19 2013	(r248109)
@@ -107,14 +107,9 @@ nsmb_dev_clone(void *arg, struct ucred *
 	else if (dev_stdclone(name, NULL, NSMB_NAME, &u) != 1)
 		return;
 	i = clone_create(&nsmb_clones, &nsmb_cdevsw, &u, dev, 0);
-	if (i) {
-		*dev = make_dev(&nsmb_cdevsw, u, UID_ROOT, GID_WHEEL, 0600,
-		    "%s%d", NSMB_NAME, u);
-		if (*dev != NULL) {
-			dev_ref(*dev);
-			(*dev)->si_flags |= SI_CHEAPCLONE;
-		}
-	}
+	if (i)
+		*dev = make_dev_credf(MAKEDEV_REF, &nsmb_cdevsw, u, cred,
+		    UID_ROOT, GID_WHEEL, 0600, "%s%d", NSMB_NAME, u);
 }
 
 static int