From owner-cvs-all Thu Dec 19 0:18: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D79B37B401; Thu, 19 Dec 2002 00:18:06 -0800 (PST) Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6044643ED8; Thu, 19 Dec 2002 00:18:05 -0800 (PST) (envelope-from k@numeri.campus.luth.se) Received: from numeri.campus.luth.se (localhost [127.0.0.1]) by numeri.campus.luth.se (8.12.6/8.12.6) with ESMTP id gBJ8HvXj035700; Thu, 19 Dec 2002 09:17:57 +0100 (CET) (envelope-from k@numeri.campus.luth.se) Received: (from k@localhost) by numeri.campus.luth.se (8.12.6/8.12.6/Submit) id gBJ8HuwL035699; Thu, 19 Dec 2002 09:17:56 +0100 (CET) Date: Thu, 19 Dec 2002 09:17:56 +0100 From: Johan Karlsson To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/realpath realpath.c Message-ID: <20021219081755.GA35556@numeri.campus.luth.se> References: <200212181020.gBIAKeJw081000@repoman.freebsd.org> <20021219115633.J28208-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021219115633.J28208-100000@gamplex.bde.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Dec 19, 2002 at 12:01 (+1100) +0000, Bruce Evans wrote: > On Wed, 18 Dec 2002, Johan Karlsson wrote: > > > johan 2002/12/18 02:20:40 PST > > > > Modified files: > > bin/realpath realpath.c > > Log: > > - use MAXPATHLEN per realpath(3) > > This is sort of backwards. realpath(3) is standard in POSIX.1.2001 and > spells the limit {PATH_MAX}. MAXPATHLEN has the advantage of being > explictly unportable, but we (mainly imp) usually replace MAXPATHLEN > by PATH_MAX. (The compile-time constant PATH_MAX should not be confused > with the POSIX limit {PATH_MAX} or used if it is not defined, but > MAXPATHLEN is always defined on BSD systems.) My commit made the code consistent with the manpage for realpath(3) which says to use MAXPATHLEN. If that is wrong then we should change the manpage to say PATH_MAX. Should I revert this and change the manpage? /Johan K -- Johan Karlsson mailto:johan@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message