From owner-cvs-src@FreeBSD.ORG Fri Dec 17 16:32:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B095E16A4CF; Fri, 17 Dec 2004 16:32:41 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4760C43D72; Fri, 17 Dec 2004 16:32:41 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) iBHGWeIo023487; Fri, 17 Dec 2004 11:32:40 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id iBHGWeXg023486; Fri, 17 Dec 2004 11:32:40 -0500 (EST) Date: Fri, 17 Dec 2004 11:32:40 -0500 From: Ken Smith To: Darren Reed Message-ID: <20041217163240.GD20065@electra.cse.Buffalo.EDU> References: <200412171559.iBHFxGm1066750@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <200412171559.iBHFxGm1066750@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet ip_nat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2004 16:32:41 -0000 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 17, 2004 at 03:59:16PM +0000, Darren Reed wrote: > darrenr 2004-12-17 15:59:16 UTC >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_5) > sys/contrib/ipfilter/netinet ip_nat.c=20 > Log: > Move two variables that are unused if LARGE_NAT is defined inside an #i= fdef > to keep them out of harms way when compiling. > =20 > PR: 72783 > =20 > Revision Changes Path > 1.34.2.2 +5 -2 src/sys/contrib/ipfilter/netinet/ip_nat.c [ Not meaning to explicitly pick on Darren - just using this particular commit to remind everyone. Several people have done this lately. ] We understand that some of you do extensive testing before committing even to HEAD, and we appreciate that. But even for those cases re@ would appreciate it if things could simmer in HEAD for at least a couple of days before being MFCed. Even the best of us have been caught off guard with things that didn't show up in our testing but once it got out into a larger testbed a nit or two showed up. With RELENG_5 now considered -stable unless there is some sort of emergency please follow the 3-day or so simmer-in-HEAD rule of thumb. Thanks. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (SunOS) iD8DBQFBwwol/G14VSmup/YRAoAcAJ9qAKtkabsfbK8w+OvPpMiOvUqwYQCeOgho UURc2GvtjqRZCkGCgzf8E/4= =0tI2 -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--