From owner-cvs-ports@FreeBSD.ORG  Thu Dec  9 21:41:45 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DDEF116A4CE; Thu,  9 Dec 2004 21:41:45 +0000 (GMT)
Received: from obsecurity.dyndns.org
	(CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.194.102.143])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AB00E43D54; Thu,  9 Dec 2004 21:41:45 +0000 (GMT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id A8AAC5119E; Thu,  9 Dec 2004 13:48:21 -0800 (PST)
Date: Thu, 9 Dec 2004 13:48:21 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Michael Johnson <ahze@ahze.net>
Message-ID: <20041209214821.GA89551@xor.obsecurity.org>
References: <200412091921.iB9JL4F7081024@repoman.freebsd.org>
	<20041209212909.GA89159@xor.obsecurity.org>
	<E81CBD9D-4A29-11D9-80E0-000A958C81C6@ahze.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o"
Content-Disposition: inline
In-Reply-To: <E81CBD9D-4A29-11D9-80E0-000A958C81C6@ahze.net>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: Michael Johnson <ahze@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: ports/math/fftw3 Makefile ports/math/fftw3/files
	patch-alloc.c
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2004 21:41:46 -0000


--IS0zKkzwUGydFO0o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 09, 2004 at 04:33:03PM -0500, Michael Johnson wrote:
>=20
> On Dec 9, 2004, at 4:29 PM, Kris Kennaway wrote:
>=20
> >On Thu, Dec 09, 2004 at 07:21:04PM +0000, Michael Johnson wrote:
> >>ahze        2004-12-09 19:21:04 UTC
> >>
> >>  FreeBSD ports repository
> >>
> >>  Modified files:
> >>    math/fftw3           Makefile
> >>    math/fftw3/files     patch-alloc.c
> >>  Log:
> >>  - Add note about WITH_OPTIMIZED_ATHLON will fall back to 3dNow if=20
> >>you don't have
> >>    a Athlon
> >
> >Why not just use the CPU feature list from <bsd.cpu.mk>, so it
> >automatically DTRT when CPUTYPE is set?
>=20
>=20
> Should I do it like...
>=20
> .if ${CPUTYE}=3D=3D"athlon" || ${CPUTYPE}=3D=3D"athlon-xp" ||=20
> ${CPUTYPE}=3D=3D"k6-3" || ${CPUTYPE}=3D=3D"k6-2" ... etc
> ..code...
> .endif
>=20
> ??

No, see e.g. mpg123

Kris

--IS0zKkzwUGydFO0o
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBuMgkWry0BWjoQKURAhh0AKCYhATMHGVk154tawCzoN4yt5JgKQCeP1T6
Nq/h91KIRcl46aotV9TMYvc=
=JVt1
-----END PGP SIGNATURE-----

--IS0zKkzwUGydFO0o--