From owner-freebsd-current@FreeBSD.ORG  Wed May 14 12:02:16 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 13BA737B401
	for <current@freebsd.org>; Wed, 14 May 2003 12:02:16 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 208D943F3F
	for <current@freebsd.org>; Wed, 14 May 2003 12:02:15 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h4EJ2DYP058989
	for <current@freebsd.org>; Wed, 14 May 2003 21:02:13 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: current@freebsd.org
From: Poul-Henning Kamp <phk@phk.freebsd.dk>
Date: Wed, 14 May 2003 21:02:13 +0200
Message-ID: <58988.1052938933@critter.freebsd.dk>
Subject: Missing break in switch in nfsserver code ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2003 19:02:16 -0000


FlexeLint warned me that there was a switch fall-through here.
Can anybody say if this is intentional, or if a break is missing ?

If it is intentional, we should make it with "/* fall through */"

Poul-Henning

Index: nfsserver/nfs_syscalls.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsserver/nfs_syscalls.c,v
retrieving revision 1.87
diff -u -r1.87 nfs_syscalls.c
--- nfsserver/nfs_syscalls.c	2 Mar 2003 16:54:39 -0000	1.87
+++ nfsserver/nfs_syscalls.c	14 May 2003 19:00:36 -0000
@@ -457,6 +457,7 @@
 			nfsrvstats.srvrpccnt[nd->nd_procnum]++;
 			nfsrv_updatecache(nd, TRUE, mreq);
 			nd->nd_mrep = NULL;
+			/* XXX: missing break ?? */
 		    case RC_REPLY:
 			siz = m_length(mreq, NULL);
 			if (siz <= 0 || siz > NFS_MAXPACKET) {
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.