From owner-svn-src-all@FreeBSD.ORG Wed Oct 13 21:17:15 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B72F106564A; Wed, 13 Oct 2010 21:17:15 +0000 (UTC) (envelope-from rpaulo@freebsd.org) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id E28588FC19; Wed, 13 Oct 2010 21:17:14 +0000 (UTC) Received: from d.earth.lavabit.com (d.earth.lavabit.com [192.168.111.13]) by karen.lavabit.com (Postfix) with ESMTP id 3AE13157557; Wed, 13 Oct 2010 16:17:14 -0500 (CDT) Received: from rui-macbook.lan (bl16-140-224.dsl.telepac.pt [188.81.140.224]) by lavabit.com with ESMTP id ZY7WKUGAGMQ8; Wed, 13 Oct 2010 16:17:14 -0500 References: <201010131439.o9DEdssc090571@svn.freebsd.org> <201010131546.10130.jkim@FreeBSD.org> <201010131703.21145.jkim@FreeBSD.org> In-Reply-To: <201010131703.21145.jkim@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii Message-Id: Content-Transfer-Encoding: quoted-printable From: Rui Paulo Date: Wed, 13 Oct 2010 22:17:10 +0100 To: Jung-uk Kim X-Mailer: Apple Mail (2.1081) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213779 - head/sys/dev/sound/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2010 21:17:15 -0000 On 13 Oct 2010, at 22:03, Jung-uk Kim wrote: > On Wednesday 13 October 2010 04:30 pm, you wrote: >> I read the PR and the mailing list posts, but I don't see what >> problem does "case SPICDS_TYPE_AK4381 || SPICDS_TYPE_AK4396:" fix. >=20 > A similar bug for right channel was fixed by netchild@ in r188480: >=20 > = http://svn.freebsd.org/viewvc/base/head/sys/dev/sound/pci/spicds.c?view=3D= log >=20 > but he missed the left channel, which caused volume differences=20 > between the two channels. >=20 > "In FreeBSD 7.2 it worked just like a charm but after upgrading to 8.0 > the left stereo channel is only half as loud as the right one. It can=20= > be reproduced with either speakers and headphones. I tracked it down=20= > to a change in revision 188480 of spicds.c, the change "fix: stupid=20 > bug with volume control for AK4396" breaks volume control for me. >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010553= html >=20 > Carl Johan Gustavsson submitted a correct patch: >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010558= html >=20 > ariff@ said he would take it but I guess he never did: >=20 > = http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-December/010575= html Oh, I read your previous email backwards. This explains it, thanks. = Guess we can close the PR now. Regards, -- Rui Paulo