From owner-freebsd-i386@FreeBSD.ORG Thu Feb 16 19:10:04 2006 Return-Path: X-Original-To: freebsd-i386@hub.freebsd.org Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB5F716A420 for ; Thu, 16 Feb 2006 19:10:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C72C43D4C for ; Thu, 16 Feb 2006 19:10:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1GJA4o4058790 for ; Thu, 16 Feb 2006 19:10:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1GJA4BX058789; Thu, 16 Feb 2006 19:10:04 GMT (envelope-from gnats) Resent-Date: Thu, 16 Feb 2006 19:10:04 GMT Resent-Message-Id: <200602161910.k1GJA4BX058789@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-i386@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Webster Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3C7516A420 for ; Thu, 16 Feb 2006 19:03:56 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92B6143D49 for ; Thu, 16 Feb 2006 19:03:56 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k1GJ3uOg092725 for ; Thu, 16 Feb 2006 19:03:56 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k1GJ3uaQ092723; Thu, 16 Feb 2006 19:03:56 GMT (envelope-from nobody) Message-Id: <200602161903.k1GJ3uaQ092723@www.freebsd.org> Date: Thu, 16 Feb 2006 19:03:56 GMT From: Andrew Webster To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: i386/93448: CARP advskew not propagated to VRRP packets X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2006 19:10:05 -0000 >Number: 93448 >Category: i386 >Synopsis: CARP advskew not propagated to VRRP packets >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-i386 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 16 19:10:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Andrew Webster >Release: 5.4p8 >Organization: ConnecTalk Inc. >Environment: FreeBSD carp1.connectalk.com 5.4-RELEASE-p8 FreeBSD 5.4-RELEASE-p8 #0: Tue Dec 20 11:39:40 EST 2005 root@serialtest.connectalk.com:/usr/src/sys/i386/compile/CARP i386 >Description: Carp advskew values of < 240 are ignored and set to 240. Carp interface configured as follows: # ifconfig em1 em1: flags=8943 mtu 1500 options=b inet6 fe80::20c:29ff:fef1:9f4c%em1 prefixlen 64 scopeid 0x2 inet 10.10.1.2 netmask 0xffffff00 broadcast 10.10.1.255 ether 00:0c:29:f1:9f:4c media: Ethernet autoselect (1000baseTX ) status: active # ifconfig carp0 carp0: flags=41 mtu 1500 inet 10.10.1.1 netmask 0xffffff00 carp: MASTER vhid 10 advbase 1 advskew 1 # tcpdump -n -i em1 13:58:14.738030 IP 10.10.1.2 > 224.0.0.18: VRRPv2, Advertisement, vrid 10, prio 240, authtype none, intvl 1s, length 36 13:58:16.687548 IP 10.10.1.2 > 224.0.0.18: VRRPv2, Advertisement, vrid 10, prio 240, authtype none, intvl 1s, length 36 Notice prio is 240, not 1. If set to > 240, then it follows. # ifconfig carp0 advskew 242 # tcpdump -n -i em1 13:59:07.529908 IP 10.10.1.2 > 224.0.0.18: VRRPv2, Advertisement, vrid 10, prio 242, authtype none, intvl 1s, length 36 13:59:09.488462 IP 10.10.1.2 > 224.0.0.18: VRRPv2, Advertisement, vrid 10, prio 242, authtype none, intvl 1s, length 36 Now it is 242. >How-To-Repeat: # ifconfig em1 10.10.1.2/24 # ifconfig carp0 create # ifconfig carp0 vhid 10 advbase 1 advskew 1 # ifconfig carp0 10.10.1.1/24 # ifconfig carp0 up # tcpdump -n -i em1 >Fix: Looks like carp_suppress_preempt is being incorrectly set to true. Perhaps in static void carp_sc_state_locked(struct carp_softc *sc) Actual fix ? >Release-Note: >Audit-Trail: >Unformatted: