From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Nov 16 23:10:00 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D54758A1 for ; Fri, 16 Nov 2012 23:10:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id A778D8FC1C for ; Fri, 16 Nov 2012 23:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAGNA0mD033393 for ; Fri, 16 Nov 2012 23:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAGNA0WO033392; Fri, 16 Nov 2012 23:10:00 GMT (envelope-from gnats) Resent-Date: Fri, 16 Nov 2012 23:10:00 GMT Resent-Message-Id: <201211162310.qAGNA0WO033392@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Wollman Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7783382B for ; Fri, 16 Nov 2012 23:01:22 +0000 (UTC) (envelope-from wollman@xyz.csail.mit.edu) Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu [IPv6:2001:470:8b2d:1e1c:21b:21ff:feb8:d7b0]) by mx1.freebsd.org (Postfix) with ESMTP id 30E058FC08 for ; Fri, 16 Nov 2012 23:01:22 +0000 (UTC) Received: from xyz.csail.mit.edu (xyz.csail.mit.edu [128.31.0.28]) by khavrinen.csail.mit.edu (8.14.5/8.14.5) with ESMTP id qAGN1KFa096338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO CN= issuer=) for ; Fri, 16 Nov 2012 18:01:20 -0500 (EST) (envelope-from wollman@xyz.csail.mit.edu) Received: (from wollman@localhost) by xyz.csail.mit.edu (8.14.5/8.14.5/Submit) id qAGN1KLn086065; Fri, 16 Nov 2012 18:01:20 -0500 (EST) (envelope-from wollman) Message-Id: <201211162301.qAGN1KLn086065@xyz.csail.mit.edu> Date: Fri, 16 Nov 2012 18:01:20 -0500 (EST) From: Garrett Wollman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/173669: textproc/augeas: shellvars can't parse loader.conf X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Nov 2012 23:10:01 -0000 >Number: 173669 >Category: ports >Synopsis: textproc/augeas: shellvars can't parse loader.conf >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 16 23:10:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Wollman >Release: FreeBSD 9.1-RC3 amd64 >Organization: MIT Computer Science & Artificial Intelligence Lab >Environment: System: FreeBSD xyz.csail.mit.edu 9.1-RC3 FreeBSD 9.1-RC3 #14 r242372M: Thu Nov 1 01:12:44 EDT 2012 wollman@xyz.csail.mit.edu:/usr/obj/usr/src/sys/CSAIL amd64 >Description: textproc/augeas includes a patch to shellvars.aug that make it claim to support /boot/loader.conf. However, loader.conf allows setting kernel environment variables, which often have dots in them, and the regular expression in shellvars.aug won't match on these lines, causing the parse to fail and augeas to be unable to edit the file. >How-To-Repeat: Define any kernel environment variable, like kern.hwpmc.nsamples, in /boot/loader.conf. In augtool, run "print /augeas/files/boot/loader.conf" and get back: /augeas/files/boot/loader.conf /augeas/files/boot/loader.conf/path = "/files/boot/loader.conf" /augeas/files/boot/loader.conf/mtime = "1351131615" /augeas/files/boot/loader.conf/lens = "@Shellvars" /augeas/files/boot/loader.conf/lens/info = "/usr/local/share/augeas/lenses/dist/shellvars.aug:138.12-.89:" /augeas/files/boot/loader.conf/error = "parse_failed" /augeas/files/boot/loader.conf/error/pos = "90" /augeas/files/boot/loader.conf/error/line = "5" /augeas/files/boot/loader.conf/error/char = "0" /augeas/files/boot/loader.conf/error/lens = "/usr/local/share/augeas/lenses/dist/shellvars.aug:138.12-.89:" /augeas/files/boot/loader.conf/error/message = "Syntax error" >Fix: Fork a new lens that's like shellvars but includes "." in the character class for key names, and let it take over /boot/loader.conf. (You could also remove support for "export" and "unset" keywords.) >Release-Note: >Audit-Trail: >Unformatted: