From owner-cvs-ports@FreeBSD.ORG Fri Aug 5 02:11:28 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA355106564A; Fri, 5 Aug 2011 02:11:28 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from sunpoet.net (sunpoet.net [220.133.12.240]) by mx1.freebsd.org (Postfix) with ESMTP id 8CF6D8FC12; Fri, 5 Aug 2011 02:11:28 +0000 (UTC) Received: by sunpoet.net (Postfix, from userid 1000) id 2C1EF3EF1; Fri, 5 Aug 2011 10:10:29 +0800 (CST) Date: Fri, 5 Aug 2011 10:10:29 +0800 From: Sunpoet Po-Chuan Hsieh To: Brendan Fabeny Message-ID: <20110805021028.GD12696@bonjour.sunpoet.net> References: <201108042336.p74NaqwG020915@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201108042336.p74NaqwG020915@repoman.freebsd.org> Organization: The FreeBSD Project User-Agent: Mutt/1.5.21 (2010-09-15) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/youtube_dl Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2011 02:11:28 -0000 On Thu, Aug 04, 2011 at 11:36:52PM +0000, Brendan Fabeny wrote: > bf 2011-08-04 23:36:52 UTC > > FreeBSD ports repository > > Modified files: > www/youtube_dl Makefile distinfo > Log: > update to 2011-08-04 > > Approved by: araujo > > Revision Changes Path > 1.58 +3 -3 ports/www/youtube_dl/Makefile > 1.48 +2 -2 ports/www/youtube_dl/distinfo Hi, I noticed that you change ${DISTDIR}/${DIST_SUBDIR} to ${_DISTDIR}. IMHO, it would be better not to use _foo variables as they are named for internal use. Thanks. - sunpoet