From owner-svn-ports-head@FreeBSD.ORG Tue Jan 20 08:40:38 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9CB074BA; Tue, 20 Jan 2015 08:40:38 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF8C69FA; Tue, 20 Jan 2015 08:40:37 +0000 (UTC) Received: from [192.168.192.65] (67-0-108-129.albq.qwest.net [67.0.108.129]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 3D6B41140E8; Tue, 20 Jan 2015 01:40:31 -0700 (MST) References: <201501200412.t0K4CVOj052563@svn.freebsd.org> <20150120081220.GB57237@FreeBSD.org> <54BE0F14.5030304@marino.st> <20150120082846.GA84520@FreeBSD.org> Mime-Version: 1.0 (1.0) In-Reply-To: <20150120082846.GA84520@FreeBSD.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <7FE7D759-28BD-4A85-AE0D-83B163FDC7FB@adamw.org> X-Mailer: iPad Mail (12B440) From: Adam Weinberger Subject: Re: svn commit: r377495 - head/textproc/py-pygments Date: Tue, 20 Jan 2015 01:40:31 -0700 To: Alexey Dokuchaev Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "marino@freebsd.org" , Adam Weinberger , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 08:40:38 -0000 > On Jan 20, 2015, at 01:28, Alexey Dokuchaev wrote: >=20 >> On Tue, Jan 20, 2015 at 09:17:24AM +0100, John Marino wrote: >>> On 1/20/2015 09:12, Alexey Dokuchaev wrote: >>>> On Tue, Jan 20, 2015 at 04:12:31AM +0000, Adam Weinberger wrote: >>>> New Revision: 377495 >>>> URL: https://svnweb.freebsd.org/changeset/ports/377495 >>>> QAT: https://qat.redports.org/buildarchive/r377495/ >>>>=20 >>>> Log: >>>> Update to 2.0.1. >>>>=20 >>>> [...] >>>> -OPTIONS_DEFINE=3D DOCS >>>> - >>>=20 >>> Commit log does not mention this change, was it intended? If so, what >>> was the reason behind it? >>=20 >> The line is redundant -- it's presence or absence doesn't change >> anything. >=20 > In this case it would be nice to mention something like "remove DOCS optio= n > because the port no longer installs documentation" in the log. >=20 >> You know how I write commit messages and thus know I agree it >> could have been mentioned given how short the message was (if it were 1 >> of 100 changes I wouldn't have mentioned it myself). >=20 > Yes, I know. >=20 > ./danfe >=20 Yes, you're both correct. I'm not usually a terse commit message person, and= it was doubly bad given that I was doing the commit without nivit's approva= l.=20 # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org=