From owner-freebsd-net@FreeBSD.ORG Fri May 28 03:10:10 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB9A616A4CE; Fri, 28 May 2004 03:10:10 -0700 (PDT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04D5943D31; Fri, 28 May 2004 03:10:10 -0700 (PDT) (envelope-from glebius@cell.sick.ru) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.9/8.12.8) with ESMTP id i4SA9Evw043283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 May 2004 14:09:15 +0400 (MSD) (envelope-from glebius@cell.sick.ru) Received: (from glebius@localhost) by cell.sick.ru (8.12.9/8.12.6/Submit) id i4SA9EIP043282; Fri, 28 May 2004 14:09:14 +0400 (MSD) Date: Fri, 28 May 2004 14:09:14 +0400 From: Gleb Smirnoff To: Julian Elischer Message-ID: <20040528100914.GA43187@cell.sick.ru> Mail-Followup-To: Gleb Smirnoff , Julian Elischer , Harti Brandt , freebsd-net@freebsd.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: freebsd-net@freebsd.org cc: Harti Brandt Subject: Re: shutdown node VS disconnect all hooks X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2004 10:10:10 -0000 On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: J> > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that J> > JE>> case could you please convert the initialisation of the typestructs J> > JE>> to use C99 sparse initialisation? In that case future changes will be a good J> > JE>> deal easier. J> > JE> J> > JE>actually I don't know if you do need to edit the nodes J> > JE>types.. At one time it was true that unassigned elements on J> > JE>the end will be NULL. J> > J> > Sure they will, but this will confuse the next one who is adding J> > a new operation. I was just thinking: 'In the case that Gleb has nothing J> > else to do he could as well just take the chance...' :-) J> J> He seems to have taken the bait J> (heh heh) J> J> It'd be best to make the change to sparse initialisers a separate patch J> that I cold commit separatly, J> so reduce teh size of the functionality change patch. J> J> (or harti could commit it.., or ruslan) Agreed. I make a series of patches then :) Here is the first one - convert all ng_type initializers to C99 sparse type. AFAIK, we also have two netgraph ports. Adding of preshutdown method will break them. I'll fix ng_netflow port, and notify maintainer of ng_daphne. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE