From owner-cvs-doc@FreeBSD.ORG  Thu Sep 25 09:41:32 2003
Return-Path: <owner-cvs-doc@FreeBSD.ORG>
Delivered-To: cvs-doc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2970D16A4B3; Thu, 25 Sep 2003 09:41:32 -0700 (PDT)
Received: from abigail.blackend.org (blackend.org [212.11.35.229])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8FFB84401A; Thu, 25 Sep 2003 09:41:27 -0700 (PDT)
	(envelope-from marc@blackend.org)
Received: from nosferatu.blackend.org (nosferatu.blackend.org
	[192.168.10.205])
	by abigail.blackend.org (8.12.9/8.12.3) with ESMTP id h8PGf7Td034377;
	Thu, 25 Sep 2003 18:41:07 +0200 (CEST)
	(envelope-from marc@abigail.blackend.org)
Received: from nosferatu.blackend.org (localhost [127.0.0.1])
	h8PGeERE004897;	Thu, 25 Sep 2003 18:40:14 +0200 (CEST)
	(envelope-from marc@nosferatu.blackend.org)
Received: (from marc@localhost)
	by nosferatu.blackend.org (8.12.9/8.12.9/Submit) id h8PGeD7B004896;
	Thu, 25 Sep 2003 18:40:13 +0200 (CEST)
	(envelope-from marc)
Date: Thu, 25 Sep 2003 18:40:13 +0200
From: Marc Fonvieille <blackend@FreeBSD.org>
To: Ken Smith <kensmith@cse.Buffalo.EDU>
Message-ID: <20030925164013.GB574@nosferatu.blackend.org>
References: <200309251252.h8PCq7Tc093693@repoman.freebsd.org>
	<20030925152525.GA410@daemon.li>
	<20030925162427.GA12579@electra.cse.Buffalo.EDU>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030925162427.GA12579@electra.cse.Buffalo.EDU>
User-Agent: Mutt/1.4i
X-Useless-Header: blackend.org
X-Operating-System: FreeBSD 5.1-CURRENT
cc: cvs-all@FreeBSD.org
cc: doc-committers@FreeBSD.org
cc: cvs-doc@FreeBSD.org
cc: Ken Smith <kensmith@FreeBSD.org>
cc: Josef El-Rayes <j.el-rayes@daemon.li>
Subject: Re: cvs commit:
	doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml
X-BeenThere: cvs-doc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the doc and www trees <cvs-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-doc>
List-Post: <mailto:cvs-doc@freebsd.org>
List-Help: <mailto:cvs-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2003 16:41:32 -0000

On Thu, Sep 25, 2003 at 12:24:28PM -0400, Ken Smith wrote:
> > is there a special reason why we do this here?
> 
> In this case there is a special reason - the whitespace adjustments
> are visible to the users.  I was adjusting whitespace inside of
> a program example.  Someone else mentioned this as well, I was
> making it style(9) compliant.  IMO if the people who watch over
> the source code commits are going to "insist" on style(9) compliance
> we should make an effort for the examples in the online documentation
> to also be style(9) compliant.
> 
> Should I phrase the commit log message in a different way if this
> sort of thing happens again?  Strictly speaking because the whitespace
> changes are visible in the end result you could consider this a real
> functional change.  People tend to associate "whitespace change"
> with "will be eaten by the SGML processors and makes no visible
> change in the end result" but in cases like this that is not the case.
>

You were explicit enough IMHO in your log message.
Heh no one noted you tested the driver code on a shinny sparc64! :))

Marc