From owner-svn-ports-all@freebsd.org Sun Jul 26 10:56:59 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86DD09A7F0F; Sun, 26 Jul 2015 10:56:59 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from fep26.mx.upcmail.net (fep26.mx.upcmail.net [62.179.121.46]) by mx1.freebsd.org (Postfix) with ESMTP id 11F75D7B; Sun, 26 Jul 2015 10:56:56 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from edge03.upcmail.net ([192.168.13.238]) by viefep20-int.chello.at (InterMail vM.8.01.05.13 201-2260-151-135-20130320) with ESMTP id <20150726104034.EHPU7850.viefep20-int.chello.at@edge03.upcmail.net>; Sun, 26 Jul 2015 12:40:34 +0200 Received: from [192.168.0.23] ([178.84.134.112]) by edge03.upcmail.net with edge id wygZ1q0092Rg3Ey01ygZJX; Sun, 26 Jul 2015 12:40:34 +0200 X-SourceIP: 178.84.134.112 Subject: Re: svn commit: r392902 - in head/multimedia: . gstreamer1-plugins gstreamer1-plugins-hls To: Tijl Coosemans References: <201507251959.t6PJxau6007387@repo.freebsd.org> <55B3FC33.4000903@rainbow-runner.nl> <20150726123658.08667f6f@kalimero.tijl.coosemans.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, antoine@freebsd.org From: Koop Mast Message-ID: <55B4B91A.2040900@rainbow-runner.nl> Date: Sun, 26 Jul 2015 12:40:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150726123658.08667f6f@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 10:56:59 -0000 On 26-7-2015 12:36, Tijl Coosemans wrote: > On Sat, 25 Jul 2015 23:14:27 +0200 Koop Mast wrote: >> On 25-7-2015 21:59, Tijl Coosemans wrote: >>> --- head/multimedia/gstreamer1-plugins/Makefile Sat Jul 25 17:11:37 2015 (r392901) >>> +++ head/multimedia/gstreamer1-plugins/Makefile Sat Jul 25 19:59:35 2015 (r392902) >>> @@ -147,20 +147,8 @@ post-patch: >>> s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-@GST_API_VERSION@.la|-lgstbasevideo-${VERSION}|; \ >>> s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-@GST_API_VERSION@.la|-lgstvideo-${VERSION}|; \ >>> s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-@GST_API_VERSION@.la|-lgstbadbase-${VERSION}|; \ >>> + s|$$(top_builddir)/gst-libs/gst/uridownloader/libgsturidownloader-@GST_API_VERSION@.la|-lgsturidownloader-${VERSION}|; \ >>> s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-@GST_API_VERSION@.la|-lgstbadvideo-${VERSION}|' >>> - >>> - @${FIND} ${WRKSRC}/ext ${WRKSRC}/sys -name Makefile.in | \ >>> - ${XARGS} -n 10 ${REINPLACE_CMD} -e \ >>> - '/la_DEPENDENCIES/,/am__DEPENDENCIES/s,$$(top_builddir)/gst-libs/.*.la,,' -e \ >>> - 's|$$(top_builddir)/gst-libs/gst/tag/libgsttag-$$(GST_API_VERSION).la|-lgsttag-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/audio/libgstaudio-$$(GST_API_VERSION).la|-lgstaudio-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/pbutils/libgstpbutils-$$(GST_API_VERSION).la|-lgstpbutils-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/riff/libgstriff-$$(GST_API_VERSION).la|-lgstriff-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/signalprocessor/libgstsignalprocessor-$$(GST_API_VERSION).la|-lgstsignalprocessor-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-$$(GST_API_VERSION).la|-lgstbasevideo-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-$$(GST_API_VERSION).la|-lgstvideo-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-$$(GST_API_VERSION).la|-lgstbadbase-${VERSION}|; \ >>> - s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-$$(GST_API_VERSION).la|-lgstbadvideo-${VERSION}|' >>> .endif >> Just making sure, have you tested this change? Because the last time I >> looked it was still needed. Note the difference between >> $$(GST_API_VERSION) and @GST_API_VERSION@ > Oops, I've combined both into one RE now in r392917. Thanks, and thanks for reducing the blob into something that is more clean. Though now I need a almanac to figure out what the regex does but I guess that is a small price to pay. -Koop