From owner-freebsd-ports@FreeBSD.ORG Tue Mar 20 03:44:52 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id D88FD1065670; Tue, 20 Mar 2012 03:44:52 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 2FA3F1500B3; Tue, 20 Mar 2012 03:44:52 +0000 (UTC) Message-ID: <4F67FD38.7010006@FreeBSD.org> Date: Mon, 19 Mar 2012 20:44:56 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: Ade Lovett References: <20120319075901.GA16256@snail.casa> <4F67BE27.7030400@FreeBSD.org> <4F67C74D.2080906@FreeBSD.org> In-Reply-To: <4F67C74D.2080906@FreeBSD.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@freebsd.org Subject: Re: [PATCH] proposal for x11-wm/windowmaker X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 03:44:52 -0000 On 3/19/2012 4:54 PM, Ade Lovett wrote: > On 3/19/2012 16:15, Doug Barton wrote: >> On 3/19/2012 12:59 AM, Arrigo Marchiori wrote: >>> Hello, >>> >>> I am attaching a "quick-and-dirty" patch that should reallow >>> compilation of x11-wm/windowmaker under 7-STABLE. >>> >>> The problem seems to be the missing macro HAVE_SYS_SELECT_H; the patch >>> just forces it in the configure script if a FreeBSD system is >>> detected. >> >> I'm not opposed to adding that if someone can confirm that it allows >> WindowMaker to compile on 7-stable. > > Since it's for 7-stable only (apparently), it would be better off > wrapped in an OSVERSION check to make things abundantly clear as to why > it's being done. Yes, I was planning to do that, but thanks for the suggestion in any case. -- This .signature sanitized for your protection