From owner-svn-src-all@freebsd.org Wed Mar 23 01:33:53 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 476DBA928E6; Wed, 23 Mar 2016 01:33:53 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F1A31EB2; Wed, 23 Mar 2016 01:33:52 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lgwl-lstewart2.corp.netflix.com (c110-22-60-167.eburwd6.vic.optusnet.com.au [110.22.60.167]) by lauren.room52.net (Postfix) with ESMTPSA id 39D387E88D; Wed, 23 Mar 2016 12:26:40 +1100 (EST) Subject: Re: svn commit: r297193 - head/sys/netinet To: cem@freebsd.org, "Jonathan T. Looney" References: <201603221555.u2MFtHgt068663@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Lawrence Stewart X-Enigmail-Draft-Status: N1110 Message-ID: <56F1F02F.2090900@freebsd.org> Date: Wed, 23 Mar 2016 12:23:59 +1100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DNS_FROM_AHBL_RHSBL, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lauren.room52.net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 01:33:53 -0000 On 03/23/16 10:59, Conrad Meyer wrote: > On Tue, Mar 22, 2016 at 8:55 AM, Jonathan T. Looney wrote: >> Author: jtl >> Date: Tue Mar 22 15:55:17 2016 >> New Revision: 297193 >> URL: https://svnweb.freebsd.org/changeset/base/297193 >> >> ... >> >> MFC after: 2 weeks > > This change seems like it would be ineligible for a MFC due to > changing the ABI of struct tcpopt. Off the top of my head I can't think of why you would consider struct tcpopt to be part of the ABI. Can you point to any concrete examples demonstrating that it is either explicitly or in a defacto sense? Cheers, Lawrence