From owner-freebsd-stable  Sun Oct 13 14:23:16 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3F49B37B401; Sun, 13 Oct 2002 14:23:14 -0700 (PDT)
Received: from pimout3-ext.prodigy.net (pimout3-ext.prodigy.net [207.115.63.102])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6CC3443E7B; Sun, 13 Oct 2002 14:23:12 -0700 (PDT)
	(envelope-from kbyanc@posi.net)
Received: from gateway.posi.net (adsl-63-201-89-88.dsl.snfc21.pacbell.net [63.201.89.88])
	by pimout3-ext.prodigy.net (8.12.3 da nor stuldap/8.12.3) with ESMTP id g9DLN6ne501208;
	Sun, 13 Oct 2002 17:23:07 -0400
Received: from localhost (localhost [127.0.0.1])
	by gateway.posi.net (8.12.5/8.12.5) with ESMTP id g9DLMqRd060303;
	Sun, 13 Oct 2002 14:22:53 -0700 (PDT)
	(envelope-from kbyanc@posi.net)
Date: Sun, 13 Oct 2002 14:22:52 -0700 (PDT)
From: Kelly Yancey <kbyanc@posi.net>
To: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at>
Cc: Dmitry Morozovsky <marck@rinet.ru>,
	Kelly Yancey <kbyanc@FreeBSD.org>, <stable@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
In-Reply-To: <20021013154055.GA265@frog.fafoe>
Message-ID: <20021013142231.U60301-100000@gateway.posi.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

On Sun, 13 Oct 2002, Stefan Farfeleder wrote:

> On Sun, Oct 13, 2002 at 07:22:17PM +0400, Dmitry Morozovsky wrote:
> > On Sun, 13 Oct 2002, Dmitry Morozovsky wrote:
> >
> > DM> On Sun, 13 Oct 2002, Kelly Yancey wrote:
> > DM>
> > DM> KY> kbyanc      2002/10/13 00:38:41 PDT
> > DM> KY>
> > DM> KY>   Modified files:        (Branch: RELENG_4)
> > DM> KY>     sys/kern             vfs_subr.c
> > DM> KY>   Log:
> > DM> KY>   Use <sys/queue.h> macros rather than fondling implementation details.
> > DM>
> > DM> Kelly, it seems this commit broke -stable (see PR/44007)
> >
> > ... and I can confirm that backing out this change revert -stable to working
> >
> > (patch for band-aiding follows)
> >
> > Index: sys/kern/vfs_subr.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
> > retrieving revision 1.249.2.28
> > diff -u -r1.249.2.28 vfs_subr.c
> > --- sys/kern/vfs_subr.c 13 Oct 2002 07:38:41 -0000      1.249.2.28
> > +++ sys/kern/vfs_subr.c 13 Oct 2002 15:17:55 -0000
> > @@ -1256,7 +1256,7 @@
> >         KASSERT(bp->b_vp != NULL, ("pbrelvp: NULL"));
> >
> >         /* XXX REMOVE ME */
> > -       if (!TAILQ_NEXT(bp, b_vnbufs)) {
> > +       if (bp->b_vnbufs.tqe_next != NULL) {
> >                 panic(
> >                     "relpbuf(): b_vp was probably reassignbuf()d %p %x",
> >                     bp,
> >
> >
>
> The line should probably read:
>
> if (TAILQ_NEXT(bp, b_vnbufs) != NULL) {
>

  Yeah, I inverted the sense.  Sorry.

  Kelly

--
Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org}
Join distributed.net Team FreeBSD: http://www.posi.net/freebsd/Team-FreeBSD/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message