From owner-svn-src-all@freebsd.org Wed Mar 23 01:54:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B6A6A92E81 for ; Wed, 23 Mar 2016 01:54:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 425C41A37 for ; Wed, 23 Mar 2016 01:54:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x235.google.com with SMTP id 124so9500522iov.3 for ; Tue, 22 Mar 2016 18:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=3fcuf+vRglK20oRDuA7veT7yg6PxRyy4X+1/h3zEWLQ=; b=X1JFMfWvJUz84PZxZjHhMkThnFf9fATPRN/s9dc/SWuzotKjjxgp0Y1LWaNpgeIGjv XuMcELQGulDYu7mtYv9/iiJH6ig5TO0ZTC/VHNRby3uGY0A6iyeyUoSKMj+vZhk39Bve XiNT16paBMl7qyBXj2Di185hURyexe6PM6vPmzLs4eAGpARZfPW6imlT5p/agxjIMY5q QhoWt810jl7nfEJTSKMOnNzX7zQLRkNRIxex3EWqcYkYIgabNxXTmc/WCOT9AZNWbFsg clrP68dXpvfHtqfmL8FMQG2YfAlFdPfWtKlXJ5o+xhWU57ICt/l8WytI2xJmeEjIgc6J /VFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=3fcuf+vRglK20oRDuA7veT7yg6PxRyy4X+1/h3zEWLQ=; b=BZk8cnzCLMzSmXA2E853G48mNgxguP+P6nQ512a9Mkso3JzOEpnSHKc0I7xVkOvs50 20SAFdBW/K+fy1MijiFfL0tKQl1I4WavS2kNuKpEFDDZGbhal5eY4cphOauMkGfJKDY3 wE4mdpleBanPRVsA64dSLywyfnQEz6rT2eDbm2KY/dXjsqlcvmC+AaUpTpCuLqpa49G8 s/iuEPQwsvxYxRYUw/bX8U89GxuJ3LsCY5wcwdtU3AkjJRDyV8cW1widN5lcE9LJfCt2 edhdojdVFIT5a0s8oUSN7mIjHm207q8dWWL7nCEGrYEFd8E+K+jo8DQqFC5KFapqNbaI 7ewQ== X-Gm-Message-State: AD7BkJJmPEwUV1TPSE7bG/WKE8UsSSd8d8ZYbjN4uNGNJ4qsE68q0Vf3iWRftnPAw0s8PnT1hdPLOD1o/HRRuA== MIME-Version: 1.0 X-Received: by 10.107.14.209 with SMTP id 200mr672020ioo.73.1458698067805; Tue, 22 Mar 2016 18:54:27 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.36.65.230 with HTTP; Tue, 22 Mar 2016 18:54:27 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <1458697825.1091.28.camel@freebsd.org> References: <201603221346.u2MDk1XH029623@repo.freebsd.org> <1458662141.1091.16.camel@freebsd.org> <1614105839.27686393.1458695637184.JavaMail.zimbra@uoguelph.ca> <1458697825.1091.28.camel@freebsd.org> Date: Tue, 22 Mar 2016 19:54:27 -0600 X-Google-Sender-Auth: pRqxojS9dSuTTfIwkBEDGcHD-Uo Message-ID: Subject: Re: svn commit: r297190 - head/sys/kern From: Warner Losh To: Ian Lepore Cc: Rick Macklem , Edward Tomasz Napierala , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 01:54:28 -0000 On Tue, Mar 22, 2016 at 7:50 PM, Ian Lepore wrote: > On Tue, 2016-03-22 at 19:28 -0600, Warner Losh wrote: > > On Tue, Mar 22, 2016 at 7:13 PM, Rick Macklem > > wrote: > > > > > Ian Lepore wrote: > > > > On Tue, 2016-03-22 at 13:46 +0000, Edward Tomasz Napierala wrote: > > > > > Author: trasz > > > > > Date: Tue Mar 22 13:46:01 2016 > > > > > New Revision: 297190 > > > > > URL: https://svnweb.freebsd.org/changeset/base/297190 > > > > > > > > > > Log: > > > > > Wait for root mount tokens before showing the root mount > > > > > prompt. > > > > > This restores the pre-r290196 behaviour, eliminating the need > > > > > to > > > manually > > > > > press '.' a couple of times to get USB to finish probing. > > > > > > > > > > Note that there's still something wrong with the console > > > > > (character > > > > > echoing doesn't quite work), and there's also a reported > > > > > problem with > > > > > BHyVe, but those two don't seem related to the problem above. > > > > > > > > Just a datapoint on the echoing... it works fine on a serial > > > > console, > > > > it's been years since I've seen glitches at the mountroot prompt. > > > > So > > > > the problem may be in vt or kbdmux. > > > > > > > When I had a console character echo problem (not serial), changing > > > the > > > clock source to RTC fixed it. > > > > > > > I fixed this for the UART code a while ago in r260890. Maybe a > > similar fix > > is needed here? Basically, is the data being consumed by the > > interrupt > > handler before we can poll-read it... > > > > Warner > > Your cngrab fixes were only for uart? Or was it some other fix? > Yes, I only fixed uart. But the cngrab interface is generic. I didn't have issues with the console code at the time, but there's been two elephants of change in that code since then, including a rewrite. Perhaps some of that change broke what was working at the time and needs to be fixed. Perhaps it was working only by accident, like the UARTs were for years before I made the fix (well, working on and off... something broke them a bit before I made the change). mountroot> is so little used that things can break there and be broken for years before people notice. Warner