From owner-svn-src-all@freebsd.org Wed Mar 23 02:11:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1FE8AC9141; Wed, 23 Mar 2016 02:11:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D1CE51157; Wed, 23 Mar 2016 02:11:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id C97AA10ED; Wed, 23 Mar 2016 02:11:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 8116E18866; Wed, 23 Mar 2016 02:11:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id YsCZDSKSH6cJ; Wed, 23 Mar 2016 02:11:21 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 0E51F18863 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r297201 - in head: share/man/man4 sys/dev/filemon From: Bryan Drewery X-Mailer: iPhone Mail (12H143) In-Reply-To: Date: Tue, 22 Mar 2016 19:11:05 -0700 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201603222241.u2MMf7ub090070@repo.freebsd.org> To: "cem@FreeBSD.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 02:11:29 -0000 > On Mar 22, 2016, at 17:41, Conrad Meyer wrote: >=20 >> On Tue, Mar 22, 2016 at 3:41 PM, Bryan Drewery wro= te: >> Author: bdrewery >> Date: Tue Mar 22 22:41:07 2016 >> New Revision: 297201 >> ... >> --- head/share/man/man4/filemon.4 Tue Mar 22 22:41:03 2016 (= r297200) >> +++ head/share/man/man4/filemon.4 Tue Mar 22 22:41:07 2016 (= r297201) >> @@ -161,6 +161,12 @@ No process having the specified process >> The process ID specified is already being traced and was not the current >> process. >> .El >> +.Pp >> +The >> +.Fn close >> +system call on the filemon file descriptor may fail with the errors from= >> +.Xr write 2 >> +if any error is encountered while writing the log. >> .Sh FILES >> .Bl -tag -width ".Pa /dev/filemon" >> .It Pa /dev/filemon >=20 > Shouldn't this be documented in the close(2) manual page instead? (I > believe it is generally true for many kinds of fd where errors can > occur between write and close.) I thought close.2 would have a blurb > like this and I see it doesn't in recent CURRENT. >=20 >=20 The manpage for close(2) does document some errors, one being ENOSPC. The c= lose(2) behavior of returning write(2), really VOP_WRITE(9), errors though i= s specific to filemon since all of the writes are hidden and this is the onl= y place to return an error. I have a review open to resolve a similar issue= in alq(9) as well since all of the writes are asynchronous and there's no A= PI to retrieve any error from. Bryan=