From owner-svn-src-head@FreeBSD.ORG Thu Sep 16 12:13:07 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33B7E1065695; Thu, 16 Sep 2010 12:13:07 +0000 (UTC) (envelope-from andre@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 232908FC24; Thu, 16 Sep 2010 12:13:07 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8GCD7Ul088509; Thu, 16 Sep 2010 12:13:07 GMT (envelope-from andre@svn.freebsd.org) Received: (from andre@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8GCD7uA088507; Thu, 16 Sep 2010 12:13:07 GMT (envelope-from andre@svn.freebsd.org) Message-Id: <201009161213.o8GCD7uA088507@svn.freebsd.org> From: Andre Oppermann Date: Thu, 16 Sep 2010 12:13:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212731 - head/sys/netinet X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2010 12:13:07 -0000 Author: andre Date: Thu Sep 16 12:13:06 2010 New Revision: 212731 URL: http://svn.freebsd.org/changeset/base/212731 Log: Improve comment to TCP_MINMSS by taking the wording from lstewart (with a small difference in the last paragraph though) as suggested by jhb. Clarify that the 'reviewed by' in r212653 by lstewart was for the functional change, not the comments in the committed version. Modified: head/sys/netinet/tcp.h Modified: head/sys/netinet/tcp.h ============================================================================== --- head/sys/netinet/tcp.h Thu Sep 16 12:05:46 2010 (r212730) +++ head/sys/netinet/tcp.h Thu Sep 16 12:13:06 2010 (r212731) @@ -120,18 +120,18 @@ struct tcphdr { #define TCP6_MSS 1220 /* - * Limit the lowest MSS we accept from path MTU discovery and the TCP SYN MSS - * option. Allowing too low values of MSS can consume significant amounts of - * resources and be used as a form of a resource exhaustion attack. + * Limit the lowest MSS we accept for path MTU discovery and the TCP SYN MSS + * option. Allowing low values of MSS can consume significant resources and + * be used to mount a resource exhaustion attack. * Connections requesting lower MSS values will be rounded up to this value - * and the IP_DF flag is cleared to allow fragmentation along the path. + * and the IP_DF flag will be cleared to allow fragmentation along the path. * * See tcp_subr.c tcp_minmss SYSCTL declaration for more comments. Setting * it to "0" disables the minmss check. * - * The default value is fine for the smallest official link MTU (256 bytes, - * AX.25 packet radio) in the Internet. However it is very unlikely to come - * across such low MTU interfaces these days (anno domini 2003). + * The default value is fine for TCP across the Internet's smallest official + * link MTU (256 bytes for AX.25 packet radio). However, a connection is very + * unlikely to come across such low MTU interfaces these days (anno domini 2003). */ #define TCP_MINMSS 216