From owner-freebsd-net@FreeBSD.ORG Thu Apr 5 07:29:49 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A978916A402 for ; Thu, 5 Apr 2007 07:29:49 +0000 (UTC) (envelope-from b@helectronics.de) Received: from server73.greatnet.de (server73.greatnet.de [83.133.96.46]) by mx1.freebsd.org (Postfix) with ESMTP id 40EBD13C45E for ; Thu, 5 Apr 2007 07:29:49 +0000 (UTC) (envelope-from b@helectronics.de) Received: from localhost (localhost [127.0.0.1]) by server73.greatnet.de (Postfix) with ESMTP id 19D74900ADF for ; Thu, 5 Apr 2007 09:29:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at server73.greatnet.de Received: from server73.greatnet.de ([127.0.0.1]) by localhost (server73.greatnet.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DYayk+J6rs3z for ; Thu, 5 Apr 2007 09:29:45 +0200 (CEST) Received: from home.bh.net (dslb-084-062-003-004.pools.arcor-ip.net [84.62.3.4]) by server73.greatnet.de (Postfix) with ESMTP id CEC01900ADA for ; Thu, 5 Apr 2007 09:29:44 +0200 (CEST) Date: Thu, 5 Apr 2007 09:29:45 +0200 From: Marv To: freebsd-net@freebsd.org Message-ID: <20070405072945.GA1418@home.bh.net> References: <20070404100200.GA1167@home.bh.net> <20070404111158.GB11525@cdnetworks.co.kr> <20070404190649.GB986@home.bh.net> <20070405001533.GA15837@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070405001533.GA15837@cdnetworks.co.kr> User-Agent: Mutt/1.4.2.2i Subject: Re: if_msk in 6.2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 07:29:49 -0000 It works with acpi disabled: mskkc0: port 0x2000-0x20ff mem 0xd0000000-0xd0003fff irq 16 at device 0.0 on pci2 msk0: on mskc0 msk0: Ethernet address: 00:16:36:8a:f4:a3 miibus0: on msk0 e1000phy0: on miibus0 e1000phy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto When using acpi I get the same error as before but without hang of course. On Thu, Apr 05, 2007 at 09:15:33AM +0900, Pyun YongHyeon wrote: > On Wed, Apr 04, 2007 at 09:06:49PM +0200, Marv wrote: > > Thanks for your reply. I checked out the kernel source tree of RELENG_6, > > applied your patch and compiled a new kernel. > > > > The kernel boots and detects a 88E8038 Ethernet card but then hangs: > > > > mskc0: irq 16 at device 0.0 on > > pci2 > > mskc0: 0x4000 bytes of rid 0x10 res 3 failed (0, 0xffffffff). > > mskc0: unknown device: id=0xff, rev=0x0f > > > > (doing nothing no more at this point). > > > > Was there some kind of detection failure or is my ethernet controller > > not configured properly to fit the driver? > > > > Since msk(4) supports 88E8038 I guess the device was not properly > initialized/recognized by system BIOS. > > But it's driver bug if it hang your system when it encounter an > exceptional condition. Try attached patch and report back the result. > It wouldn't fix device recognization but it will not hang your system. > > -- > Regards, > Pyun YongHyeon > Index: if_msk.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/msk/if_msk.c,v > retrieving revision 1.11.2.2 > diff -u -r1.11.2.2 if_msk.c > --- if_msk.c 2 Apr 2007 01:22:31 -0000 1.11.2.2 > +++ if_msk.c 5 Apr 2007 00:12:53 -0000 > @@ -1581,8 +1581,8 @@ > sc->msk_hw_id > CHIP_ID_YUKON_FE) { > device_printf(dev, "unknown device: id=0x%02x, rev=0x%02x\n", > sc->msk_hw_id, sc->msk_hw_rev); > - error = ENXIO; > - goto fail; > + mtx_destroy(&sc->msk_mtx); > + return (ENXIO); > } > > SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),