From owner-svn-src-head@FreeBSD.ORG  Fri Jun 29 07:42:13 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8BD90106566B;
	Fri, 29 Jun 2012 07:42:13 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 771618FC12;
	Fri, 29 Jun 2012 07:42:12 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA05023;
	Fri, 29 Jun 2012 10:42:11 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1SkVqE-0004Of-Vc; Fri, 29 Jun 2012 10:42:11 +0300
Message-ID: <4FED5C51.9060603@FreeBSD.org>
Date: Fri, 29 Jun 2012 10:42:09 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120620 Thunderbird/13.0.1
MIME-Version: 1.0
To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
	svn-src-head@FreeBSD.org
References: <201206290735.q5T7ZbSk026312@svn.freebsd.org>
In-Reply-To: <201206290735.q5T7ZbSk026312@svn.freebsd.org>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: svn commit: r237748 - in head/sys/cddl/dev/dtrace: amd64 i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2012 07:42:13 -0000

on 29/06/2012 10:35 Andriy Gapon said the following:
> Author: avg
> Date: Fri Jun 29 07:35:37 2012
> New Revision: 237748
> URL: http://svn.freebsd.org/changeset/base/237748
> 
> Log:
>   dtrace instruction decoder: add 0x0f 0x1f NOP opcode support
>   
>   According to the AMD manual the whole range from 0x09 to 0x1f are NOPs.
>   Intel manual mentions only 0x1f.  Use only Intel one for now, it seems
>   to be the one actually generated by compilers.
>   Use gdb mnemonic for the operation: "nopw".

BTW, here I have a patch that brings our copy of dtrace dis_tables.c to the
latest version available in OpenSolaris code:
http://people.freebsd.org/~avg/dtrace-disassm-osol.diff

I haven't studied at all what the newer code brings in, but it must be some
fixes and improvements, I guess :-)
The change is mostly a mechanical merge, plus some changes on top to get the
code to compile.
I've been using the code for a few weeks and haven't run into any problems.

Should I put this change into the tree?

-- 
Andriy Gapon