From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 20 20:10:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 30746544 for ; Wed, 20 Mar 2013 20:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F23981C9 for ; Wed, 20 Mar 2013 20:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2KKA07p076618 for ; Wed, 20 Mar 2013 20:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2KKA0Xp076617; Wed, 20 Mar 2013 20:10:00 GMT (envelope-from gnats) Resent-Date: Wed, 20 Mar 2013 20:10:00 GMT Resent-Message-Id: <201303202010.r2KKA0Xp076617@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, hiren panchasara Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 952003E1 for ; Wed, 20 Mar 2013 20:06:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 8569F18A for ; Wed, 20 Mar 2013 20:06:03 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2KK63Mx071283 for ; Wed, 20 Mar 2013 20:06:03 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r2KK632x071282; Wed, 20 Mar 2013 20:06:03 GMT (envelope-from nobody) Message-Id: <201303202006.r2KK632x071282@red.freebsd.org> Date: Wed, 20 Mar 2013 20:06:03 GMT From: hiren panchasara To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/177155: [patch] Fixing clang warnings at /sys/dev/safe X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2013 20:10:01 -0000 >Number: 177155 >Category: kern >Synopsis: [patch] Fixing clang warnings at /sys/dev/safe >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 20 20:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: hiren panchasara >Release: current >Organization: >Environment: 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r248555: Wed Mar 20 15:00:20 UTC 2013 >Description: ===> safe (all) /usr/src/sys/modules/safe/../../dev/safe/safe.c:1610:11: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] while (j >= 0) { ~ ^ ~ /usr/src/sys/modules/safe/../../dev/safe/safe.c:1622:11: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] while (j >= 0) { ~ ^ ~ 2 warnings generated. Proposed fix is replacing always true condition "j >= 0" with 1. I _hope_ this is the correct way to "fix" this. >How-To-Repeat: cd /sys/modules/safe and do "make" to see clang warnings. >Fix: Index: safe.c =================================================================== --- safe.c (revision 248555) +++ safe.c (working copy) @@ -1607,7 +1607,7 @@ * Advance src and dst to offset. */ j = offset; - while (j >= 0) { + while (1) { if (srcm->m_len > j) break; j -= srcm->m_len; @@ -1619,7 +1619,7 @@ slen = srcm->m_len - j; j = offset; - while (j >= 0) { + while (1) { if (dstm->m_len > j) break; j -= dstm->m_len; >Release-Note: >Audit-Trail: >Unformatted: