From owner-svn-src-all@FreeBSD.ORG Fri Oct 1 13:10:11 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C108106566B; Fri, 1 Oct 2010 13:10:11 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7B7308FC15; Fri, 1 Oct 2010 13:10:11 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o91DABqv007536; Fri, 1 Oct 2010 13:10:11 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o91DABUU007534; Fri, 1 Oct 2010 13:10:11 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201010011310.o91DABUU007534@svn.freebsd.org> From: Jilles Tjoelker Date: Fri, 1 Oct 2010 13:10:11 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r213326 - head/lib/libc/i386/string X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 13:10:11 -0000 Author: jilles Date: Fri Oct 1 13:10:11 2010 New Revision: 213326 URL: http://svn.freebsd.org/changeset/base/213326 Log: libc: Remove the i386 assembler version of strlen(3). On anything modern, the C version, which processes a word at a time, is much faster. The Intel optimization manual explicitly warns against using REP prefixes with SCAS or CMPS, which is exactly what the assembler version does. A simple test on a Phenom II showed the C version, compiled with -O2, to be about twice as fast determining the length of 100000 strings between 0 and 255 bytes long. MFC after: 2 weeks Deleted: head/lib/libc/i386/string/strlen.S Modified: head/lib/libc/i386/string/Makefile.inc Modified: head/lib/libc/i386/string/Makefile.inc ============================================================================== --- head/lib/libc/i386/string/Makefile.inc Fri Oct 1 11:48:14 2010 (r213325) +++ head/lib/libc/i386/string/Makefile.inc Fri Oct 1 13:10:11 2010 (r213326) @@ -3,5 +3,5 @@ MDSRCS+=bcmp.S bcopy.S bzero.S ffs.S index.S memchr.S memcmp.S memcpy.S \ memmove.S memset.S rindex.S strcat.S strchr.S strcmp.S strcpy.S \ - strlen.S strncmp.S strrchr.S swab.S wcschr.S wcscmp.S wcslen.S \ + strncmp.S strrchr.S swab.S wcschr.S wcscmp.S wcslen.S \ wmemchr.S