From owner-freebsd-bugs@FreeBSD.ORG Thu May 15 17:30:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 009591065683 for ; Thu, 15 May 2008 17:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D81088FC2C for ; Thu, 15 May 2008 17:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m4FHU3rG093690 for ; Thu, 15 May 2008 17:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m4FHU3En093689; Thu, 15 May 2008 17:30:03 GMT (envelope-from gnats) Date: Thu, 15 May 2008 17:30:03 GMT Message-Id: <200805151730.m4FHU3En093689@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Craig Rodrigues Cc: Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Craig Rodrigues List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2008 17:30:04 -0000 The following reply was made to PR kern/122833; it has been noted by GNATS. From: Craig Rodrigues To: Jaakko Heinonen Cc: bug-followup@FreeBSD.org, Ga??l Roualland , leon.kos@lecad.fs.uni-lj.si, rodrigc@FreeBSD.org, Yar Tikhiy Subject: Re: kern/122833: [snapshots] [patch] mountd fails on nmount() after UFS snapshot creation with mount Date: Thu, 15 May 2008 17:22:13 +0000 On Thu, May 15, 2008 at 01:35:39PM +0300, Jaakko Heinonen wrote: > I wonder if we should add the option removal code also there or remove > the "snapshot" handling completely from vfs_donmount(). For me it seems We should remove the MNT_SNAPSHOT handling code from vfs_donmount(), because it only makes sense in UFS. -- Craig Rodrigues rodrigc@crodrigues.org