From owner-svn-src-all@FreeBSD.ORG Wed Mar 24 14:15:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B02F1065690; Wed, 24 Mar 2010 14:15:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 2B7248FC20; Wed, 24 Mar 2010 14:15:50 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id D1A8D46B3B; Wed, 24 Mar 2010 10:15:49 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 246168A01F; Wed, 24 Mar 2010 10:15:46 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Wed, 24 Mar 2010 10:07:22 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003232149.o2NLnYfs097218@svn.freebsd.org> <20100323215554.GH2415@deviant.kiev.zoral.com.ua> In-Reply-To: <20100323215554.GH2415@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201003241007.22189.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 24 Mar 2010 10:15:46 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205541 - head/sys/compat/linprocfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 14:15:50 -0000 On Tuesday 23 March 2010 5:55:54 pm Kostik Belousov wrote: > On Tue, Mar 23, 2010 at 09:49:34PM +0000, John Baldwin wrote: > > Author: jhb > > Date: Tue Mar 23 21:49:33 2010 > > New Revision: 205541 > > URL: http://svn.freebsd.org/changeset/base/205541 > > > > Log: > > Implement /proc/filesystems. > > > > Submitted by: Fernando Apesteguia fernando.apesteguia (gmail) > > > > Modified: > > head/sys/compat/linprocfs/linprocfs.c > > > > Modified: head/sys/compat/linprocfs/linprocfs.c > > ============================================================================== > > --- head/sys/compat/linprocfs/linprocfs.c Tue Mar 23 21:43:01 2010 (r205540) > > +++ head/sys/compat/linprocfs/linprocfs.c Tue Mar 23 21:49:33 2010 (r205541) > > @@ -1227,6 +1227,22 @@ linprocfs_docmdline(PFS_FILL_ARGS) > > return (0); > > } > > > > +/* > > + * Filler function for proc/filesystems > > + */ > > +static int > > +linprocfs_dofilesystems(PFS_FILL_ARGS) > > +{ > > + struct vfsconf *vfsp; > > + > > + TAILQ_FOREACH(vfsp, &vfsconf, vfc_list) { > > + if (vfsp->vfc_flags & VFCF_SYNTHETIC) > > + sbuf_printf(sb, "nodev"); > > + sbuf_printf(sb, "\t%s\n", vfsp->vfc_name); > > + } > > + return(0); > > +} > I think the list iteration should be protected by Giant. > Am I mistaken ? Oh, yeah, that is true. -- John Baldwin