From owner-freebsd-current@FreeBSD.ORG Sat Jul 7 13:09:03 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D32BC16A469; Sat, 7 Jul 2007 13:09:03 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 2B2C813C448; Sat, 7 Jul 2007 13:09:02 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l67D91MX097192; Sat, 7 Jul 2007 17:09:01 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nagual.pp.ru; s=default; t=1183813741; bh=L/fEMjnQqfRykm7C6vfVC5AO0IwRS5pgfUHyb9F mBnc=; l=1366; h=Received:Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=aa5EPsa90G2ApBjsl789 BvEb1NYZqESV8jlaS8TI2NtkcUTNIfPdFtrh6xTzUHbrPKXXpn8VKdhNzA1UqJ+thNJ aq5IZ6zpINKIgvh+/Ad6JRXKfTUSDfXRFsYxS6nMJzf2K3dATlDXpLD2hyhFSK/oUUz DFe0yd4JSqA5RyVGM= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l67D90Yt097191; Sat, 7 Jul 2007 17:09:00 +0400 (MSD) (envelope-from ache) Date: Sat, 7 Jul 2007 17:09:00 +0400 From: Andrey Chernov To: "Sean C. Farley" Message-ID: <20070707130859.GA96605@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Sean C. Farley" , Robert Watson , freebsd-current , Michal Mertl References: <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> <20070704144159.X77978@thor.farley.org> <20070704195939.GA35302@nagual.pp.ru> <20070704235630.GA42227@nagual.pp.ru> <20070704215154.O77978@thor.farley.org> <20070705115816.GA50506@nagual.pp.ru> <20070705105922.F98700@thor.farley.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070705105922.F98700@thor.farley.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current , Robert Watson , Michal Mertl Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2007 13:09:03 -0000 On Thu, Jul 05, 2007 at 11:38:53AM -0500, Sean C. Farley wrote: >> Previously the goal of veryfy_env() is just deactivate, the goal of >> build_env() is just build. It was build_env() who insetrts new environ >> variables into envVars array in old variant, isn't? > > Yes, it was. Now, it is to merge in a new environ array. I renamed it > __merge_environ() to better reflect its new role. Well, I see. You try to keep envVars[] between environ switch by that way. But it still look complicated and probably gains nothing. I.e. will be much _faster_ just free envVars[] (but not variables themselfs) and allow build_env() to calloc() new array for envVars and fills it from new environ. It is surely faster than calling setenv() for each variable just for sake of keepeng once allocated envVars[]. Moreover, environ switch commonly used to switch from large environ to smaller one (or to empty one), so the rest of old envVars[] array would keep unneccessary allocation. > The alternative, which I had actually considered, is to split setenv() > into __setenv() which is almost the entire current setenv() and a new > setenv() that is just a wrapper around __setenv() with the beginning > checks. This seems a bit of a waste, but I may be mistaken. Well, no recurse level increase problems but just slowdown. -- http://ache.pp.ru/